Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 15 | abstract class AuthController extends ControllerBase{ |
||
| 16 | /** |
||
| 17 | * @var AuthFiles |
||
| 18 | */ |
||
| 19 | protected $authFiles; |
||
| 20 | |||
| 21 | public function index(){ |
||
| 24 | |||
| 25 | /** |
||
| 26 | * To override |
||
| 27 | * Return the base route for this Auth controller |
||
| 28 | * @return string |
||
| 29 | */ |
||
| 30 | public function _getBaseRoute(){ |
||
| 33 | /** |
||
| 34 | * {@inheritDoc} |
||
| 35 | * @see \controllers\ControllerBase::isValid() |
||
| 36 | */ |
||
| 37 | public final function isValid() { |
||
| 40 | |||
| 41 | /** |
||
| 42 | * Action called when the user does not have access rights to a requested resource |
||
| 43 | * @param array $urlParts |
||
| 44 | */ |
||
| 45 | public function noAccess($urlParts){ |
||
| 52 | |||
| 53 | /** |
||
| 54 | * Override for modifying the noAccess message |
||
| 55 | * @param FlashMessage $fMessage |
||
| 56 | */ |
||
| 57 | protected function noAccessMessage(FlashMessage $fMessage){ |
||
| 60 | |||
| 61 | /** |
||
| 62 | * Override to implement the complete connection procedure |
||
| 63 | */ |
||
| 64 | public function connect(){ |
||
| 73 | |||
| 74 | /** |
||
| 75 | * Processes the data posted by the login form |
||
| 76 | * Have to return the connected user instance |
||
| 77 | */ |
||
| 78 | abstract protected function _connect(); |
||
| 79 | |||
| 80 | /** |
||
| 81 | * @param object $connected |
||
| 82 | */ |
||
| 83 | abstract protected function onConnect($connected); |
||
| 84 | |||
| 85 | /** |
||
| 86 | * To override for defining a new action when creditentials are invalid |
||
| 87 | */ |
||
| 88 | protected function onBadCreditentials(){ |
||
| 91 | |||
| 92 | /** |
||
| 93 | * Default Action for invalid creditentials |
||
| 94 | */ |
||
| 95 | View Code Duplication | public function badLogin(){ |
|
| 101 | |||
| 102 | /** |
||
| 103 | * To override for modifying the bad login message |
||
| 104 | * @param FlashMessage $fMessage |
||
| 105 | */ |
||
| 106 | protected function badLoginMessage(FlashMessage $fMessage){ |
||
| 109 | |||
| 110 | private function authLoadView($viewName,$vars=[]){ |
||
| 121 | |||
| 122 | /** |
||
| 123 | * Logout action |
||
| 124 | * Terminate the session and display a logout message |
||
| 125 | */ |
||
| 126 | View Code Duplication | public function terminate(){ |
|
| 133 | |||
| 134 | /** |
||
| 135 | * To override for modifying the logout message |
||
| 136 | * @param FlashMessage $fMessage |
||
| 137 | */ |
||
| 138 | protected function terminateMessage(FlashMessage $fMessage){ |
||
| 141 | |||
| 142 | /** |
||
| 143 | * Action displaying the logged user information |
||
| 144 | */ |
||
| 145 | public function info(){ |
||
| 148 | |||
| 149 | protected function fMessage(FlashMessage $fMessage){ |
||
| 152 | |||
| 153 | public function message($type,$header,$body,$icon="info"){ |
||
| 156 | |||
| 157 | protected function getOriginalURL(){ |
||
| 160 | |||
| 161 | /** |
||
| 162 | * To override for defining user session key, default : "activeUser" |
||
| 163 | * @return string |
||
| 164 | */ |
||
| 165 | public function _getUserSessionKey(){ |
||
| 168 | |||
| 169 | /** |
||
| 170 | * |
||
| 171 | */ |
||
| 172 | abstract public function _isValidUser(); |
||
| 173 | |||
| 174 | /** |
||
| 175 | * To override for changing view files |
||
| 176 | * @return AuthFiles |
||
| 177 | */ |
||
| 178 | protected function getFiles ():AuthFiles{ |
||
| 181 | |||
| 182 | private function _getFiles():AuthFiles{ |
||
| 188 | |||
| 189 | } |
||
| 190 |