Ubiquity\utils\base\UFileSystem::getLines()

Complexity

Conditions	17
Paths	16

Size

Total Lines	52
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
	public static function getLines($filename,$reverse=false,$maxLines=null,$lineCallback=null){
		if(file_exists($filename)){
			$result=[];
			if($reverse && isset($maxLines)){
				$fl = fopen($filename, "r");
				 for($x_pos = 0, $ln = 0,$lines=[]; fseek($fl, $x_pos, SEEK_END) !== -1; $x_pos--) {

It seems like $fl can also be of type false; however, parameter $handle of fseek() does only seem to accept resource, maybe add an additional type check?

					 $char = fgetc($fl);

It seems like $fl can also be of type false; however, parameter $handle of fgetc() does only seem to accept resource, maybe add an additional type check?

					 if ($char === "\n") {
					 	if(is_callable($lineCallback)){
					 		$lineCallback($result,$lines[$ln]);
					 	}else{
					 		$result[]=$lines[$ln];
					 	}
					 	if(isset($maxLines) && sizeof($result)>=$maxLines){
					 		fclose($fl);

It seems like $fl can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

					 		return $result;
					 	}
					 $ln++;
					 continue;
					 }
					 $lines[$ln] = $char . ((array_key_exists($ln, $lines)) ? $lines[$ln] : '');
				 }
				 fclose($fl);
				 return $result;
			 }else{
				$handle = fopen($filename, "r");
				if ($handle) {

$handle is of type false|resource, thus it always evaluated to false.

					while (($line = fgets($handle)) !== false) {
						if(is_callable($lineCallback)){
							$lineCallback($result,$line);
						}else{
							$result[]=$line;
						}
						if(isset($maxLines) && sizeof($result)>=$maxLines){
							fclose($handle);
							if(is_array($result)){
								$result=array_reverse($result);
							}
							return $result;
						}
					}
					fclose($handle);
				} else {
					// error opening the file.
				}
				if($reverse){
					$result=array_reverse($result);
				}
				return $result;
			}
		}
		return [];
	}