LengthValidator::validate() - Code Metrics - Inspection of "Adds server side validation" - phpMv/ubiquity - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f8bd36...f2dc96 )

by Jean-Christophe

created 2018-12-28 02:55 UTC

LengthValidator::validate() C

↳ Parent: LengthValidator

Complexity

Conditions	15
Paths	8

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	31
rs	5.9166
c	0
b	0
f	0
cc	15
nc	8
nop	1

How to fix Complexity

<?php

namespace Ubiquity\contents\validation\validators\multiples;

use Ubiquity\log\Logger;

/**
 * Validate Strings length using min, max, charset,notNull parameters
 * @author jc
 */
class LengthValidator extends ValidatorMultipleNotNull {
	
	protected $min;
	protected $max;
	protected $charset="UTF-8";
	
	public function __construct(){
		parent::__construct();
		$this->message=array_merge($this->message,[
				"max"=>"This value must be at least {min} characters long",
				"min"=>"This value cannot be longer than {max} characters",
				"exact"=>"This value should have exactly {min} characters.",
				"charset"=>"This value is not in {charset} charset"
		]);
	}
	
	public function validate($value) {
		if(parent::validate($value)===false){
			return false;
		}
		if (null === $value || '' === $value) {
			return true;
		}
		if (!is_scalar($value) && !(\is_object($value) && method_exists($value, '__toString'))) {
			Logger::warn("Validation", "This value is not valid string for the charset ".$this->charset);
			return true;
		}
		$stringValue = (string) $value;
		if (@mb_check_encoding($stringValue, $this->charset)) {
			$length = mb_strlen($stringValue, $this->charset);
			if($this->min===$this->max && $this->min!==null && $length!==$this->max){
				$this->violation="exact";
				return false;
			}elseif($this->max!==null && $length>$this->max){
				$this->violation="max";
				return false;
			}elseif($this->min!==null && $length<$this->min){
				$this->violation="min";
				return false;
			}
			return true;
		}else{
			$this->violation="charset";
			return false;
		}
		return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
	}
	
	/**
	 * {@inheritDoc}
	 * @see \Ubiquity\contents\validation\validators\Validator::getParameters()
	 */
	public function getParameters(): array {
		return ["min","max","charset","value"];
	}

}



1			<?php
2
3			namespace Ubiquity\contents\validation\validators\multiples;
4
5			use Ubiquity\log\Logger;
6
7			/**
8			* Validate Strings length using min, max, charset,notNull parameters
9			* @author jc
10			*/
11			class LengthValidator extends ValidatorMultipleNotNull {
12
13			protected $min;
14			protected $max;
15			protected $charset="UTF-8";
16
17			public function __construct(){
18			parent::__construct();
19			$this->message=array_merge($this->message,[
20			"max"=>"This value must be at least {min} characters long",
21			"min"=>"This value cannot be longer than {max} characters",
22			"exact"=>"This value should have exactly {min} characters.",
23			"charset"=>"This value is not in {charset} charset"
24			]);
25			}
26
27			public function validate($value) {
28			if(parent::validate($value)===false){
29			return false;
30			}
31			if (null === $value \|\| '' === $value) {
32			return true;
33			}
34			if (!is_scalar($value) && !(\is_object($value) && method_exists($value, '__toString'))) {
35			Logger::warn("Validation", "This value is not valid string for the charset ".$this->charset);
36			return true;
37			}
38			$stringValue = (string) $value;
39			if (@mb_check_encoding($stringValue, $this->charset)) {
40			$length = mb_strlen($stringValue, $this->charset);
41			if($this->min===$this->max && $this->min!==null && $length!==$this->max){
42			$this->violation="exact";
43			return false;
44			}elseif($this->max!==null && $length>$this->max){
45			$this->violation="max";
46			return false;
47			}elseif($this->min!==null && $length<$this->min){
48			$this->violation="min";
49			return false;
50			}
51			return true;
52			}else{
53			$this->violation="charset";
54			return false;
55			}
56			return false;
			0 ignored issues – show Unused Code introduced 2018-12-28 02:57 UTC by Report Bug Copy Issue Report `return false;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
57			}
58
59			/**
60			* {@inheritDoc}
61			* @see \Ubiquity\contents\validation\validators\Validator::getParameters()
62			*/
63			public function getParameters(): array {
64			return ["min","max","charset","value"];
65			}
66
67			}
68
69

phpMv / ubiquity

Push — master ( f8bd36...f2dc96 )

LengthValidator::validate() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like