Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 17 | abstract class AuthController extends ControllerBase{ |
||
| 18 | /** |
||
| 19 | * @var AuthFiles |
||
| 20 | */ |
||
| 21 | protected $authFiles; |
||
| 22 | |||
| 23 | public function index(){ |
||
| 29 | |||
| 30 | /** |
||
| 31 | * To override |
||
| 32 | * Return the base route for this Auth controller |
||
| 33 | * @return string |
||
| 34 | */ |
||
| 35 | public function _getBaseRoute(){ |
||
| 38 | /** |
||
| 39 | * {@inheritDoc} |
||
| 40 | * @see \controllers\ControllerBase::isValid() |
||
| 41 | */ |
||
| 42 | public final function isValid() { |
||
| 45 | |||
| 46 | /** |
||
| 47 | * Action called when the user does not have access rights to a requested resource |
||
| 48 | * @param array|string $urlParts |
||
| 49 | */ |
||
| 50 | public function noAccess($urlParts){ |
||
| 60 | |||
| 61 | /** |
||
| 62 | * Override for modifying the noAccess message |
||
| 63 | * @param FlashMessage $fMessage |
||
| 64 | */ |
||
| 65 | protected function noAccessMessage(FlashMessage $fMessage){ |
||
| 68 | |||
| 69 | /** |
||
| 70 | * Override to implement the complete connection procedure |
||
| 71 | */ |
||
| 72 | public function connect(){ |
||
| 81 | |||
| 82 | /** |
||
| 83 | * Processes the data posted by the login form |
||
| 84 | * Have to return the connected user instance |
||
| 85 | */ |
||
| 86 | abstract protected function _connect(); |
||
| 87 | |||
| 88 | /** |
||
| 89 | * @param object $connected |
||
| 90 | */ |
||
| 91 | abstract protected function onConnect($connected); |
||
| 92 | |||
| 93 | /** |
||
| 94 | * To override for defining a new action when creditentials are invalid |
||
| 95 | */ |
||
| 96 | protected function onBadCreditentials(){ |
||
| 99 | |||
| 100 | /** |
||
| 101 | * Default Action for invalid creditentials |
||
| 102 | */ |
||
| 103 | View Code Duplication | public function badLogin(){ |
|
| 109 | |||
| 110 | /** |
||
| 111 | * To override for modifying the bad login message |
||
| 112 | * @param FlashMessage $fMessage |
||
| 113 | */ |
||
| 114 | protected function badLoginMessage(FlashMessage $fMessage){ |
||
| 117 | |||
| 118 | private function authLoadView($viewName,$vars=[]){ |
||
| 129 | |||
| 130 | /** |
||
| 131 | * Logout action |
||
| 132 | * Terminate the session and display a logout message |
||
| 133 | */ |
||
| 134 | View Code Duplication | public function terminate(){ |
|
| 141 | |||
| 142 | public function _disConnected(){ |
||
| 149 | |||
| 150 | /** |
||
| 151 | * To override for modifying the logout message |
||
| 152 | * @param FlashMessage $fMessage |
||
| 153 | */ |
||
| 154 | protected function terminateMessage(FlashMessage $fMessage){ |
||
| 157 | |||
| 158 | /** |
||
| 159 | * To override for modifying the disconnect message |
||
| 160 | * @param FlashMessage $fMessage |
||
| 161 | */ |
||
| 162 | protected function disconnectedMessage(FlashMessage $fMessage){ |
||
| 165 | |||
| 166 | /** |
||
| 167 | * Action displaying the logged user information |
||
| 168 | * if _displayInfoAsString returns true, use _infoUser var in views to display user info |
||
| 169 | * @return string|null |
||
| 170 | */ |
||
| 171 | public function info(){ |
||
| 174 | |||
| 175 | protected function fMessage(FlashMessage $fMessage){ |
||
| 178 | |||
| 179 | public function message($type,$header,$body,$icon="info"){ |
||
| 182 | |||
| 183 | protected function getOriginalURL(){ |
||
| 186 | |||
| 187 | /** |
||
| 188 | * To override for defining user session key, default : "activeUser" |
||
| 189 | * @return string |
||
| 190 | */ |
||
| 191 | public function _getUserSessionKey(){ |
||
| 194 | |||
| 195 | public function _checkConnection(){ |
||
| 199 | |||
| 200 | /** |
||
| 201 | * return boolean true if activeUser is valid |
||
| 202 | */ |
||
| 203 | abstract public function _isValidUser(); |
||
| 204 | |||
| 205 | /** |
||
| 206 | * To override for changing view files |
||
| 207 | * @return AuthFiles |
||
| 208 | */ |
||
| 209 | protected function getFiles ():AuthFiles{ |
||
| 212 | |||
| 213 | /** |
||
| 214 | * Override to define if info is displayed as string |
||
| 215 | * if set to true, use _infoUser var in views to display user info |
||
| 216 | */ |
||
| 217 | public function _displayInfoAsString(){ |
||
| 220 | |||
| 221 | public function _checkConnectionTimeout(){ |
||
| 224 | |||
| 225 | private function _getFiles():AuthFiles{ |
||
| 231 | |||
| 232 | public function _getLoginInputName(){ |
||
| 235 | |||
| 236 | protected function loginLabel(){ |
||
| 239 | |||
| 240 | public function _getPasswordInputName(){ |
||
| 243 | |||
| 244 | protected function passwordLabel(){ |
||
| 247 | |||
| 248 | public function _getBodySelector(){ |
||
| 251 | } |
||
| 252 |