AclListOperationsTrait::removeAcl() - Code Metrics - Inspection of "Update AclListOperationsTrait.php" - phpMv/ubiquity-acl - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — main ( 4b33bb...ef3f31 )

by Jean-Christophe

created 2020-10-12 01:16 UTC

AclListOperationsTrait::removeAcl() B

↳ Parent: AclListOperationsTrait

Complexity

Conditions	10
Paths	8

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
cc	10
eloc	8
c	2
b	0
f	1
nc	8
nop	3
dl	0
loc	12
rs	7.6666

How to fix Complexity

<?php
namespace Ubiquity\security\acl\models\traits;

use Ubiquity\security\acl\models\AclElement;
use Ubiquity\security\acl\models\AbstractAclPart;

/**
 * Ubiquity\security\acl\models\traits$AclListOperations
 * This class is part of Ubiquity
 *
 * @author jc
 * @version 1.0.0
 *
 */
trait AclListOperationsTrait {

	abstract public function getRoleByName(string $name);

	abstract public function getResourceByName(string $name);

	abstract public function getPermissionByName(string $name);

	public function saveAclElement(AclElement $aclElement) {
		foreach ($this->providers as $provider) {
			$provider->saveAcl($aclElement);
		}
	}

	public function removeAclElement(AclElement $aclElement) {
		foreach ($this->providers as $provider) {
			$provider->removeAcl($aclElement);
		}
	}

	public function savePart(AbstractAclPart $aclPart) {
		foreach ($this->providers as $provider) {
			$provider->savePart($aclPart);
		}
	}

	public function updatePart(AbstractAclPart $aclPart) {
		foreach ($this->providers as $provider) {
			$provider->updatePart($aclPart);
		}
	}

	public function removePart(AbstractAclPart $aclPart) {
		foreach ($this->providers as $provider) {
			$provider->removePart($aclPart);
		}
	}

	public function removeRole(string $roleName) {
		$role = $this->getRoleByName($roleName);
		unset($this->roles["role_$roleName"]);
		$this->unsetCache("role_$roleName");
		$this->removeAcl($roleName);
		$this->removePart($role);
	}

	protected function unsetCache($name) {
		if (isset($this->elementsCache[$name])) {
			unset($this->elementsCache[$name]);
		}
	}

	public function removePermission(string $permissionName) {
		$permission = $this->getPermissionByName($permissionName);
		unset($this->permissions["perm_$permissionName"]);
		$this->unsetCache("perm_$permissionName");
		$this->removeAcl(null, null, $permissionName);
		$this->removePart($permission);
	}

	public function removeResource(string $resourceName) {
		$resource = $this->getResourceByName($resourceName);
		unset($this->resources["res_$resourceName"]);
		$this->unsetCache("res_$resourceName");
		$this->removeAcl(null, $resourceName);
		$this->removePart($resource);
	}

	public function removeAcl(string $roleName = null, string $resourceName = null, string $permissionName = null) {
		$toRemove = [];
		foreach ($this->acls as $index => $acl) {
			if (($resourceName == null || $acl->getResource()->getName() === $resourceName) && ($roleName == null || $acl->getRole()->getName() === $roleName) && ($permissionName == null || $acl->getPermission()->getName() === $permissionName)) {

				foreach ($this->providers as $provider) {
					$provider->removeAcl($acl);
				}
				$toRemove[] = $index;
			}
		}
		foreach ($toRemove as $remove) {
			unset($this->acls[$remove]);
		}
	}

	public function saveAll() {
		foreach ($this->providers as $provider) {
			if (! $provider->isAutosave()) {
				$provider->saveAll();
			}
		}
	}
}



1			<?php
2			namespace Ubiquity\security\acl\models\traits;
3
4			use Ubiquity\security\acl\models\AclElement;
5			use Ubiquity\security\acl\models\AbstractAclPart;
6
7			/**
8			* Ubiquity\security\acl\models\traits$AclListOperations
9			* This class is part of Ubiquity
10			*
11			* @author jc
12			* @version 1.0.0
13			*
14			*/
15			trait AclListOperationsTrait {
16
17			abstract public function getRoleByName(string $name);
18
19			abstract public function getResourceByName(string $name);
20
21			abstract public function getPermissionByName(string $name);
22
23			public function saveAclElement(AclElement $aclElement) {
24			foreach ($this->providers as $provider) {
25			$provider->saveAcl($aclElement);
26			}
27			}
28
29			public function removeAclElement(AclElement $aclElement) {
30			foreach ($this->providers as $provider) {
31			$provider->removeAcl($aclElement);
32			}
33			}
34
35			public function savePart(AbstractAclPart $aclPart) {
36			foreach ($this->providers as $provider) {
37			$provider->savePart($aclPart);
38			}
39			}
40
41			public function updatePart(AbstractAclPart $aclPart) {
42			foreach ($this->providers as $provider) {
43			$provider->updatePart($aclPart);
44			}
45			}
46
47			public function removePart(AbstractAclPart $aclPart) {
48			foreach ($this->providers as $provider) {
49			$provider->removePart($aclPart);
50			}
51			}
52
53			public function removeRole(string $roleName) {
54			$role = $this->getRoleByName($roleName);
55			unset($this->roles["role_$roleName"]);
56			$this->unsetCache("role_$roleName");
57			$this->removeAcl($roleName);
58			$this->removePart($role);
59			}
60
61			protected function unsetCache($name) {
62			if (isset($this->elementsCache[$name])) {
63			unset($this->elementsCache[$name]);
64			}
65			}
66
67			public function removePermission(string $permissionName) {
68			$permission = $this->getPermissionByName($permissionName);
69			unset($this->permissions["perm_$permissionName"]);
70			$this->unsetCache("perm_$permissionName");
71			$this->removeAcl(null, null, $permissionName);
72			$this->removePart($permission);
73			}
74
75			public function removeResource(string $resourceName) {
76			$resource = $this->getResourceByName($resourceName);
77			unset($this->resources["res_$resourceName"]);
78			$this->unsetCache("res_$resourceName");
79			$this->removeAcl(null, $resourceName);
80			$this->removePart($resource);
81			}
82
83			public function removeAcl(string $roleName = null, string $resourceName = null, string $permissionName = null) {
84			$toRemove = [];
85			foreach ($this->acls as $index => $acl) {
86			if (($resourceName == null \|\| $acl->getResource()->getName() === $resourceName) && ($roleName == null \|\| $acl->getRole()->getName() === $roleName) && ($permissionName == null \|\| $acl->getPermission()->getName() === $permissionName)) {
			3 ignored issues – show Bug introduced 2020-10-12 00:51 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$resourceName` of type `null\|string` against `null`; this is ambiguous if the string can be empty. Consider using a strict comparison `===` instead. Loading history... Bug introduced 2020-10-12 00:51 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$permissionName` of type `null\|string` against `null`; this is ambiguous if the string can be empty. Consider using a strict comparison `===` instead. Loading history... Bug introduced 2020-10-12 00:51 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$roleName` of type `null\|string` against `null`; this is ambiguous if the string can be empty. Consider using a strict comparison `===` instead. Loading history...
87			foreach ($this->providers as $provider) {
88			$provider->removeAcl($acl);
89			}
90			$toRemove[] = $index;
91			}
92			}
93			foreach ($toRemove as $remove) {
94			unset($this->acls[$remove]);
95			}
96			}
97
98			public function saveAll() {
99			foreach ($this->providers as $provider) {
100			if (! $provider->isAutosave()) {
101			$provider->saveAll();
102			}
103			}
104			}
105			}
106
107

phpMv / ubiquity-acl

Push — main ( 4b33bb...ef3f31 )

AclListOperationsTrait::removeAcl() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like