NavElementTrait - Code Metrics - Inspection of "major SensioLabs bug fixed" - phpMv/phpMv-UI - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b77ba2...042f42 )

by Jean-Christophe

created 2017-03-28 17:19 UTC

NavElementTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	8
lcom	1
cbo	0
dl	0
loc	41
rs	10
c	0
b	0
f	0

7 Methods

Rating	Name	Size	Complexity
A	jsSetContent()	3	1
A	getRoot()	3	1
A	setRoot()	4	1
A	getAttr()	3	1
A	setAttr()	4	1
A	__call()	8	3
	fromDispatcher()	1	?

<?php
namespace Ajax\common\html\traits;
use Ajax\JsUtils;

trait NavElementTrait{
	/**
	 * Generate the jquery script to set the elements to the HtmlNavElement
	 * @param JsUtils $jsUtils
	 */
	public function jsSetContent(JsUtils $jsUtils){
		$jsUtils->html("#".$this->identifier,str_replace("\"","'", $this->contentAsString()),true);
class MyClass { }

$x = new MyClass();
$x->foo = true;
	}

	public function getRoot() {
		return $this->root;
class MyClass { }

$x = new MyClass();
$x->foo = true;
	}
	public function setRoot($root) {
		$this->root = $root;
		return $this;
	}
	public function getAttr() {
		return $this->attr;
class MyClass { }

$x = new MyClass();
$x->foo = true;
	}

	/**
	 * Define the html attribute for each element url in ajax
	 * @param string $attr html attribute
	 * @return HtmlNavElement
	 */
	public function setAttr($attr) {
		$this->attr = $attr;
		return $this;
	}

	public function __call($method, $args) {
		if(isset($this->$method) && is_callable($this->$method)) {
			return call_user_func_array(
					$this->$method,
					$args
					);
		}
	}

	abstract public function fromDispatcher(JsUtils $js,$dispatcher,$startIndex=0);
}

1			<?php
2			namespace Ajax\common\html\traits;
3			use Ajax\JsUtils;
4
5			trait NavElementTrait{
6			/**
7			* Generate the jquery script to set the elements to the HtmlNavElement
8			* @param JsUtils $jsUtils
9			*/
10			public function jsSetContent(JsUtils $jsUtils){
11			$jsUtils->html("#".$this->identifier,str_replace("\"","'", $this->contentAsString()),true);
			0 ignored issues – show Bug introduced 2017-03-28 17:23 UTC by Report Bug Copy Issue Report The property `identifier` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Documentation Bug introduced 2017-03-28 17:23 UTC by Report Bug Copy Issue Report The method `contentAsString` does not exist on `object<Ajax\common\html\traits\NavElementTrait>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
12			}
13
14			public function getRoot() {
15			return $this->root;
			0 ignored issues – show Bug introduced 2017-03-28 17:23 UTC by Report Bug Copy Issue Report The property `root` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
16			}
17			public function setRoot($root) {
18			$this->root = $root;
19			return $this;
20			}
21			public function getAttr() {
22			return $this->attr;
			0 ignored issues – show Bug introduced 2017-03-28 17:23 UTC by Report Bug Copy Issue Report The property `attr` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
23			}
24
25			/**
26			* Define the html attribute for each element url in ajax
27			* @param string $attr html attribute
28			* @return HtmlNavElement
29			*/
30			public function setAttr($attr) {
31			$this->attr = $attr;
32			return $this;
33			}
34
35			public function __call($method, $args) {
36			if(isset($this->$method) && is_callable($this->$method)) {
37			return call_user_func_array(
38			$this->$method,
39			$args
40			);
41			}
42			}
43
44			abstract public function fromDispatcher(JsUtils $js,$dispatcher,$startIndex=0);
45			}

phpMv / phpMv-UI

Push — master ( b77ba2...042f42 )

NavElementTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

Duplication Side-by-Side

Filter issues like