HtmlTR::getColCount() - Code Metrics - Inspection of "DataElement colwidth + list icons" - phpMv/phpMv-UI - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5f7aee...f5f495 )

by Jean-Christophe

created 2017-03-13 23:24 UTC

HtmlTR::getColCount() A

↳ Parent: HtmlTR

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	3
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

namespace Ajax\semantic\html\content\table;

use Ajax\semantic\html\base\HtmlSemCollection;
use Ajax\semantic\html\base\constants\State;
use Ajax\semantic\html\base\traits\TableElementTrait;
use Ajax\service\JArray;

/**
 *
 * @author jc
 *
 */
class HtmlTR extends HtmlSemCollection {
	use TableElementTrait;
	private $_tdTagName;
	private $_container;
	private $_row;

	public function __construct($identifier) {
		parent::__construct($identifier, "tr", "");
		$this->_states=[ State::ACTIVE,State::POSITIVE,State::NEGATIVE,State::WARNING,State::ERROR,State::DISABLED ];
	}

	public function setColCount($colCount) {
		$count=$this->count();
		for($i=$count; $i < $colCount; $i++) {
			$item=$this->addItem(NULL);
			$item->setTagName($this->_tdTagName);
		}
		return $this;
	}

	public function getColCount(){
		return $this->count();
	}

	/**
	 *
	 * {@inheritDoc}
	 *
	 * @see \Ajax\common\html\HtmlCollection::createItem()
	 */
	protected function createItem($value) {
		$count=$this->count();
		$td=new HtmlTD("", $value, $this->_tdTagName);
		$td->setContainer($this->_container, $this->_row, $count);
		return $td;
	}

	public function setTdTagName($tagName="td") {
		$this->_tdTagName=$tagName;
	}

	/**
	 * Define the container (HtmlTableContent) and the num of the row
	 * @param HtmlTableContent $container
	 * @param int $row
	 */
	public function setContainer($container, $row) {
		$this->_container=$container;
		$this->_row=$row;
	}

	/**
	 * Sets values to the row cols
	 * @param mixed $values
	 */
	public function setValues($values=array()) {
		return $this->_addOrSetValues($values, function(&$cell,$value){$cell->setValue($value);});
	}

	/**
	 * Adds values to the row cols
	 * @param mixed $values
	 */
	public function addValues($values=array()) {
		return $this->_addOrSetValues($values, function(&$cell,$value){$cell->addValue($value);});
	}

	/**
	 * Sets or adds values to the row cols
	 * @param mixed $values
	 */
	protected function _addOrSetValues($values,$callback) {
		$count=$this->count();
		if (!\is_array($values)) {
			$values=\array_fill(0, $count, $values);
		} else {
			if (JArray::isAssociative($values) === true) {
				$values=\array_values($values);
			}
		}
		$count=\min(\sizeof($values), $count);

		for($i=0; $i < $count; $i++) {

			$cell=$this->content[$i];
			$callback($cell,$values[$i]);
		}
		return $this;
	}

	/**
	 * Removes the col at $index
	 * @param int $index the index of the col to remove
	 * @return \Ajax\semantic\html\content\table\HtmlTR
	 */
	public function delete($index) {
		$this->removeItem($index);
		return $this;
	}

	public function mergeCol($colIndex=0) {
		return $this->getItem($colIndex)->mergeCol();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
	}

	public function mergeRow($colIndex=0) {
		return $this->getItem($colIndex)->mergeRow();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
	}

	public function getColPosition($colIndex) {
		$pos=0;
		$rows=$this->_container->getContent();
		for($i=0; $i < $this->_row; $i++) {
			$max=\min($colIndex, $rows[$i]->count());
			for($j=0; $j < $max; $j++) {
				$rowspan=$rows[$i]->getItem($j)->getRowspan();
				if ($rowspan + $i > $this->_row)
					$pos++;
			}
		}
		if ($pos > $colIndex)
			return NULL;
		$count=$this->count();
		for($i=0; $i < $count; $i++) {
			$pos+=$this->content[$i]->getColspan();
			if ($pos >= $colIndex + 1)
				return $i;
		}
		return null;
	}

	public function conditionalCellFormat($callback, $format) {
		$cells=$this->content;
		foreach ( $cells as $cell ) {
			$cell->conditionalCellFormat($callback, $format);
		}
		return $this;
	}

	public function conditionalRowFormat($callback, $format) {
		if ($callback($this)) {
			$this->addToProperty("class", $format);
		}
		return $this;
	}

	public function containsStr($needle) {
		$cells=$this->content;
		foreach ( $cells as $cell ) {
			if (\strpos($cell->getContent(), $needle) !== false)
				return true;
		}
		return false;
	}

	public function apply($callback) {
		$callback($this);
		return $this;
	}

	public function applyCells($callback) {
		$cells=$this->content;
		foreach ( $cells as $cell ) {
			$cell->apply($callback);
		}
		return $this;
	}
}

1		<?php
2
3		namespace Ajax\semantic\html\content\table;
4
5		use Ajax\semantic\html\base\HtmlSemCollection;
6		use Ajax\semantic\html\base\constants\State;
7		use Ajax\semantic\html\base\traits\TableElementTrait;
8		use Ajax\service\JArray;
9
10		/**
11		*
12		* @author jc
13		*
14		*/
15		class HtmlTR extends HtmlSemCollection {
16		use TableElementTrait;
17		private $_tdTagName;
18		private $_container;
19		private $_row;
20
21		public function __construct($identifier) {
22		parent::__construct($identifier, "tr", "");
23		$this->_states=[ State::ACTIVE,State::POSITIVE,State::NEGATIVE,State::WARNING,State::ERROR,State::DISABLED ];
24		}
25
26		public function setColCount($colCount) {
27		$count=$this->count();
28		for($i=$count; $i < $colCount; $i++) {
29		$item=$this->addItem(NULL);
30		$item->setTagName($this->_tdTagName);
31		}
32		return $this;
33		}
34
35		public function getColCount(){
36		return $this->count();
37		}
38
39		/**
40		*
41		* {@inheritDoc}
42		*
43		* @see \Ajax\common\html\HtmlCollection::createItem()
44		*/
45		protected function createItem($value) {
46		$count=$this->count();
47		$td=new HtmlTD("", $value, $this->_tdTagName);
48		$td->setContainer($this->_container, $this->_row, $count);
49		return $td;
50		}
51
52		public function setTdTagName($tagName="td") {
53		$this->_tdTagName=$tagName;
54		}
55
56		/**
57		* Define the container (HtmlTableContent) and the num of the row
58		* @param HtmlTableContent $container
59		* @param int $row
60		*/
61		public function setContainer($container, $row) {
62		$this->_container=$container;
63		$this->_row=$row;
64		}
65
66		/**
67		* Sets values to the row cols
68		* @param mixed $values
69		*/
70		public function setValues($values=array()) {
71		return $this->_addOrSetValues($values, function(&$cell,$value){$cell->setValue($value);});
72		}
73
74		/**
75		* Adds values to the row cols
76		* @param mixed $values
77		*/
78		public function addValues($values=array()) {
79		return $this->_addOrSetValues($values, function(&$cell,$value){$cell->addValue($value);});
80		}
81
82		/**
83		* Sets or adds values to the row cols
84		* @param mixed $values
85		*/
86		protected function _addOrSetValues($values,$callback) {
87		$count=$this->count();
88		if (!\is_array($values)) {
89		$values=\array_fill(0, $count, $values);
90		} else {
91		if (JArray::isAssociative($values) === true) {
92		$values=\array_values($values);
93		}
94		}
95		$count=\min(\sizeof($values), $count);
96
97	View Code Duplication	for($i=0; $i < $count; $i++) {
		0 ignored issues – show Duplication introduced 2016-06-16 17:04 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
98		$cell=$this->content[$i];
99		$callback($cell,$values[$i]);
100		}
101		return $this;
102		}
103
104		/**
105		* Removes the col at $index
106		* @param int $index the index of the col to remove
107		* @return \Ajax\semantic\html\content\table\HtmlTR
108		*/
109		public function delete($index) {
110		$this->removeItem($index);
111		return $this;
112		}
113
114		public function mergeCol($colIndex=0) {
115		return $this->getItem($colIndex)->mergeCol();
		0 ignored issues – show Bug introduced 2016-06-16 17:04 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Ajax\common\html\HtmlDoubleElement` as the method `mergeCol()` does only exist in the following sub-classes of `Ajax\common\html\HtmlDoubleElement`: `Ajax\semantic\html\content\table\HtmlTD`, `Ajax\semantic\html\content\table\HtmlTR`, `Ajax\semantic\html\content\table\HtmlTableContent`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
116		}
117
118		public function mergeRow($colIndex=0) {
119		return $this->getItem($colIndex)->mergeRow();
		0 ignored issues – show Bug introduced 2016-06-16 17:04 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Ajax\common\html\HtmlDoubleElement` as the method `mergeRow()` does only exist in the following sub-classes of `Ajax\common\html\HtmlDoubleElement`: `Ajax\semantic\html\content\table\HtmlTD`, `Ajax\semantic\html\content\table\HtmlTR`, `Ajax\semantic\html\content\table\HtmlTableContent`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
120		}
121
122		public function getColPosition($colIndex) {
123		$pos=0;
124		$rows=$this->_container->getContent();
125		for($i=0; $i < $this->_row; $i++) {
126		$max=\min($colIndex, $rows[$i]->count());
127		for($j=0; $j < $max; $j++) {
128		$rowspan=$rows[$i]->getItem($j)->getRowspan();
129		if ($rowspan + $i > $this->_row)
130		$pos++;
131		}
132		}
133		if ($pos > $colIndex)
134		return NULL;
135		$count=$this->count();
136		for($i=0; $i < $count; $i++) {
137		$pos+=$this->content[$i]->getColspan();
138		if ($pos >= $colIndex + 1)
139		return $i;
140		}
141		return null;
142		}
143
144		public function conditionalCellFormat($callback, $format) {
145		$cells=$this->content;
146		foreach ( $cells as $cell ) {
147		$cell->conditionalCellFormat($callback, $format);
148		}
149		return $this;
150		}
151
152		public function conditionalRowFormat($callback, $format) {
153		if ($callback($this)) {
154		$this->addToProperty("class", $format);
155		}
156		return $this;
157		}
158
159		public function containsStr($needle) {
160		$cells=$this->content;
161		foreach ( $cells as $cell ) {
162		if (\strpos($cell->getContent(), $needle) !== false)
163		return true;
164		}
165		return false;
166		}
167
168		public function apply($callback) {
169		$callback($this);
170		return $this;
171		}
172
173		public function applyCells($callback) {
174		$cells=$this->content;
175		foreach ( $cells as $cell ) {
176		$cell->apply($callback);
177		}
178		return $this;
179		}
180		}

phpMv / phpMv-UI

Push — master ( 5f7aee...f5f495 )

HtmlTR::getColCount() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like