@@ -10,6 +10,11 @@ discard block |
||
| 10 | 10 | */ |
| 11 | 11 | trait JsUtilsActionsTrait { |
| 12 | 12 | |
| 13 | + /** |
|
| 14 | + * @param string $element |
|
| 15 | + * @param string $js |
|
| 16 | + * @param string $event |
|
| 17 | + */ |
|
| 13 | 18 | abstract public function _add_event($element, $js, $event, $preventDefault=false, $stopPropagation=false,$immediatly=true); |
| 14 | 19 | /** |
| 15 | 20 | * show or hide with effect |
@@ -34,7 +39,7 @@ discard block |
||
| 34 | 39 | } |
| 35 | 40 | /** |
| 36 | 41 | * Ensures the speed parameter is valid for jQuery |
| 37 | - * @param string|int $speed |
|
| 42 | + * @param string $speed |
|
| 38 | 43 | * @return string |
| 39 | 44 | */ |
| 40 | 45 | private function _validate_speed($speed) { |
@@ -363,7 +368,7 @@ discard block |
||
| 363 | 368 | * |
| 364 | 369 | * @param string $element |
| 365 | 370 | * @param array $options |
| 366 | - * @return void |
|
| 371 | + * @return string |
|
| 367 | 372 | */ |
| 368 | 373 | public function sortable($element, $options=array()) { |
| 369 | 374 | if (count($options)>0) { |
@@ -434,7 +439,7 @@ discard block |
||
| 434 | 439 | * @param string $jqueryCall the JQuery callback |
| 435 | 440 | * @param mixed $param array or string parameters |
| 436 | 441 | * @param string $jsCallback javascript code to execute after the jquery call |
| 437 | - * @return mixed |
|
| 442 | + * @return string |
|
| 438 | 443 | */ |
| 439 | 444 | public function doJQuery($element, $jqueryCall, $param="", $jsCallback="") { |
| 440 | 445 | return $this->_doJQuery($element, $jqueryCall, $param, $jsCallback, true); |
@@ -446,7 +451,7 @@ discard block |
||
| 446 | 451 | * @param string $jqueryCall the JQuery callback |
| 447 | 452 | * @param mixed $param array or string parameters |
| 448 | 453 | * @param string $jsCallback javascript code to execute after the jquery call |
| 449 | - * @return mixed |
|
| 454 | + * @return string |
|
| 450 | 455 | */ |
| 451 | 456 | public function doJQueryDeferred($element, $jqueryCall, $param="", $jsCallback="") { |
| 452 | 457 | return $this->_doJQuery($element, $jqueryCall, $param, $jsCallback, false); |
@@ -458,7 +463,7 @@ discard block |
||
| 458 | 463 | * @param string $element |
| 459 | 464 | * @param string $elementToModify |
| 460 | 465 | * @param string $jqueryCall |
| 461 | - * @param string|array $param |
|
| 466 | + * @param string $param |
|
| 462 | 467 | * @param boolean $preventDefault |
| 463 | 468 | * @param boolean $stopPropagation |
| 464 | 469 | * @param string $jsCallback javascript code to execute after the jquery call |
@@ -28,8 +28,9 @@ discard block |
||
| 28 | 28 | $callback=", function(){\n{$callback}\n}"; |
| 29 | 29 | } |
| 30 | 30 | $str="$({$element}).{$action}({$speed}{$callback});"; |
| 31 | - if ($immediatly) |
|
| 32 | - $this->jquery_code_for_compile[]=$str; |
|
| 31 | + if ($immediatly) { |
|
| 32 | + $this->jquery_code_for_compile[]=$str; |
|
| 33 | + } |
|
| 33 | 34 | return $str; |
| 34 | 35 | } |
| 35 | 36 | /** |
@@ -61,10 +62,12 @@ discard block |
||
| 61 | 62 | if (isset($param)) { |
| 62 | 63 | $param=Javascript::prep_value($param); |
| 63 | 64 | $str="$({$element}).{$jQueryCall}({$param});"; |
| 64 | - } else |
|
| 65 | - $str="$({$element}).{$jQueryCall}();"; |
|
| 66 | - if ($immediatly) |
|
| 67 | - $this->jquery_code_for_compile[]=$str; |
|
| 65 | + } else { |
|
| 66 | + $str="$({$element}).{$jQueryCall}();"; |
|
| 67 | + } |
|
| 68 | + if ($immediatly) { |
|
| 69 | + $this->jquery_code_for_compile[]=$str; |
|
| 70 | + } |
|
| 68 | 71 | return $str; |
| 69 | 72 | } |
| 70 | 73 | |
@@ -80,8 +83,9 @@ discard block |
||
| 80 | 83 | $to=Javascript::prep_element($to); |
| 81 | 84 | $element=Javascript::prep_element($element); |
| 82 | 85 | $str="$({$to}).{$jQueryCall}({$element});"; |
| 83 | - if ($immediatly) |
|
| 84 | - $this->jquery_code_for_compile[]=$str; |
|
| 86 | + if ($immediatly) { |
|
| 87 | + $this->jquery_code_for_compile[]=$str; |
|
| 88 | + } |
|
| 85 | 89 | return $str; |
| 86 | 90 | } |
| 87 | 91 | /** |
@@ -130,10 +134,12 @@ discard block |
||
| 130 | 134 | if (isset($value)) { |
| 131 | 135 | $value=Javascript::prep_value($value); |
| 132 | 136 | $str="$({$element}).attr(\"$attributeName\",{$value});"; |
| 133 | - } else |
|
| 134 | - $str="$({$element}).attr(\"$attributeName\");"; |
|
| 135 | - if ($immediatly) |
|
| 136 | - $this->jquery_code_for_compile[]=$str; |
|
| 137 | + } else { |
|
| 138 | + $str="$({$element}).attr(\"$attributeName\");"; |
|
| 139 | + } |
|
| 140 | + if ($immediatly) { |
|
| 141 | + $this->jquery_code_for_compile[]=$str; |
|
| 142 | + } |
|
| 137 | 143 | return $str; |
| 138 | 144 | } |
| 139 | 145 | |
@@ -189,8 +195,9 @@ discard block |
||
| 189 | 195 | |
| 190 | 196 | $str="$({$element}).animate({\n$animations\n\t\t}".$speed.$extra.");"; |
| 191 | 197 | |
| 192 | - if ($immediatly) |
|
| 193 | - $this->jquery_code_for_compile[]=$str; |
|
| 198 | + if ($immediatly) { |
|
| 199 | + $this->jquery_code_for_compile[]=$str; |
|
| 200 | + } |
|
| 194 | 201 | return $str; |
| 195 | 202 | } |
| 196 | 203 | |
@@ -340,8 +347,9 @@ discard block |
||
| 340 | 347 | $element=Javascript::prep_element($element); |
| 341 | 348 | $str="$({$element}).trigger(\"$event\");"; |
| 342 | 349 | |
| 343 | - if ($immediatly) |
|
| 344 | - $this->jquery_code_for_compile[]=$str; |
|
| 350 | + if ($immediatly) { |
|
| 351 | + $this->jquery_code_for_compile[]=$str; |
|
| 352 | + } |
|
| 345 | 353 | return $str; |
| 346 | 354 | } |
| 347 | 355 | |
@@ -403,8 +411,9 @@ discard block |
||
| 403 | 411 | $str.="else{".$jsCodeIfFalse."}"; |
| 404 | 412 | } |
| 405 | 413 | |
| 406 | - if ($immediatly) |
|
| 407 | - $this->jquery_code_for_compile[]=$str; |
|
| 414 | + if ($immediatly) { |
|
| 415 | + $this->jquery_code_for_compile[]=$str; |
|
| 416 | + } |
|
| 408 | 417 | return $str; |
| 409 | 418 | } |
| 410 | 419 | |
@@ -420,11 +429,13 @@ discard block |
||
| 420 | 429 | private function _doJQuery($element, $jqueryCall, $param="", $jsCallback="", $immediatly=false) { |
| 421 | 430 | $param=Javascript::prep_value($param); |
| 422 | 431 | $callback=""; |
| 423 | - if ($jsCallback!="") |
|
| 424 | - $callback=", function(event){\n{$jsCallback}\n}"; |
|
| 432 | + if ($jsCallback!="") { |
|
| 433 | + $callback=", function(event){\n{$jsCallback}\n}"; |
|
| 434 | + } |
|
| 425 | 435 | $script="$(".Javascript::prep_element($element).").".$jqueryCall."(".$param.$callback.");\n"; |
| 426 | - if ($immediatly) |
|
| 427 | - $this->jquery_code_for_compile[]=$script; |
|
| 436 | + if ($immediatly) { |
|
| 437 | + $this->jquery_code_for_compile[]=$script; |
|
| 438 | + } |
|
| 428 | 439 | return $script; |
| 429 | 440 | } |
| 430 | 441 | |
@@ -495,8 +506,9 @@ discard block |
||
| 495 | 506 | */ |
| 496 | 507 | public function exec($js, $immediatly=false) { |
| 497 | 508 | $script=$js."\n"; |
| 498 | - if ($immediatly) |
|
| 499 | - $this->jquery_code_for_compile[]=$script; |
|
| 509 | + if ($immediatly) { |
|
| 510 | + $this->jquery_code_for_compile[]=$script; |
|
| 511 | + } |
|
| 500 | 512 | return $script; |
| 501 | 513 | } |
| 502 | 514 | |
@@ -16,8 +16,9 @@ discard block |
||
| 16 | 16 | */ |
| 17 | 17 | protected function _compileLibrary($library, &$view=NULL){ |
| 18 | 18 | if ($library!=NULL) { |
| 19 | - if(isset($view)) |
|
| 20 | - $library->compileHtml($this, $view); |
|
| 19 | + if(isset($view)) { |
|
| 20 | + $library->compileHtml($this, $view); |
|
| 21 | + } |
|
| 21 | 22 | if ($library->isAutoCompile()) { |
| 22 | 23 | $library->compile(true); |
| 23 | 24 | } |
@@ -37,7 +38,9 @@ discard block |
||
| 37 | 38 | } |
| 38 | 39 | |
| 39 | 40 | protected function minify($input) { |
| 40 | - if(trim($input) === "") return $input; |
|
| 41 | + if(trim($input) === "") { |
|
| 42 | + return $input; |
|
| 43 | + } |
|
| 41 | 44 | return preg_replace( |
| 42 | 45 | array( |
| 43 | 46 | // Remove comment(s) |