Ajax\semantic\widgets\dataform\FormFieldAsTrait

Complexity

Total Complexity

16

Size/Duplication

Total Lines	100
Duplicated Lines	14 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes

0

13 Methods

Rating	Name	Duplication	Size	Complexity
	_getFieldIdentifier()	0	1	?
	setValueFunction()	0	1	?
A	_getLabelField()	0	4	1
A	_applyAttributes()	0	11	3
A	_addRules()	0	10	3
A	_fieldAs()	0	11	2
A	fieldAsRadio()	0	5	1
A	fieldAsRadios()	0	5	1
A	fieldAsTextarea()	0	7	1
A	fieldAsInput()	7	7	1
A	fieldAsCheckbox()	0	5	1
A	fieldAsDropDown()	7	7	1
A	fieldAsMessage()	0	7	1

<?php
namespace Ajax\semantic\widgets\dataform;
use Ajax\semantic\html\elements\HtmlLabel;
use Ajax\semantic\html\collections\form\HtmlFormRadio;
use Ajax\semantic\html\collections\form\HtmlFormTextarea;
use Ajax\semantic\html\collections\form\HtmlFormField;
use Ajax\semantic\html\collections\form\HtmlFormInput;
use Ajax\semantic\html\collections\form\HtmlFormCheckbox;
use Ajax\semantic\html\collections\form\HtmlFormDropdown;
use Ajax\semantic\html\collections\form\HtmlFormFields;
use Ajax\semantic\html\collections\HtmlMessage;

/**
 * @author jc
 * @property FormInstanceViewer $_instanceViewer
 * @property object $_modelInstance;
 */

trait FormFieldAsTrait{

	abstract protected function _getFieldIdentifier($prefix);
	abstract public function setValueFunction($index,$callback);

	private function _getLabelField($caption,$icon=NULL){

This method is not used, and could be removed.

		$label=new HtmlLabel($this->_getFieldIdentifier("lbl"),$caption,$icon);
		return $label;
	}

	/**
	 * @param HtmlFormField $element
	 * @param array $attributes
	 */
	protected function _applyAttributes($element,&$attributes,$index){
		$this->_addRules($element, $attributes);
		if(isset($attributes["callback"])){
			$callback=$attributes["callback"];
			if(\is_callable($callback)){
				$callback($element,$this->_modelInstance,$index);

The property _modelInstance does not seem to exist. Did you mean _modelInstance;?

				unset($attributes["callback"]);
			}
		}
		$element->fromArray($attributes);
	}

	protected function _addRules($element,$attributes){
		if(isset($attributes["rules"])){
			$rules=$attributes["rules"];
			if(\is_array($rules))
				$element->addRules($rules);
				else
					$element->addRule($rules);
				unset($attributes["rules"]);
		}
	}

	protected function _fieldAs($elementCallback,$index,$attributes=NULL,$identifier=null){

The parameter $identifier is not used and could be removed.

		$this->setValueFunction($index,function($value) use ($index,&$attributes,$elementCallback){
			$caption=$this->_instanceViewer->getCaption($index);
			$name=$this->_instanceViewer->getFieldName($index);
			$element=$elementCallback($this->getIdentifier()."-".$name,$name,$value,$caption);

It seems like getIdentifier() must be provided by classes using this trait. How about adding it as abstract method to this trait?

			if(\is_array($attributes))
				$this->_applyAttributes($element, $attributes,$index);
			return $element;
		});
			return $this;
	}


	public function fieldAsRadio($index,$attributes=NULL){
		return $this->_fieldAs(function($id,$name,$value,$caption){
			return new HtmlFormRadio($id,$name,$caption,$value);
		}, $index,$attributes);
	}

	public function fieldAsRadios($index,$elements=[],$attributes=NULL){

The parameter $elements is not used and could be removed.

		return $this->_fieldAs(function($id,$name,$value,$caption,$elements){
			return HtmlFormFields::radios($name,$elements,$caption,$value);
		}, $index,$attributes);
	}

	public function fieldAsTextarea($index,$attributes=NULL){
		return $this->_fieldAs(function($id,$name,$value,$caption){
			$textarea=new HtmlFormTextarea($id,$caption,$value);
			$textarea->setName($name);
			return $textarea;
		}, $index,$attributes);
	}

	public function fieldAsInput($index,$attributes=NULL){

This method seems to be duplicated in your project.

		return $this->_fieldAs(function($id,$name,$value,$caption){
			$input= new HtmlFormInput($id,$caption,"text",$value);
			$input->setName($name);
			return $input;
		}, $index,$attributes);
	}

	public function fieldAsCheckbox($index,$attributes=NULL){
		return $this->_fieldAs(function($id,$name,$value,$caption){
			return new HtmlFormCheckbox($id,$caption,$value);
		}, $index,$attributes);
	}

	public function fieldAsDropDown($index,$elements=[],$multiple=false,$attributes=NULL){

This method seems to be duplicated in your project.

		return $this->_fieldAs(function($id,$name,$value,$caption) use ($elements,$multiple){
			$dd=new HtmlFormDropdown($id,$elements,$caption,$value,$multiple);
			$dd->setName($name);
			return $dd;
		}, $index,$attributes);
	}

	public function fieldAsMessage($index,$attributes=NULL){
		return $this->_fieldAs(function($id,$name,$value,$caption){
			$mess= new HtmlMessage($id,$value);
			$mess->addHeader($caption);
			return $mess;
		}, $index,$attributes,"message");
	}
}