Passed
Branch master (77da54)
by Jean-Christophe
02:40 queued 14s
created
Ajax/common/html/HtmlCollection.php 1 patch
Spacing   +40 added lines, -40 removed lines patch added patch discarded remove patch
@@ -15,44 +15,44 @@  discard block
 block discarded – undo
15 15
  */
16 16
 abstract class HtmlCollection extends HtmlDoubleElement {
17 17
 
18
-	public function __construct($identifier,$tagName="div"){
19
-		parent::__construct($identifier,$tagName);
18
+	public function __construct($identifier, $tagName="div") {
19
+		parent::__construct($identifier, $tagName);
20 20
 		$this->content=array();
21 21
 	}
22 22
 
23
-	public function addItems($items){
24
-		if(JArray::isAssociative($items)){
25
-			foreach ($items as $k=>$v){
26
-				$this->addItem([$k,$v]);
23
+	public function addItems($items) {
24
+		if (JArray::isAssociative($items)) {
25
+			foreach ($items as $k=>$v) {
26
+				$this->addItem([$k, $v]);
27 27
 			}
28
-		}else{
29
-			foreach ($items as $item){
28
+		} else {
29
+			foreach ($items as $item) {
30 30
 				$this->addItem($item);
31 31
 			}
32 32
 		}
33 33
 		return $this;
34 34
 	}
35 35
 
36
-	public function setItems($items){
36
+	public function setItems($items) {
37 37
 		$this->content=$items;
38 38
 		return $this;
39 39
 	}
40 40
 
41
-	public function getItems(){
41
+	public function getItems() {
42 42
 		return $this->content;
43 43
 	}
44 44
 
45
-	protected function getItemToAdd($item){
45
+	protected function getItemToAdd($item) {
46 46
 		$itemO=$item;
47
-		if($this->createCondition($item)===true){
47
+		if ($this->createCondition($item)===true) {
48 48
 			$itemO=$this->createItem($item);
49 49
 		}
50 50
 		return $itemO;
51 51
 	}
52 52
 
53
-	protected function setItemIdentifier($item,$classname,$index){
54
-		if($item instanceof BaseWidget){
55
-			if(JString::isNull($item->getIdentifier())){
53
+	protected function setItemIdentifier($item, $classname, $index) {
54
+		if ($item instanceof BaseWidget) {
55
+			if (JString::isNull($item->getIdentifier())) {
56 56
 				$item->setIdentifier($classname."-".$this->identifier."-".$index);
57 57
 			}
58 58
 		}
@@ -63,15 +63,15 @@  discard block
 block discarded – undo
63 63
 	 * @param HtmlDoubleElement|string|array $item
64 64
 	 * @return \Ajax\common\html\HtmlDoubleElement
65 65
 	 */
66
-	public function addItem($item){
66
+	public function addItem($item) {
67 67
 		$itemO=$this->getItemToAdd($item);
68 68
 		$this->addContent($itemO);
69 69
 		return $itemO;
70 70
 	}
71 71
 
72
-	public function insertItem($item,$position=0){
72
+	public function insertItem($item, $position=0) {
73 73
 		$itemO=$this->getItemToAdd($item);
74
-		\array_splice( $this->content, $position, 0, array($itemO));
74
+		\array_splice($this->content, $position, 0, array($itemO));
75 75
 		return $itemO;
76 76
 	}
77 77
 
@@ -94,11 +94,11 @@  discard block
 block discarded – undo
94 94
 		return $this;
95 95
 	}
96 96
 
97
-	public function removeItem($index){
97
+	public function removeItem($index) {
98 98
 		return array_splice($this->content, $index, 1);
99 99
 	}
100 100
 
101
-	public function count(){
101
+	public function count() {
102 102
 		return \sizeof($this->content);
103 103
 	}
104 104
 
@@ -109,8 +109,8 @@  discard block
 block discarded – undo
109 109
 		return $this->addItem($function($object));
110 110
 	}
111 111
 
112
-	public function apply($callBack){
113
-		foreach ($this->content as $item){
112
+	public function apply($callBack) {
113
+		foreach ($this->content as $item) {
114 114
 			$callBack($item);
115 115
 		}
116 116
 		return $this;
@@ -130,23 +130,23 @@  discard block
 block discarded – undo
130 130
 	 */
131 131
 	abstract protected function createItem($value);
132 132
 
133
-	protected function createCondition($value){
133
+	protected function createCondition($value) {
134 134
 		return \is_object($value)===false;
135 135
 	}
136 136
 
137
-	protected function contentAs($tagName){
138
-		foreach ($this->content as $item){
137
+	protected function contentAs($tagName) {
138
+		foreach ($this->content as $item) {
139 139
 			$item->setTagName($tagName);
140 140
 		}
141 141
 		return $this;
142 142
 	}
143 143
 
144
-	public function setProperties($properties){
144
+	public function setProperties($properties) {
145 145
 		$i=0;
146
-		foreach ($properties as $k=>$v){
146
+		foreach ($properties as $k=>$v) {
147 147
 			$c=$this->content[$i++];
148
-			if(isset($c))
149
-				$c->setProperty($k,$v);
148
+			if (isset($c))
149
+				$c->setProperty($k, $v);
150 150
 			else
151 151
 				return $this;
152 152
 		}
@@ -159,17 +159,17 @@  discard block
 block discarded – undo
159 159
 	 * @param array $values
160 160
 	 * @return HtmlCollection
161 161
 	 */
162
-	public function setPropertyValues($property,$values){
162
+	public function setPropertyValues($property, $values) {
163 163
 		$i=0;
164
-		if(\is_array($values)===false){
165
-			$values=\array_fill(0, $this->count(),$values);
164
+		if (\is_array($values)===false) {
165
+			$values=\array_fill(0, $this->count(), $values);
166 166
 		}
167
-		foreach ($values as $value){
167
+		foreach ($values as $value) {
168 168
 			$c=$this->content[$i++];
169
-			if(isset($c)){
170
-				$c->setProperty($property,$value);
169
+			if (isset($c)) {
170
+				$c->setProperty($property, $value);
171 171
 			}
172
-			else{
172
+			else {
173 173
 				return $this;
174 174
 			}
175 175
 		}
@@ -179,13 +179,13 @@  discard block
 block discarded – undo
179 179
 	public function compile(JsUtils $js=NULL, &$view=NULL) {
180 180
 		$index=0;
181 181
 		$classname=\strtolower(JReflection::shortClassName($this));
182
-		foreach ($this->content as $item){
183
-			$this->setItemIdentifier($item,$classname,$index++);
182
+		foreach ($this->content as $item) {
183
+			$this->setItemIdentifier($item, $classname, $index++);
184 184
 		}
185
-		return parent::compile($js,$view);
185
+		return parent::compile($js, $view);
186 186
 	}
187 187
 
188
-	public function getItemById($identifier){
188
+	public function getItemById($identifier) {
189 189
 		return $this->getElementById($identifier, $this->content);
190 190
 	}
191 191
 }
Please login to merge, or discard this patch.
Ajax/common/traits/JsUtilsEventsTrait.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -11,11 +11,11 @@  discard block
 block discarded – undo
11 11
 trait JsUtilsEventsTrait {
12 12
 
13 13
 
14
-	protected $jquery_events=array (
15
-			"bind","blur","change","click","dblclick","delegate","die","error","focus","focusin","focusout","hover","keydown","keypress","keyup","live","load","mousedown","mousseenter","mouseleave","mousemove","mouseout","mouseover","mouseup","off","on","one","ready","resize","scroll","select","submit","toggle","trigger","triggerHandler","undind","undelegate","unload"
14
+	protected $jquery_events=array(
15
+			"bind", "blur", "change", "click", "dblclick", "delegate", "die", "error", "focus", "focusin", "focusout", "hover", "keydown", "keypress", "keyup", "live", "load", "mousedown", "mousseenter", "mouseleave", "mousemove", "mouseout", "mouseover", "mouseup", "off", "on", "one", "ready", "resize", "scroll", "select", "submit", "toggle", "trigger", "triggerHandler", "undind", "undelegate", "unload"
16 16
 	);
17 17
 
18
-	abstract public function _add_event($element, $js, $event, $preventDefault=false, $stopPropagation=false,$immediatly=true);
18
+	abstract public function _add_event($element, $js, $event, $preventDefault=false, $stopPropagation=false, $immediatly=true);
19 19
 
20 20
 	/**
21 21
 	 * Outputs a javascript library blur event
@@ -37,8 +37,8 @@  discard block
 block discarded – undo
37 37
 	 * @param boolean $stopPropagation
38 38
 	 * @return string
39 39
 	 */
40
-	public function change($element='this', $js='',$preventDefault=false,$stopPropagation=false) {
41
-		return $this->_add_event($element, $js, 'change',$preventDefault,$stopPropagation);
40
+	public function change($element='this', $js='', $preventDefault=false, $stopPropagation=false) {
41
+		return $this->_add_event($element, $js, 'change', $preventDefault, $stopPropagation);
42 42
 	}
43 43
 
44 44
 	/**
@@ -51,9 +51,9 @@  discard block
 block discarded – undo
51 51
 	 * @param boolean $stopPropagation
52 52
 	 * @return string
53 53
 	 */
54
-	public function click($element='this', $js='', $ret_false=TRUE,$preventDefault=false,$stopPropagation=false) {
54
+	public function click($element='this', $js='', $ret_false=TRUE, $preventDefault=false, $stopPropagation=false) {
55 55
 		if (!is_array($js)) {
56
-			$js=array (
56
+			$js=array(
57 57
 					$js
58 58
 			);
59 59
 		}
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 			$js[]="return false;";
63 63
 		}
64 64
 
65
-		return $this->_add_event($element, $js, 'click',$preventDefault,$stopPropagation);
65
+		return $this->_add_event($element, $js, 'click', $preventDefault, $stopPropagation);
66 66
 	}
67 67
 
68 68
 	/**
Please login to merge, or discard this patch.
Ajax/semantic/components/validation/Rule.php 1 patch
Spacing   +49 added lines, -49 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@  discard block
 block discarded – undo
8 8
  * @version 1.001
9 9
  * Generates a JSON Rule for the validation of a field
10 10
  */
11
-class Rule implements \JsonSerializable{
11
+class Rule implements \JsonSerializable {
12 12
 	/**
13 13
 	 * @var string
14 14
 	 */
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
 	 */
24 24
 	private $value;
25 25
 
26
-	public function __construct($type,$prompt=NULL,$value=NULL){
26
+	public function __construct($type, $prompt=NULL, $value=NULL) {
27 27
 		$this->type=$type;
28 28
 		$this->prompt=$prompt;
29 29
 		$this->value=$value;
@@ -57,10 +57,10 @@  discard block
 block discarded – undo
57 57
 	}
58 58
 
59 59
 	public function jsonSerialize() {
60
-		$result= ["type"=>$this->type];
61
-		if(isset($this->prompt))
60
+		$result=["type"=>$this->type];
61
+		if (isset($this->prompt))
62 62
 			$result["prompt"]=$this->prompt;
63
-		if(isset($this->value))
63
+		if (isset($this->value))
64 64
 			$result["value"]=$this->value;
65 65
 		return $result;
66 66
 	}
@@ -71,8 +71,8 @@  discard block
 block discarded – undo
71 71
 	 * @param string $prompt
72 72
 	 * @return \Ajax\semantic\components\validation\Rule
73 73
 	 */
74
-	public static function match($name,$prompt=NULL){
75
-		return new Rule("match[".$name."]",$prompt);
74
+	public static function match($name, $prompt=NULL) {
75
+		return new Rule("match[".$name."]", $prompt);
76 76
 	}
77 77
 
78 78
 	/**
@@ -81,8 +81,8 @@  discard block
 block discarded – undo
81 81
 	 * @param string $prompt
82 82
 	 * @return \Ajax\semantic\components\validation\Rule
83 83
 	 */
84
-	public static function different($name,$prompt=NULL){
85
-		return new Rule("different[".$name."]",$prompt);
84
+	public static function different($name, $prompt=NULL) {
85
+		return new Rule("different[".$name."]", $prompt);
86 86
 	}
87 87
 
88 88
 	/**
@@ -92,82 +92,82 @@  discard block
 block discarded – undo
92 92
 	 * @param string $prompt
93 93
 	 * @return \Ajax\semantic\components\validation\Rule
94 94
 	 */
95
-	public static function integer($min=NULL,$max=NULL,$prompt=NULL){
96
-		if(\is_int($min) && \is_int($max))
97
-			return new Rule("integer[{$min}..{$max}]",$prompt);
98
-		return new Rule("integer",$prompt);
95
+	public static function integer($min=NULL, $max=NULL, $prompt=NULL) {
96
+		if (\is_int($min) && \is_int($max))
97
+			return new Rule("integer[{$min}..{$max}]", $prompt);
98
+		return new Rule("integer", $prompt);
99 99
 	}
100 100
 
101
-	public static function decimal($prompt=NULL){
102
-		return new Rule("decimal",$prompt);
101
+	public static function decimal($prompt=NULL) {
102
+		return new Rule("decimal", $prompt);
103 103
 	}
104 104
 
105
-	public static function number($prompt=NULL){
106
-		return new Rule("number",$prompt);
105
+	public static function number($prompt=NULL) {
106
+		return new Rule("number", $prompt);
107 107
 	}
108 108
 
109
-	public static function is($value,$prompt=NULL){
110
-		return new Rule("is[".$value."]",$prompt);
109
+	public static function is($value, $prompt=NULL) {
110
+		return new Rule("is[".$value."]", $prompt);
111 111
 	}
112 112
 
113
-	public static function isExactly($value,$prompt=NULL){
114
-		return new Rule("isExactly[".$value."]",$prompt);
113
+	public static function isExactly($value, $prompt=NULL) {
114
+		return new Rule("isExactly[".$value."]", $prompt);
115 115
 	}
116 116
 
117
-	public static function not($value,$prompt=NULL){
118
-		return new Rule("not[".$value."]",$prompt);
117
+	public static function not($value, $prompt=NULL) {
118
+		return new Rule("not[".$value."]", $prompt);
119 119
 	}
120 120
 
121
-	public static function notExactly($value,$prompt=NULL){
122
-		return new Rule("notExactly[".$value."]",$prompt);
121
+	public static function notExactly($value, $prompt=NULL) {
122
+		return new Rule("notExactly[".$value."]", $prompt);
123 123
 	}
124 124
 
125
-	public static function contains($value,$prompt=NULL){
126
-		return new Rule("contains[".$value."]",$prompt);
125
+	public static function contains($value, $prompt=NULL) {
126
+		return new Rule("contains[".$value."]", $prompt);
127 127
 	}
128 128
 
129
-	public static function containsExactly($value,$prompt=NULL){
130
-		return new Rule("containsExactly[".$value."]",$prompt);
129
+	public static function containsExactly($value, $prompt=NULL) {
130
+		return new Rule("containsExactly[".$value."]", $prompt);
131 131
 	}
132 132
 
133
-	public static function doesntContain($value,$prompt=NULL){
134
-		return new Rule("doesntContain[".$value."]",$prompt);
133
+	public static function doesntContain($value, $prompt=NULL) {
134
+		return new Rule("doesntContain[".$value."]", $prompt);
135 135
 	}
136 136
 
137
-	public static function doesntContainExactly($value,$prompt=NULL){
138
-		return new Rule("doesntContainExactly[".$value."]",$prompt);
137
+	public static function doesntContainExactly($value, $prompt=NULL) {
138
+		return new Rule("doesntContainExactly[".$value."]", $prompt);
139 139
 	}
140 140
 
141
-	public static function minCount($value,$prompt=NULL){
142
-		return new Rule("minCount[".$value."]",$prompt);
141
+	public static function minCount($value, $prompt=NULL) {
142
+		return new Rule("minCount[".$value."]", $prompt);
143 143
 	}
144 144
 
145
-	public static function maxCount($value,$prompt=NULL){
146
-		return new Rule("maxCount[".$value."]",$prompt);
145
+	public static function maxCount($value, $prompt=NULL) {
146
+		return new Rule("maxCount[".$value."]", $prompt);
147 147
 	}
148 148
 
149
-	public static function exactCount($value,$prompt=NULL){
150
-		return new Rule("exactCount[".$value."]",$prompt);
149
+	public static function exactCount($value, $prompt=NULL) {
150
+		return new Rule("exactCount[".$value."]", $prompt);
151 151
 	}
152 152
 
153
-	public static function email($prompt=NULL){
154
-		return new Rule("email",$prompt);
153
+	public static function email($prompt=NULL) {
154
+		return new Rule("email", $prompt);
155 155
 	}
156 156
 
157
-	public static function url($prompt=NULL){
158
-		return new Rule("url",$prompt);
157
+	public static function url($prompt=NULL) {
158
+		return new Rule("url", $prompt);
159 159
 	}
160 160
 
161
-	public static function regExp($value,$prompt=NULL){
162
-		return new Rule("regExp",$prompt,$value);
161
+	public static function regExp($value, $prompt=NULL) {
162
+		return new Rule("regExp", $prompt, $value);
163 163
 	}
164 164
 
165
-	public static function custom($name,$jsFunction){
166
-		return "$.fn.form.settings.rules.".$name." =".$jsFunction ;
165
+	public static function custom($name, $jsFunction) {
166
+		return "$.fn.form.settings.rules.".$name." =".$jsFunction;
167 167
 	}
168 168
 
169
-	public static function ajax(JsUtils $js,$name,$url,$params,$jsCallback,$method="post",$parameters=[]){
170
-		$parameters=\array_merge(["async"=>false,"url"=>$url,"params"=>$params,"hasLoader"=>false,"jsCallback"=>$jsCallback,"dataType"=>"json","stopPropagation"=>false,"preventDefault"=>false,"responseElement"=>null],$parameters);
169
+	public static function ajax(JsUtils $js, $name, $url, $params, $jsCallback, $method="post", $parameters=[]) {
170
+		$parameters=\array_merge(["async"=>false, "url"=>$url, "params"=>$params, "hasLoader"=>false, "jsCallback"=>$jsCallback, "dataType"=>"json", "stopPropagation"=>false, "preventDefault"=>false, "responseElement"=>null], $parameters);
171 171
 		$ajax=new AjaxCall($method, $parameters);
172 172
 		return self::custom($name, "function(value){var result=true;".$ajax->compile($js)."return result;}");
173 173
 	}
Please login to merge, or discard this patch.
Ajax/common/traits/JsUtilsAjaxTrait.php 1 patch
Spacing   +93 added lines, -93 removed lines patch added patch discarded remove patch
@@ -16,9 +16,9 @@  discard block
 block discarded – undo
16 16
 	protected $ajaxLoader='<span></span><span></span><span></span><span></span><span></span>';
17 17
 
18 18
 	abstract public function getUrl($url);
19
-	abstract public function _add_event($element, $js, $event, $preventDefault=false, $stopPropagation=false,$immediatly=true);
19
+	abstract public function _add_event($element, $js, $event, $preventDefault=false, $stopPropagation=false, $immediatly=true);
20 20
 
21
-	protected function _ajax($method,$url,$responseElement="",$parameters=[]) {
21
+	protected function _ajax($method, $url, $responseElement="", $parameters=[]) {
22 22
 		$jsCallback=null;
23 23
 		$attr="id";
24 24
 		$hasLoader=true;
@@ -35,80 +35,80 @@  discard block
 block discarded – undo
35 35
 		$retour=$this->_getAjaxUrl($url, $attr);
36 36
 		$responseElement=$this->_getResponseElement($responseElement);
37 37
 		$retour.="var self=this;\n";
38
-		if($hasLoader===true && JString::isNotNull($responseElement)){
38
+		if ($hasLoader===true && JString::isNotNull($responseElement)) {
39 39
 			$this->addLoading($retour, $responseElement);
40 40
 		}
41
-		$ajaxParameters=["url"=>"url","method"=>"'".\strtoupper($method)."'"];
42
-		if(!$async){
41
+		$ajaxParameters=["url"=>"url", "method"=>"'".\strtoupper($method)."'"];
42
+		if (!$async) {
43 43
 			$ajaxParameters["async"]="false";
44 44
 		}
45
-		if(isset($params)){
45
+		if (isset($params)) {
46 46
 			$ajaxParameters["data"]=self::_correctParams($params);
47 47
 		}
48
-		if(isset($headers)){
48
+		if (isset($headers)) {
49 49
 			$ajaxParameters["headers"]=$headers;
50 50
 		}
51 51
 		$this->createAjaxParameters($ajaxParameters, $parameters);
52 52
 		$retour.="$.ajax({".$this->implodeAjaxParameters($ajaxParameters)."}).done(function( data, textStatus, jqXHR ) {\n";
53
-		$retour.=$this->_getOnAjaxDone($responseElement, $jqueryDone,$ajaxTransition,$jsCallback)."});\n";
54
-		$retour=$this->_addJsCondition($jsCondition,$retour);
53
+		$retour.=$this->_getOnAjaxDone($responseElement, $jqueryDone, $ajaxTransition, $jsCallback)."});\n";
54
+		$retour=$this->_addJsCondition($jsCondition, $retour);
55 55
 		if ($immediatly)
56 56
 			$this->jquery_code_for_compile[]=$retour;
57 57
 		return $retour;
58 58
 	}
59 59
 
60
-	protected function createAjaxParameters(&$original,$parameters){
61
-		$validParameters=["dataType"=>"'%value%'","beforeSend"=>"function(jqXHR,settings){%value%}","complete"=>"function(jqXHR){%value%}"];
62
-		foreach ($validParameters as $param=>$mask){
63
-			if(isset($parameters[$param])){
60
+	protected function createAjaxParameters(&$original, $parameters) {
61
+		$validParameters=["dataType"=>"'%value%'", "beforeSend"=>"function(jqXHR,settings){%value%}", "complete"=>"function(jqXHR){%value%}"];
62
+		foreach ($validParameters as $param=>$mask) {
63
+			if (isset($parameters[$param])) {
64 64
 				$original[$param]=\str_replace("%value%", $parameters[$param], $mask);
65 65
 			}
66 66
 		}
67 67
 	}
68 68
 
69
-	protected function implodeAjaxParameters($ajaxParameters){
70
-		$s = ''; foreach ($ajaxParameters as $k=>$v) { if ($s !== '') { $s .= ','; } $s .= "'{$k}':{$v}"; }
69
+	protected function implodeAjaxParameters($ajaxParameters) {
70
+		$s=''; foreach ($ajaxParameters as $k=>$v) { if ($s!=='') { $s.=','; } $s.="'{$k}':{$v}"; }
71 71
 		return $s;
72 72
 	}
73 73
 
74
-	protected function _addJsCondition($jsCondition,$jsSource){
75
-		if(isset($jsCondition)){
74
+	protected function _addJsCondition($jsCondition, $jsSource) {
75
+		if (isset($jsCondition)) {
76 76
 			return "if(".$jsCondition."){\n".$jsSource."\n}";
77 77
 		}
78 78
 		return $jsSource;
79 79
 	}
80 80
 
81 81
 
82
-	protected function _getAjaxUrl($url,$attr){
82
+	protected function _getAjaxUrl($url, $attr) {
83 83
 		$url=$this->_correctAjaxUrl($url);
84 84
 		$retour="url='".$url."';";
85 85
 		$slash="/";
86
-		if(JString::endswith($url, "/")===true){
86
+		if (JString::endswith($url, "/")===true) {
87 87
 			$slash="";
88 88
 		}
89
-		if(JString::isNotNull($attr)){
90
-			if ($attr==="value"){
89
+		if (JString::isNotNull($attr)) {
90
+			if ($attr==="value") {
91 91
 				$retour.="url=url+'".$slash."'+$(this).val();\n";
92
-			}elseif ($attr==="html"){
92
+			}elseif ($attr==="html") {
93 93
 				$retour.="url=url+'".$slash."'+$(this).html();\n";
94
-			}elseif(\substr($attr, 0,3)==="js:"){
94
+			}elseif (\substr($attr, 0, 3)==="js:") {
95 95
 				$retour.="url=url+'".$slash."'+".\substr($attr, 3).";\n";
96
-			}elseif($attr!==null && $attr!=="")
96
+			}elseif ($attr!==null && $attr!=="")
97 97
 				$retour.="url=url+'".$slash."'+($(this).attr('".$attr."')||'');\n";
98 98
 		}
99 99
 		return $retour;
100 100
 	}
101 101
 
102
-	protected function _getOnAjaxDone($responseElement,$jqueryDone,$ajaxTransition,$jsCallback){
103
-		$retour="";$call=null;
102
+	protected function _getOnAjaxDone($responseElement, $jqueryDone, $ajaxTransition, $jsCallback) {
103
+		$retour=""; $call=null;
104 104
 		if (JString::isNotNull($responseElement)) {
105
-			if(isset($ajaxTransition)){
105
+			if (isset($ajaxTransition)) {
106 106
 				$call=$this->setAjaxDataCall($ajaxTransition);
107
-			}elseif(isset($this->ajaxTransition)){
107
+			}elseif (isset($this->ajaxTransition)) {
108 108
 				$call=$this->ajaxTransition;
109 109
 			}
110
-			if(\is_callable($call))
111
-				$retour="\t".$call($responseElement,$jqueryDone).";\n";
110
+			if (\is_callable($call))
111
+				$retour="\t".$call($responseElement, $jqueryDone).";\n";
112 112
 			else
113 113
 				$retour="\t{$responseElement}.{$jqueryDone}( data );\n";
114 114
 		}
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 		return $retour;
117 117
 	}
118 118
 
119
-	protected function _getResponseElement($responseElement){
119
+	protected function _getResponseElement($responseElement) {
120 120
 		if (JString::isNotNull($responseElement)) {
121 121
 			$responseElement=Javascript::prep_value($responseElement);
122 122
 			$responseElement=Javascript::prep_jquery_selector($responseElement);
@@ -127,26 +127,26 @@  discard block
 block discarded – undo
127 127
 	protected function _correctAjaxUrl($url) {
128 128
 		if ($url!=="/" && JString::endsWith($url, "/")===true)
129 129
 			$url=substr($url, 0, strlen($url)-1);
130
-			if (strncmp($url, 'http://', 7)!=0&&strncmp($url, 'https://', 8)!=0) {
130
+			if (strncmp($url, 'http://', 7)!=0 && strncmp($url, 'https://', 8)!=0) {
131 131
 				$url=$this->getUrl($url);
132 132
 			}
133 133
 			return $url;
134 134
 	}
135 135
 
136
-	public static function _correctParams($params){
137
-		if(JString::isNull($params)){
136
+	public static function _correctParams($params) {
137
+		if (JString::isNull($params)) {
138 138
 			return "";
139 139
 		}
140
-		if(\preg_match("@^\{.*?\}$@", $params)){
140
+		if (\preg_match("@^\{.*?\}$@", $params)) {
141 141
 			return '$.param('.$params.')';
142 142
 		}
143 143
 		return $params;
144 144
 	}
145 145
 
146
-	public static function _implodeParams($parameters){
146
+	public static function _implodeParams($parameters) {
147 147
 		$allParameters=[];
148
-		foreach ($parameters as $params){
149
-			if(isset($params))
148
+		foreach ($parameters as $params) {
149
+			if (isset($params))
150 150
 				$allParameters[]=self::_correctParams($params);
151 151
 		}
152 152
 		return \implode("+'&'+", $allParameters);
@@ -164,19 +164,19 @@  discard block
 block discarded – undo
164 164
 		$retour.="\t\t{$responseElement}.prepend('{$loading_notifier}');\n";
165 165
 	}
166 166
 
167
-	protected function setAjaxDataCall($params){
167
+	protected function setAjaxDataCall($params) {
168 168
 		$result=null;
169
-		if(!\is_callable($params)){
170
-			$result=function ($responseElement,$jqueryDone="html") use($params){
171
-				return AjaxTransition::{$params}($responseElement,$jqueryDone);
169
+		if (!\is_callable($params)) {
170
+			$result=function($responseElement, $jqueryDone="html") use($params){
171
+				return AjaxTransition::{$params}($responseElement, $jqueryDone);
172 172
 			};
173 173
 		}
174 174
 		return $result;
175 175
 	}
176 176
 
177
-	protected function setDefaultParameters(&$parameters,$default){
178
-		foreach ($default as $k=>$v){
179
-			if(!isset($parameters[$k]))
177
+	protected function setDefaultParameters(&$parameters, $default) {
178
+		foreach ($default as $k=>$v) {
179
+			if (!isset($parameters[$k]))
180 180
 				$parameters[$k]=$v;
181 181
 		}
182 182
 	}
@@ -190,8 +190,8 @@  discard block
 block discarded – undo
190 190
 	 * @param string $url The url of the request
191 191
 	 * @param string $responseElement selector of the HTML element displaying the answer
192 192
 	 */
193
-	private function _get($url, $responseElement="",$parameters=[]) {
194
-		return $this->_ajax("get", $url,$responseElement,$parameters);
193
+	private function _get($url, $responseElement="", $parameters=[]) {
194
+		return $this->_ajax("get", $url, $responseElement, $parameters);
195 195
 	}
196 196
 
197 197
 	/**
@@ -200,9 +200,9 @@  discard block
 block discarded – undo
200 200
 	 * @param string $responseElement selector of the HTML element displaying the answer
201 201
 	 * @param array $parameters default : array("params"=>"{}","jsCallback"=>NULL,"attr"=>"id","hasLoader"=>true,"jqueryDone"=>"html","ajaxTransition"=>null,"jsCondition"=>NULL,"headers"=>null)
202 202
 	 */
203
-	public function get($url, $responseElement="",$parameters=[]) {
203
+	public function get($url, $responseElement="", $parameters=[]) {
204 204
 		$parameters["immediatly"]=true;
205
-		return $this->_get($url,$responseElement,$parameters);
205
+		return $this->_get($url, $responseElement, $parameters);
206 206
 	}
207 207
 
208 208
 	/**
@@ -212,9 +212,9 @@  discard block
 block discarded – undo
212 212
 	 * @param string $responseElement selector of the HTML element displaying the answer
213 213
 	 * @param array $parameters default : array("params"=>"{}","jsCallback"=>NULL,"attr"=>"id","hasLoader"=>true,"jqueryDone"=>"html","ajaxTransition"=>null,"jsCondition"=>NULL,"headers"=>null)
214 214
 	 */
215
-	public function ajax($method,$url, $responseElement="", $parameters=[]) {
215
+	public function ajax($method, $url, $responseElement="", $parameters=[]) {
216 216
 		$parameters["immediatly"]=true;
217
-		return $this->_ajax($method,$url,$responseElement,$parameters);
217
+		return $this->_ajax($method, $url, $responseElement, $parameters);
218 218
 	}
219 219
 
220 220
 	/**
@@ -224,9 +224,9 @@  discard block
 block discarded – undo
224 224
 	 * @param string $responseElement selector of the HTML element displaying the answer
225 225
 	 * @param array $parameters default : array("params"=>"{}","jsCallback"=>NULL,"attr"=>"id","hasLoader"=>true,"jqueryDone"=>"html","ajaxTransition"=>null,"jsCondition"=>NULL,"headers"=>null)
226 226
 	 */
227
-	public function ajaxDeferred($method,$url, $responseElement="", $parameters=[]) {
227
+	public function ajaxDeferred($method, $url, $responseElement="", $parameters=[]) {
228 228
 		$parameters["immediatly"]=false;
229
-		return $this->_ajax($method,$url,$responseElement,$parameters);
229
+		return $this->_ajax($method, $url, $responseElement, $parameters);
230 230
 	}
231 231
 
232 232
 	/**
@@ -235,15 +235,15 @@  discard block
 block discarded – undo
235 235
 	 * @param string $method Method used
236 236
 	 * @param array $parameters default : array("params"=>"{}","jsCallback"=>NULL,"attr"=>"id","context"=>"document","jsCondition"=>NULL,"headers"=>null,"immediatly"=>false)
237 237
 	 */
238
-	private function _json($url, $method="get",$parameters=[]) {
239
-		$parameters=\array_merge($parameters,["hasLoader"=>false]);
238
+	private function _json($url, $method="get", $parameters=[]) {
239
+		$parameters=\array_merge($parameters, ["hasLoader"=>false]);
240 240
 		$jsCallback=isset($parameters['jsCallback']) ? $parameters['jsCallback'] : "";
241 241
 		$context=isset($parameters['context']) ? $parameters['context'] : "document";
242 242
 		$retour="\tdata=($.isPlainObject(data))?data:JSON.parse(data);\t".$jsCallback.";\n\tfor(var key in data){"
243 243
 				."if($('#'+key,".$context.").length){ if($('#'+key,".$context.").is('[value]')) { $('#'+key,".$context.").val(data[key]);} else { $('#'+key,".$context.").html(data[key]); }}};\n";
244 244
 				$retour.="\t$(document).trigger('jsonReady',[data]);\n";
245 245
 		$parameters["jsCallback"]=$retour;
246
-		return $this->_ajax($method, $url,null,$parameters);
246
+		return $this->_ajax($method, $url, null, $parameters);
247 247
 	}
248 248
 
249 249
 	/**
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
 	 * @param array $parameters default : array("params"=>"{}","jsCallback"=>NULL,"attr"=>"id","context"=>"document","jsCondition"=>NULL,"headers"=>null,"immediatly"=>false)
254 254
 	 */
255 255
 	public function json($url, $method="get", $parameters=[]) {
256
-		return $this->_json($url,$method,$parameters);
256
+		return $this->_json($url, $method, $parameters);
257 257
 	}
258 258
 
259 259
 	/**
@@ -264,9 +264,9 @@  discard block
 block discarded – undo
264 264
 	 * @param string $method default get
265 265
 	 * @param array $parameters default : array("preventDefault"=>true,"stopPropagation"=>true,"jsCallback"=>NULL,"attr"=>"id","params"=>"{}","method"=>"get","immediatly"=>true)
266 266
 	 */
267
-	public function jsonOn($event,$element, $url,$method="get",$parameters=array()) {
268
-		$this->setDefaultParameters($parameters, ["preventDefault"=>true,"stopPropagation"=>true,"immediatly"=>true]);
269
-		return $this->_add_event($element, $this->jsonDeferred($url,$method, $parameters), $event, $parameters["preventDefault"], $parameters["stopPropagation"],$parameters["immediatly"]);
267
+	public function jsonOn($event, $element, $url, $method="get", $parameters=array()) {
268
+		$this->setDefaultParameters($parameters, ["preventDefault"=>true, "stopPropagation"=>true, "immediatly"=>true]);
269
+		return $this->_add_event($element, $this->jsonDeferred($url, $method, $parameters), $event, $parameters["preventDefault"], $parameters["stopPropagation"], $parameters["immediatly"]);
270 270
 	}
271 271
 
272 272
 	/**
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
 	 */
278 278
 	public function jsonDeferred($url, $method="get", $parameters=[]) {
279 279
 		$parameters["immediatly"]=false;
280
-		return $this->_json($url,$method,$parameters);
280
+		return $this->_json($url, $method, $parameters);
281 281
 	}
282 282
 
283 283
 	/**
@@ -288,26 +288,26 @@  discard block
 block discarded – undo
288 288
 	 * @param array $parameters default : array("params"=>"{}","jsCallback"=>NULL,"attr"=>"id","context"=>null,"jsCondition"=>NULL,"headers"=>null,"immediatly"=>false,"rowClass"=>"_json")
289 289
 	 */
290 290
 	private function _jsonArray($maskSelector, $url, $method="get", $parameters=[]) {
291
-		$parameters=\array_merge($parameters,["hasLoader"=>false]);
291
+		$parameters=\array_merge($parameters, ["hasLoader"=>false]);
292 292
 		$rowClass=isset($parameters['rowClass']) ? $parameters['rowClass'] : "_json";
293 293
 		$jsCallback=isset($parameters['jsCallback']) ? $parameters['jsCallback'] : "";
294 294
 		$context=isset($parameters['context']) ? $parameters['context'] : null;
295
-		if($context===null){
295
+		if ($context===null) {
296 296
 			$parent="$('".$maskSelector."').parent()";
297
-			$newElm = "$('#'+newId)";
298
-		}else{
297
+			$newElm="$('#'+newId)";
298
+		} else {
299 299
 			$parent=$context;
300
-			$newElm = $context.".find('#'+newId)";
300
+			$newElm=$context.".find('#'+newId)";
301 301
 		}
302 302
 		$appendTo="\t\tnewElm.appendTo(".$parent.");\n";
303 303
 		$retour=$parent.".find('.{$rowClass}').remove();";
304 304
 		$retour.="\tdata=($.isPlainObject(data))?data:JSON.parse(data);\t".$jsCallback.";\n$.each(data, function(index, value) {\n"."\tvar created=false;var maskElm=$('".$maskSelector."').first();maskElm.hide();"."\tvar newId=(maskElm.attr('id') || 'mask')+'-'+index;"."\tvar newElm=".$newElm.";\n"."\tif(!newElm.length){\n"."\t\tnewElm=maskElm.clone();
305 305
 		newElm.attr('id',newId);\n;newElm.addClass('{$rowClass}').removeClass('_jsonArrayModel');\nnewElm.find('[id]').each(function(){ var newId=$(this).attr('id')+'-'+index;$(this).attr('id',newId).removeClass('_jsonArrayChecked');});\n";
306
-		$retour.= $appendTo;
306
+		$retour.=$appendTo;
307 307
 		$retour.="\t}\n"."\tfor(var key in value){\n"."\t\t\tvar html = $('<div />').append($(newElm).clone()).html();\n"."\t\t\tif(html.indexOf('__'+key+'__')>-1){\n"."\t\t\t\tcontent=$(html.split('__'+key+'__').join(value[key]));\n"."\t\t\t\t$(newElm).replaceWith(content);newElm=content;\n"."\t\t\t}\n"."\t\tvar sel='[data-id=\"'+key+'\"]';if($(sel,newElm).length){\n"."\t\t\tvar selElm=$(sel,newElm);\n"."\t\t\t if(selElm.is('[value]')) { selElm.attr('value',value[key]);selElm.val(value[key]);} else { selElm.html(value[key]); }\n"."\t\t}\n"."}\n"."\t$(newElm).show(true);"."\n"."\t$(newElm).removeClass('hide');"."});\n";
308 308
 		$retour.="\t$(document).trigger('jsonReady',[data]);\n";
309 309
 		$parameters["jsCallback"]=$retour;
310
-		return $this->_ajax($method, $url,null,$parameters);
310
+		return $this->_ajax($method, $url, null, $parameters);
311 311
 	}
312 312
 
313 313
 	/**
@@ -318,7 +318,7 @@  discard block
 block discarded – undo
318 318
 	 * @param array $parameters default : array("params"=>"{}","jsCallback"=>NULL,"attr"=>"id","context"=>null,"jsCondition"=>NULL,"headers"=>null,"immediatly"=>false,"rowClass"=>"_json")
319 319
 	 */
320 320
 	public function jsonArray($maskSelector, $url, $method="get", $parameters=[]) {
321
-		return $this->_jsonArray($maskSelector, $url,$method,$parameters);
321
+		return $this->_jsonArray($maskSelector, $url, $method, $parameters);
322 322
 	}
323 323
 
324 324
 	/**
@@ -341,9 +341,9 @@  discard block
 block discarded – undo
341 341
 	 * @param string $method Method used, default : get
342 342
 	 * @param array $parameters default : array("preventDefault"=>true,"stopPropagation"=>true,"jsCallback"=>NULL,"attr"=>"id","params"=>"{}","method"=>"get","rowClass"=>"_json","immediatly"=>true)
343 343
 	 */
344
-	public function jsonArrayOn($event,$element,$maskSelector, $url,$method="get",$parameters=array()) {
345
-		$this->setDefaultParameters($parameters, ["preventDefault"=>true,"stopPropagation"=>true,"immediatly"=>true]);
346
-		return $this->_add_event($element, $this->jsonArrayDeferred($maskSelector,$url,$method, $parameters), $event, $parameters["preventDefault"], $parameters["stopPropagation"],$parameters["immediatly"]);
344
+	public function jsonArrayOn($event, $element, $maskSelector, $url, $method="get", $parameters=array()) {
345
+		$this->setDefaultParameters($parameters, ["preventDefault"=>true, "stopPropagation"=>true, "immediatly"=>true]);
346
+		return $this->_add_event($element, $this->jsonArrayDeferred($maskSelector, $url, $method, $parameters), $event, $parameters["preventDefault"], $parameters["stopPropagation"], $parameters["immediatly"]);
347 347
 	}
348 348
 
349 349
 	/**
@@ -355,7 +355,7 @@  discard block
 block discarded – undo
355 355
 	 */
356 356
 	public function getDeferred($url, $responseElement="", $parameters=[]) {
357 357
 		$parameters["immediatly"]=false;
358
-		return $this->_get($url, $responseElement,$parameters);
358
+		return $this->_get($url, $responseElement, $parameters);
359 359
 	}
360 360
 
361 361
 	/**
@@ -368,8 +368,8 @@  discard block
 block discarded – undo
368 368
 	 * @param array $parameters default : array("preventDefault"=>true,"stopPropagation"=>true,"params"=>"{}","jsCallback"=>NULL,"attr"=>"id","hasLoader"=>true,"immediatly"=>true,"jqueryDone"=>"html","ajaxTransition"=>null,"jsCondition"=>null,"headers"=>null)
369 369
 	 */
370 370
 	public function getOn($event, $element, $url, $responseElement="", $parameters=array()) {
371
-		$this->setDefaultParameters($parameters, ["preventDefault"=>true,"stopPropagation"=>true,"immediatly"=>true]);
372
-		return $this->_add_event($element, $this->getDeferred($url,$responseElement,$parameters), $event, $parameters["preventDefault"], $parameters["stopPropagation"],$parameters["immediatly"]);
371
+		$this->setDefaultParameters($parameters, ["preventDefault"=>true, "stopPropagation"=>true, "immediatly"=>true]);
372
+		return $this->_add_event($element, $this->getDeferred($url, $responseElement, $parameters), $event, $parameters["preventDefault"], $parameters["stopPropagation"], $parameters["immediatly"]);
373 373
 	}
374 374
 
375 375
 	/**
@@ -382,8 +382,8 @@  discard block
 block discarded – undo
382 382
 	 * @param array $parameters default : array("method"=>"get","preventDefault"=>true,"stopPropagation"=>true,"params"=>"{}","jsCallback"=>NULL,"attr"=>"id","hasLoader"=>true,"immediatly"=>true,"jqueryDone"=>"html","jsCondition"=>NULL,"headers"=>null)
383 383
 	 */
384 384
 	public function ajaxOn($event, $element, $url, $responseElement="", $parameters=array()) {
385
-		$this->setDefaultParameters($parameters, ["preventDefault"=>true,"stopPropagation"=>true,"immediatly"=>true,"method"=>"get"]);
386
-		return $this->_add_event($element, $this->ajaxDeferred($parameters["method"],$url,$responseElement,$parameters), $event, $parameters["preventDefault"], $parameters["stopPropagation"],$parameters["immediatly"]);
385
+		$this->setDefaultParameters($parameters, ["preventDefault"=>true, "stopPropagation"=>true, "immediatly"=>true, "method"=>"get"]);
386
+		return $this->_add_event($element, $this->ajaxDeferred($parameters["method"], $url, $responseElement, $parameters), $event, $parameters["preventDefault"], $parameters["stopPropagation"], $parameters["immediatly"]);
387 387
 	}
388 388
 
389 389
 	/**
@@ -410,9 +410,9 @@  discard block
 block discarded – undo
410 410
 		return $this->getOn("click", $element, $url, $responseElement, $parameters);
411 411
 	}
412 412
 
413
-	private function _post($url, $params="{}",$responseElement="", $parameters=[]) {
413
+	private function _post($url, $params="{}", $responseElement="", $parameters=[]) {
414 414
 		$parameters["params"]=$params;
415
-		return $this->_ajax("POST", $url,$responseElement,$parameters);
415
+		return $this->_ajax("POST", $url, $responseElement, $parameters);
416 416
 	}
417 417
 
418 418
 	/**
@@ -422,8 +422,8 @@  discard block
 block discarded – undo
422 422
 	 * @param string $params JSON parameters
423 423
 	 * @param array $parameters default : array("jsCallback"=>NULL,"attr"=>"id","hasLoader"=>true,"immediatly"=>true,"jqueryDone"=>"html","ajaxTransition"=>null,"jsCondition"=>NULL,"headers"=>null)
424 424
 	 */
425
-	public function post($url, $params="{}",$responseElement="", $parameters=[]) {
426
-		return $this->_post($url, $params,$responseElement, $parameters);
425
+	public function post($url, $params="{}", $responseElement="", $parameters=[]) {
426
+		return $this->_post($url, $params, $responseElement, $parameters);
427 427
 	}
428 428
 
429 429
 	/**
@@ -434,7 +434,7 @@  discard block
 block discarded – undo
434 434
 	 * @param string $responseElement selector of the HTML element displaying the answer
435 435
 	 * @param array $parameters default : array("jsCallback"=>NULL,"attr"=>"id","hasLoader"=>true,"immediatly"=>true,"jqueryDone"=>"html","ajaxTransition"=>null,"jsCondition"=>NULL,"headers"=>null)
436 436
 	 */
437
-	public function postDeferred($url, $params="{}",$responseElement="", $parameters=[]) {
437
+	public function postDeferred($url, $params="{}", $responseElement="", $parameters=[]) {
438 438
 		$parameters["immediatly"]=false;
439 439
 		return $this->_post($url, $params, $responseElement, $parameters);
440 440
 	}
@@ -450,8 +450,8 @@  discard block
 block discarded – undo
450 450
 	 * @param array $parameters default : array("preventDefault"=>true,"stopPropagation"=>true,"jsCallback"=>NULL,"attr"=>"id","hasLoader"=>true,"immediatly"=>true,"jqueryDone"=>"html","ajaxTransition"=>null,"jsCondition"=>NULL,"headers"=>null)
451 451
 	 */
452 452
 	public function postOn($event, $element, $url, $params="{}", $responseElement="", $parameters=array()) {
453
-		$this->setDefaultParameters($parameters, ["preventDefault"=>true,"stopPropagation"=>true,"immediatly"=>true]);
454
-		return $this->_add_event($element, $this->postDeferred($url, $params, $responseElement, $parameters), $event, $parameters["preventDefault"], $parameters["stopPropagation"],$parameters["immediatly"]);
453
+		$this->setDefaultParameters($parameters, ["preventDefault"=>true, "stopPropagation"=>true, "immediatly"=>true]);
454
+		return $this->_add_event($element, $this->postDeferred($url, $params, $responseElement, $parameters), $event, $parameters["preventDefault"], $parameters["stopPropagation"], $parameters["immediatly"]);
455 455
 	}
456 456
 
457 457
 	/**
@@ -468,27 +468,27 @@  discard block
 block discarded – undo
468 468
 	}
469 469
 
470 470
 	private function _postForm($url, $form, $responseElement, $parameters=[]) {
471
-		$params="{}";$validation=false;$jsCallback=NULL;$attr="id";$hasLoader=true;$jqueryDone="html";$ajaxTransition=null;$immediatly=false;$jsCondition=NULL;$headers=NULL;$async=true;
471
+		$params="{}"; $validation=false; $jsCallback=NULL; $attr="id"; $hasLoader=true; $jqueryDone="html"; $ajaxTransition=null; $immediatly=false; $jsCondition=NULL; $headers=NULL; $async=true;
472 472
 		\extract($parameters);
473
-		$async=($async)?"true":"false";
473
+		$async=($async) ? "true" : "false";
474 474
 		$jsCallback=isset($jsCallback) ? $jsCallback : "";
475 475
 		$retour=$this->_getAjaxUrl($url, $attr);
476 476
 		$retour.="\nvar params=$('#".$form."').serialize();\n";
477
-		if(isset($params)){
477
+		if (isset($params)) {
478 478
 			$retour.="params+='&'+".self::_correctParams($params).";\n";
479 479
 		}
480 480
 		$responseElement=$this->_getResponseElement($responseElement);
481 481
 		$retour.="var self=this;\n";
482
-		if($hasLoader===true){
482
+		if ($hasLoader===true) {
483 483
 			$this->addLoading($retour, $responseElement);
484 484
 		}
485
-		$ajaxParameters=["url"=>"url","method"=>"'POST'","data"=>"params","async"=>$async];
486
-		if(isset($headers)){
485
+		$ajaxParameters=["url"=>"url", "method"=>"'POST'", "data"=>"params", "async"=>$async];
486
+		if (isset($headers)) {
487 487
 			$ajaxParameters["headers"]=$headers;
488 488
 		}
489 489
 		$this->createAjaxParameters($ajaxParameters, $parameters);
490 490
 		$retour.="$.ajax({".$this->implodeAjaxParameters($ajaxParameters)."}).done(function( data ) {\n";
491
-		$retour.=$this->_getOnAjaxDone($responseElement, $jqueryDone,$ajaxTransition,$jsCallback)."});\n";
491
+		$retour.=$this->_getOnAjaxDone($responseElement, $jqueryDone, $ajaxTransition, $jsCallback)."});\n";
492 492
 
493 493
 		if ($validation) {
494 494
 			$retour="$('#".$form."').validate({submitHandler: function(form) {
@@ -538,8 +538,8 @@  discard block
 block discarded – undo
538 538
 	 * @param array $parameters default : array("preventDefault"=>true,"stopPropagation"=>true,"validation"=>false,"params"=>"{}","jsCallback"=>NULL,"attr"=>"id","hasLoader"=>true,"immediatly"=>true,"jqueryDone"=>"html","ajaxTransition"=>null,"jsCondition"=>null,"headers"=>null)
539 539
 	 */
540 540
 	public function postFormOn($event, $element, $url, $form, $responseElement="", $parameters=array()) {
541
-		$this->setDefaultParameters($parameters, ["preventDefault"=>true,"stopPropagation"=>true,"immediatly"=>true]);
542
-		return $this->_add_event($element, $this->postFormDeferred($url, $form, $responseElement,$parameters), $event, $parameters["preventDefault"], $parameters["stopPropagation"],$parameters["immediatly"]);
541
+		$this->setDefaultParameters($parameters, ["preventDefault"=>true, "stopPropagation"=>true, "immediatly"=>true]);
542
+		return $this->_add_event($element, $this->postFormDeferred($url, $form, $responseElement, $parameters), $event, $parameters["preventDefault"], $parameters["stopPropagation"], $parameters["immediatly"]);
543 543
 	}
544 544
 
545 545
 	/**
Please login to merge, or discard this patch.
Ajax/service/AjaxCall.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -23,21 +23,21 @@  discard block
 block discarded – undo
23 23
 		$this->parameters["immediatly"]=false;
24 24
 		extract($this->parameters);
25 25
 		$result=$this->_eventPreparing($preventDefault, $stopPropagation);
26
-		switch($this->method) {
26
+		switch ($this->method) {
27 27
 			case "get":
28 28
 				$result.=$js->getDeferred($url, $responseElement, $this->parameters);
29 29
 				break;
30 30
 			case "post":
31
-				$result.=$js->postDeferred($url, $params,$responseElement, $this->parameters);
31
+				$result.=$js->postDeferred($url, $params, $responseElement, $this->parameters);
32 32
 				break;
33 33
 			case "postForm":
34 34
 				$result.=$js->postFormDeferred($url, $form, $responseElement, $this->parameters);
35 35
 				break;
36 36
 			case "json":
37
-				$result.=$js->jsonDeferred($url,$method,$this->parameters);
37
+				$result.=$js->jsonDeferred($url, $method, $this->parameters);
38 38
 				break;
39 39
 			case "jsonArray":
40
-				$result.=$js->jsonArrayDeferred($modelSelector, $url,$method,$this->parameters);
40
+				$result.=$js->jsonArrayDeferred($modelSelector, $url, $method, $this->parameters);
41 41
 				break;
42 42
 			default:
43 43
 				//$result.=$js->ajax($this->method, $url,$responseElement,$this->parameters);
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 		return $result;
47 47
 	}
48 48
 
49
-	protected function _eventPreparing($preventDefault,$stopPropagation){
49
+	protected function _eventPreparing($preventDefault, $stopPropagation) {
50 50
 		$result="";
51 51
 		if ($preventDefault===true) {
52 52
 			$result.=Javascript::$preventDefault;
Please login to merge, or discard this patch.
Ajax/php/symfony/JsUtils.php 1 patch
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -6,44 +6,44 @@  discard block
 block discarded – undo
6 6
 use Symfony\Component\HttpFoundation\Request;
7 7
 use Symfony\Component\HttpKernel\HttpKernelInterface;
8 8
 use Ajax\service\JString;
9
-class JsUtils extends \Ajax\JsUtils{
9
+class JsUtils extends \Ajax\JsUtils {
10 10
 
11
-	public function getUrl($url){
11
+	public function getUrl($url) {
12 12
 		$router=$this->getInjected();
13
-		if(isset($router)){
13
+		if (isset($router)) {
14 14
 			try {
15 15
 				$url=$router->generate($url);
16
-			}catch (\Exception $e){
16
+			}catch (\Exception $e) {
17 17
 				return $url;
18 18
 			}
19 19
 		}
20 20
 		return $url;
21 21
 	}
22
-	public function addViewElement($identifier,$content,&$view){
23
-		if(\is_array($view)){
24
-			if(\array_key_exists("q", $view)===false){
22
+	public function addViewElement($identifier, $content, &$view) {
23
+		if (\is_array($view)) {
24
+			if (\array_key_exists("q", $view)===false) {
25 25
 				$view["q"]=array();
26 26
 			}
27 27
 			$view["q"][$identifier]=$content;
28
-		}elseif($view instanceof \Twig_Environment){
28
+		}elseif ($view instanceof \Twig_Environment) {
29 29
 			$vars=$view->getGlobals();
30
-			if(\array_key_exists("q", $vars)===false){
30
+			if (\array_key_exists("q", $vars)===false) {
31 31
 				$vars["q"]=array();
32 32
 			}
33 33
 			$vars["q"][$identifier]=$content;
34
-			$view->addGlobal("q",$vars["q"]);
34
+			$view->addGlobal("q", $vars["q"]);
35 35
 		}
36 36
 	}
37 37
 
38
-	public function createScriptVariable(&$view,$view_var, $output){
38
+	public function createScriptVariable(&$view, $view_var, $output) {
39 39
 		$this->addVariable($view_var, $output, $view);
40 40
 	}
41 41
 
42
-	protected function addVariable($key,$value,&$view){
43
-		if(\is_array($view)){
42
+	protected function addVariable($key, $value, &$view) {
43
+		if (\is_array($view)) {
44 44
 			$view[$key]=$value;
45
-		}elseif($view instanceof \Twig_Environment){
46
-			$view->addGlobal($key,$value);
45
+		}elseif ($view instanceof \Twig_Environment) {
46
+			$view->addGlobal($key, $value);
47 47
 		}
48 48
 	}
49 49
 
@@ -54,17 +54,17 @@  discard block
 block discarded – undo
54 54
 	 * @param array $params
55 55
 	 * @see \Ajax\JsUtils::forward()
56 56
 	 */
57
-	public function forward($initialControllerInstance,$controllerName,$actionName,$params=array()){
57
+	public function forward($initialControllerInstance, $controllerName, $actionName, $params=array()) {
58 58
 		$path=$params;
59
-		$request = $initialControllerInstance->get('request_stack')->getCurrentRequest();
60
-		$path['_forwarded'] = $request->attributes;
61
-		$path['_controller'] = $controllerName.":".$actionName;
62
-		$subRequest = $request->duplicate([], null, $path);
63
-		$response= $initialControllerInstance->get('http_kernel')->handle($subRequest, HttpKernelInterface::SUB_REQUEST);
59
+		$request=$initialControllerInstance->get('request_stack')->getCurrentRequest();
60
+		$path['_forwarded']=$request->attributes;
61
+		$path['_controller']=$controllerName.":".$actionName;
62
+		$subRequest=$request->duplicate([], null, $path);
63
+		$response=$initialControllerInstance->get('http_kernel')->handle($subRequest, HttpKernelInterface::SUB_REQUEST);
64 64
 		return $response->getContent();
65 65
 	}
66 66
 
67
-	public function renderContent($initialControllerInstance,$viewName, $params=NULL) {
67
+	public function renderContent($initialControllerInstance, $viewName, $params=NULL) {
68 68
 		if ($initialControllerInstance->has('templating')) {
69 69
 			return $initialControllerInstance->get('templating')->render($viewName, $params);
70 70
 		}
@@ -76,10 +76,10 @@  discard block
 block discarded – undo
76 76
 		return $initialControllerInstance->get('twig')->render($viewName, $params);
77 77
 	}
78 78
 
79
-	public function fromDispatcher($dispatcher){
80
-		$request = $dispatcher->get('request_stack')->getCurrentRequest();
79
+	public function fromDispatcher($dispatcher) {
80
+		$request=$dispatcher->get('request_stack')->getCurrentRequest();
81 81
 		$uri=$request->getPathInfo();
82
-		if(JString::startswith($uri, "/")){
82
+		if (JString::startswith($uri, "/")) {
83 83
 			$uri=\substr($uri, 1);
84 84
 		}
85 85
 		return \explode("/", $uri);
Please login to merge, or discard this patch.
Ajax/php/ubiquity/JsUtils.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -4,34 +4,34 @@
 block discarded – undo
4 4
 
5 5
 use Ubiquity\controllers\Startup;
6 6
 use Ubiquity\utils\RequestUtils;
7
-class JsUtils extends \Ajax\JsUtils{
7
+class JsUtils extends \Ajax\JsUtils {
8 8
 
9
-	public function getUrl($url){
9
+	public function getUrl($url) {
10 10
 		return RequestUtils::getUrl($url);
11 11
 	}
12 12
 
13
-	public function addViewElement($identifier,$content,&$view){
13
+	public function addViewElement($identifier, $content, &$view) {
14 14
 		$controls=$view->getVar("q");
15
-		if (isset($controls) === false) {
16
-			$controls=array ();
15
+		if (isset($controls)===false) {
16
+			$controls=array();
17 17
 		}
18 18
 		$controls[$identifier]=$content;
19 19
 		$view->setVar("q", $controls);
20 20
 	}
21 21
 
22
-	public function createScriptVariable(&$view,$view_var, $output){
23
-		$view->setVar($view_var,$output);
22
+	public function createScriptVariable(&$view, $view_var, $output) {
23
+		$view->setVar($view_var, $output);
24 24
 	}
25 25
 
26
-	public function forward($initialController,$controller,$action,$params=array()){
27
-		return $initialController->forward($controller,$action,$params,true,true,true);
26
+	public function forward($initialController, $controller, $action, $params=array()) {
27
+		return $initialController->forward($controller, $action, $params, true, true, true);
28 28
 	}
29 29
 
30
-	public function renderContent($initialControllerInstance,$viewName, $params=NULL) {
31
-		return $initialControllerInstance->loadView($viewName,$params,true);
30
+	public function renderContent($initialControllerInstance, $viewName, $params=NULL) {
31
+		return $initialControllerInstance->loadView($viewName, $params, true);
32 32
 	}
33 33
 
34
-	public function fromDispatcher($dispatcher){
34
+	public function fromDispatcher($dispatcher) {
35 35
 		return Startup::$urlParts;
36 36
 	}
37 37
 }
Please login to merge, or discard this patch.
Ajax/common/html/BaseHtml.php 1 patch
Spacing   +42 added lines, -42 removed lines patch added patch discarded remove patch
@@ -14,11 +14,11 @@  discard block
 block discarded – undo
14 14
  * @version 1.3
15 15
  */
16 16
 abstract class BaseHtml extends BaseWidget {
17
-	use BaseHtmlEventsTrait,BaseHtmlPropertiesTrait;
17
+	use BaseHtmlEventsTrait, BaseHtmlPropertiesTrait;
18 18
 	protected $_template;
19 19
 	protected $tagName;
20
-	protected $_wrapBefore=array ();
21
-	protected $_wrapAfter=array ();
20
+	protected $_wrapBefore=array();
21
+	protected $_wrapAfter=array();
22 22
 	protected $_bsComponent;
23 23
 	protected $_compiled=false;
24 24
 	protected $_postCompile;
@@ -31,14 +31,14 @@  discard block
 block discarded – undo
31 31
 	 */
32 32
 	abstract public function run(JsUtils $js);
33 33
 
34
-	private function _callSetter($setter,$key,$value,&$array){
34
+	private function _callSetter($setter, $key, $value, &$array) {
35 35
 		$result=false;
36
-		if (method_exists($this, $setter) && substr($setter, 0, 1) !== "_") {
36
+		if (method_exists($this, $setter) && substr($setter, 0, 1)!=="_") {
37 37
 			try {
38 38
 				$this->$setter($value);
39 39
 				unset($array[$key]);
40 40
 				$result=true;
41
-			} catch ( \Exception $e ) {
41
+			}catch (\Exception $e) {
42 42
 				$result=false;
43 43
 			}
44 44
 		}
@@ -46,17 +46,17 @@  discard block
 block discarded – undo
46 46
 	}
47 47
 
48 48
 	protected function getTemplate(JsUtils $js=NULL) {
49
-		return PropertyWrapper::wrap($this->_wrapBefore, $js) . $this->_template . PropertyWrapper::wrap($this->_wrapAfter, $js);
49
+		return PropertyWrapper::wrap($this->_wrapBefore, $js).$this->_template.PropertyWrapper::wrap($this->_wrapAfter, $js);
50 50
 	}
51 51
 
52 52
 	protected function ctrl($name, $value, $typeCtrl) {
53 53
 		if (\is_array($typeCtrl)) {
54
-			if (array_search($value, $typeCtrl) === false) {
55
-				throw new \Exception("La valeur passée `" . $value . "` à la propriété `" . $name . "` ne fait pas partie des valeurs possibles : {" . implode(",", $typeCtrl) . "}");
54
+			if (array_search($value, $typeCtrl)===false) {
55
+				throw new \Exception("La valeur passée `".$value."` à la propriété `".$name."` ne fait pas partie des valeurs possibles : {".implode(",", $typeCtrl)."}");
56 56
 			}
57 57
 		} else {
58 58
 			if (!$typeCtrl($value)) {
59
-				throw new \Exception("La fonction " . $typeCtrl . " a retourné faux pour l'affectation de la propriété " . $name);
59
+				throw new \Exception("La fonction ".$typeCtrl." a retourné faux pour l'affectation de la propriété ".$name);
60 60
 			}
61 61
 		}
62 62
 		return true;
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
 
66 66
 
67 67
 	protected function setMemberCtrl(&$name, $value, $typeCtrl) {
68
-		if ($this->ctrl($name, $value, $typeCtrl) === true) {
68
+		if ($this->ctrl($name, $value, $typeCtrl)===true) {
69 69
 			return $name=$value;
70 70
 		}
71 71
 		return $this;
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 	protected function addToMemberUnique(&$name, $value, $typeCtrl, $separator=" ") {
75 75
 		if (\is_array($typeCtrl)) {
76 76
 			$this->removeOldValues($name, $typeCtrl);
77
-			$name.=$separator . $value;
77
+			$name.=$separator.$value;
78 78
 		}
79 79
 		return $this;
80 80
 	}
@@ -82,17 +82,17 @@  discard block
 block discarded – undo
82 82
 
83 83
 
84 84
 	protected function addToMemberCtrl(&$name, $value, $typeCtrl, $separator=" ") {
85
-		if ($this->ctrl($name, $value, $typeCtrl) === true) {
85
+		if ($this->ctrl($name, $value, $typeCtrl)===true) {
86 86
 			if (\is_array($typeCtrl)) {
87 87
 				$this->removeOldValues($name, $typeCtrl);
88 88
 			}
89
-			$name.=$separator . $value;
89
+			$name.=$separator.$value;
90 90
 		}
91 91
 		return $this;
92 92
 	}
93 93
 
94 94
 	protected function addToMember(&$name, $value, $separator=" ") {
95
-		$name=str_ireplace($value, "", $name) . $separator . $value;
95
+		$name=str_ireplace($value, "", $name).$separator.$value;
96 96
 		return $this;
97 97
 	}
98 98
 
@@ -103,18 +103,18 @@  discard block
 block discarded – undo
103 103
 		$oldValue=trim($oldValue);
104 104
 	}
105 105
 
106
-	protected function _getElementBy($callback,$elements){
106
+	protected function _getElementBy($callback, $elements) {
107 107
 		if (\is_array($elements)) {
108 108
 			$elements=\array_values($elements);
109 109
 			$flag=false;
110 110
 			$index=0;
111
-			while ( !$flag && $index < sizeof($elements) ) {
111
+			while (!$flag && $index<sizeof($elements)) {
112 112
 				if ($elements[$index] instanceof BaseHtml)
113 113
 					$flag=($callback($elements[$index]));
114 114
 					$index++;
115 115
 			}
116
-			if ($flag === true)
117
-				return $elements[$index - 1];
116
+			if ($flag===true)
117
+				return $elements[$index-1];
118 118
 		} elseif ($elements instanceof BaseHtml) {
119 119
 			if ($callback($elements))
120 120
 				return $elements;
@@ -142,13 +142,13 @@  discard block
 block discarded – undo
142 142
 	}
143 143
 
144 144
 	public function fromArray($array) {
145
-		foreach ( $this as $key => $value ) {
146
-			if(array_key_exists($key, $array)===true)
147
-				$this->_callSetter("set" . ucfirst($key), $key, $array[$key], $array);
145
+		foreach ($this as $key => $value) {
146
+			if (array_key_exists($key, $array)===true)
147
+				$this->_callSetter("set".ucfirst($key), $key, $array[$key], $array);
148 148
 		}
149
-		foreach ( $array as $key => $value ) {
150
-			if($this->_callSetter($key, $key, $value, $array)===false){
151
-				$this->_callSetter("set" . ucfirst($key), $key, $value, $array);
149
+		foreach ($array as $key => $value) {
150
+			if ($this->_callSetter($key, $key, $value, $array)===false) {
151
+				$this->_callSetter("set".ucfirst($key), $key, $value, $array);
152 152
 			}
153 153
 		}
154 154
 		return $array;
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
 
157 157
 	public function fromDatabaseObjects($objects, $function) {
158 158
 		if (isset($objects)) {
159
-			foreach ( $objects as $object ) {
159
+			foreach ($objects as $object) {
160 160
 				$this->fromDatabaseObject($object, $function);
161 161
 			}
162 162
 		}
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
 
178 178
 
179 179
 	public function getElementById($identifier, $elements) {
180
-		return $this->_getElementBy(function(BaseWidget $element) use ($identifier){return $element->getIdentifier()===$identifier;}, $elements);
180
+		return $this->_getElementBy(function(BaseWidget $element) use ($identifier){return $element->getIdentifier()===$identifier; }, $elements);
181 181
 	}
182 182
 
183 183
 	public function getBsComponent() {
@@ -190,14 +190,14 @@  discard block
 block discarded – undo
190 190
 	}
191 191
 
192 192
 	protected function compile_once(JsUtils $js=NULL, &$view=NULL) {
193
-		if(!$this->_compiled){
194
-			if(isset($js)){
193
+		if (!$this->_compiled) {
194
+			if (isset($js)) {
195 195
 				$beforeCompile=$js->getParam("beforeCompileHtml");
196
-				if(\is_callable($beforeCompile)){
197
-					$beforeCompile($this,$js,$view);
196
+				if (\is_callable($beforeCompile)) {
197
+					$beforeCompile($this, $js, $view);
198 198
 				}
199 199
 			}
200
-			if(\is_callable($this->_preCompile)){
200
+			if (\is_callable($this->_preCompile)) {
201 201
 				$pc=$this->_preCompile;
202 202
 				$pc($this);
203 203
 			}
@@ -207,15 +207,15 @@  discard block
 block discarded – undo
207 207
 	}
208 208
 
209 209
 	public function compile(JsUtils $js=NULL, &$view=NULL) {
210
-		$this->compile_once($js,$view);
210
+		$this->compile_once($js, $view);
211 211
 		$result=$this->getTemplate($js);
212
-		foreach ( $this as $key => $value ) {
213
-				if(\strstr($result, "%{$key}%")!==false){
212
+		foreach ($this as $key => $value) {
213
+				if (\strstr($result, "%{$key}%")!==false) {
214 214
 					if (\is_array($value)) {
215 215
 						$v=PropertyWrapper::wrap($value, $js);
216
-					}elseif($value instanceof \stdClass){
217
-							$v=\print_r($value,true);
218
-					}else{
216
+					}elseif ($value instanceof \stdClass) {
217
+							$v=\print_r($value, true);
218
+					} else {
219 219
 						$v=$value;
220 220
 					}
221 221
 					$result=str_replace("%{$key}%", $v, $result);
@@ -223,12 +223,12 @@  discard block
 block discarded – undo
223 223
 		}
224 224
 		if (isset($js)===true) {
225 225
 			$this->run($js);
226
-			if (isset($view) === true) {
226
+			if (isset($view)===true) {
227 227
 				$js->addViewElement($this->_identifier, $result, $view);
228 228
 			}
229 229
 		}
230 230
 
231
-		if(\is_callable($this->_postCompile)){
231
+		if (\is_callable($this->_postCompile)) {
232 232
 			$pc=$this->_postCompile;
233 233
 			$pc($this);
234 234
 		}
@@ -239,11 +239,11 @@  discard block
 block discarded – undo
239 239
 		return $this->compile();
240 240
 	}
241 241
 
242
-	public function onPostCompile($callback){
242
+	public function onPostCompile($callback) {
243 243
 		$this->_postCompile=$callback;
244 244
 	}
245 245
 
246
-	public function onPreCompile($callback){
246
+	public function onPreCompile($callback) {
247 247
 		$this->_preCompile=$callback;
248 248
 	}
249 249
 }
Please login to merge, or discard this patch.
Ajax/common/html/PropertyWrapper.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -12,8 +12,8 @@  discard block
 block discarded – undo
12 12
 		}
13 13
 		$output="";
14 14
 		if (\is_array($input)) {
15
-			if (sizeof($input) > 0) {
16
-				if (self::containsElement($input) === false) {
15
+			if (sizeof($input)>0) {
16
+				if (self::containsElement($input)===false) {
17 17
 					$output=self::wrapStrings($input, $separator=' ', $valueQuote='"');
18 18
 				} else {
19 19
 					$output=self::wrapObjects($input, $js, $separator, $valueQuote);
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
 	}
25 25
 
26 26
 	private static function containsElement($input) {
27
-		foreach ( $input as $v ) {
27
+		foreach ($input as $v) {
28 28
 			if (\is_object($v) || \is_array($v))
29 29
 				return true;
30 30
 		}
@@ -32,9 +32,9 @@  discard block
 block discarded – undo
32 32
 	}
33 33
 
34 34
 	public static function wrapStrings($input, $separator=' ', $valueQuote='"') {
35
-		if (JArray::isAssociative($input) === true) {
36
-			$result=implode($separator, array_map(function ($v, $k) use($valueQuote) {
37
-				return $k . '=' . $valueQuote . $v . $valueQuote;
35
+		if (JArray::isAssociative($input)===true) {
36
+			$result=implode($separator, array_map(function($v, $k) use($valueQuote) {
37
+				return $k.'='.$valueQuote.$v.$valueQuote;
38 38
 			}, $input, array_keys($input)));
39 39
 		} else {
40 40
 			$result=implode($separator, $input);
@@ -43,17 +43,17 @@  discard block
 block discarded – undo
43 43
 	}
44 44
 
45 45
 	public static function wrapObjects($input, $js=NULL, $separator=' ', $valueQuote='"') {
46
-		return implode($separator, array_map(function ($v) use($js, $separator, $valueQuote) {
47
-			if(\is_string($v)){
46
+		return implode($separator, array_map(function($v) use($js, $separator, $valueQuote) {
47
+			if (\is_string($v)) {
48 48
 				return $v;
49 49
 			}
50
-			if ($v instanceof BaseHtml){
50
+			if ($v instanceof BaseHtml) {
51 51
 				return $v->compile($js);
52 52
 			}
53 53
 			if (\is_array($v)) {
54 54
 				return self::wrap($v, $js, $separator, $valueQuote);
55 55
 			}
56
-			if(!\is_callable($v)){
56
+			if (!\is_callable($v)) {
57 57
 				return $v;
58 58
 			}
59 59
 		}, $input));
@@ -71,14 +71,14 @@  discard block
 block discarded – undo
71 71
 		return $result;*/
72 72
 	}
73 73
 
74
-	protected static function wrapValue($value,$js=NULL, $separator=' ', $valueQuote='"'){
74
+	protected static function wrapValue($value, $js=NULL, $separator=' ', $valueQuote='"') {
75 75
 		if (\is_array($value)) {
76 76
 			return self::wrap($value, $js, $separator, $valueQuote);
77 77
 		}
78
-		if ($value instanceof BaseHtml){
78
+		if ($value instanceof BaseHtml) {
79 79
 			return $value->compile($js);
80 80
 		}
81
-		if(!\is_callable($value)){
81
+		if (!\is_callable($value)) {
82 82
 			return $value;
83 83
 		}
84 84
 		return '';
Please login to merge, or discard this patch.