Ajax\semantic\components\Form

Complexity

Total Complexity

9

Size/Duplication

Total Lines	57
Duplicated Lines	12.28 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	addField()	0	3	1
A	setInline()	0	3	1
A	setOn()	0	3	1
A	addFieldRule()	0	6	2
A	addFieldValidation()	0	3	1
A	setJs()	0	3	1
A	getScript()	7	7	1

<?php
namespace Ajax\semantic\components;

use Ajax\common\components\SimpleExtComponent;
use Ajax\JsUtils;
use Ajax\semantic\components\validation\FieldValidation;
use Ajax\semantic\components\validation\Rule;
/**
 * @author jc
 * @version 1.001
 * Generates a JSON form validation string
 */
class Form extends SimpleExtComponent {

	/**
	 * @var array
	 */
	public function __construct(JsUtils $js=null) {
		parent::__construct($js);

It seems like $js defined by parameter $js on line 18 can be null; however, Ajax\common\components\SimpleComponent::__construct() does not accept null, maybe add an additional type check?

		$this->uiName="form";
		$this->params["fields"]=[];
	}

	public function addField($identifier){
		$this->params["fields"][$identifier]=new FieldValidation($identifier);
	}

	public function setInline($value){

The parameter $value is not used and could be removed.

		return $this->setParam("inline", true);
	}

	public function setOn($value){
		return $this->setParam("on", $value);
	}



	/**
	 * @param string $identifier
	 * @param Rule|string $type
	 * @param mixed $value
	 * @param string|NULL $prompt
	 */
	public function addFieldRule($identifier,$type,$prompt=NULL,$value=NULL){
		if(isset($this->params["fields"][$identifier])===false){
			$this->addField($identifier);
		}
		$this->params["fields"][$identifier]->addRule($type,$prompt,$value);
	}

	/**
	 * @param FieldValidation $fieldValidation
	 */
	public function addFieldValidation($fieldValidation){
		$this->params["fields"][$fieldValidation->getIdentifier()]=$fieldValidation;
	}

	public function setJs(JsUtils $js){
		$this->js=$js;
	}

	public function getScript() {

This method seems to be duplicated in your project.

		$allParams=$this->params;
		$this->jquery_code_for_compile=array ();
		$this->jquery_code_for_compile []="$( \"".$this->attachTo."\" ).{$this->uiName}(".$this->getParamsAsJSON($allParams).");";
		$this->compileEvents();
		return $this->compileJQueryCode();
	}
}