HtmlTableContent - Code Metrics - Inspection of "JsonDataTable widget added" - phpMv/phpMv-UI - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f99fed...57dceb )

by Jean-Christophe

created 2017-03-05 23:57 UTC

HtmlTableContent B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	304
Duplicated Lines	1.32 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
wmc	54
lcom	1
cbo	3
dl	4
loc	304
rs	7.0642
c	0
b	0
f	0

31 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	3
A	setRowCount()	0	7	2
A	getTdTagName()	0	3	1
A	createItem()	0	10	2
A	newRow()	0	3	1
A	addRow()	0	3	1
A	_addRow()	0	3	1
A	getCell()	0	7	2
A	getRow()	0	3	1
A	setCellValue()	0	7	2
A	setValues()	0	3	1
A	addValues()	0	3	1
B	_addOrSetValues()	4	18	5
A	setColValues()	0	11	3
A	addColVariations()	0	7	2
A	setRowValues()	0	8	2
A	colAlign()	0	9	3
A	colCenter()	0	3	1
A	colRight()	0	3	1
A	colLeft()	0	3	1
A	getRowCount()	0	3	1
A	getColCount()	0	6	2
A	delete()	0	11	3
A	mergeCol()	0	3	1
A	mergeRow()	0	3	1
A	setFullWidth()	0	3	1
A	sort()	0	3	1
A	conditionalCellFormat()	0	7	2
A	conditionalRowFormat()	0	7	2
A	applyCells()	0	7	2
A	applyRows()	0	7	2

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like HtmlTableContent often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use HtmlTableContent, and based on these observations, apply Extract Interface, too.

<?php

namespace Ajax\semantic\html\content\table;

use Ajax\semantic\html\base\HtmlSemCollection;
use Ajax\service\JArray;

/**
 * a table content (thead, tbody or tfoot)
 * @author jc
 *
 */
class HtmlTableContent extends HtmlSemCollection {
	protected $_tdTagNames=[ "thead" => "th","tbody" => "td","tfoot" => "th" ];

	/**
	 *
	 * @param string $identifier
	 * @param string $tagName
	 * @param int $rowCount
	 * @param int $colCount
	 */
	public function __construct($identifier, $tagName="tbody", $rowCount=NULL, $colCount=NULL) {
		parent::__construct($identifier, $tagName, "");
		if (isset($rowCount) && isset($colCount))
			$this->setRowCount($rowCount, $colCount);
	}

	/**
	 *
	 * @param int $rowCount
	 * @param int $colCount
	 * @return \Ajax\semantic\html\content\table\HtmlTableContent
	 */
	public function setRowCount($rowCount, $colCount) {
		$count=$this->count();
		for($i=$count; $i < $rowCount; $i++) {
			$this->addItem($colCount);
		}
		return $this;
	}

	public function getTdTagName($tagName) {

		return $this->_tdTagNames[$this->tagName];
	}

	/**
	 *
	 * {@inheritDoc}
	 *
	 * @see \Ajax\common\html\HtmlCollection::createItem()
	 * @return HtmlTR
	 */
	protected function createItem($value) {
		$count=$this->count();
		$tr=new HtmlTR("", $value);

		$tr->setContainer($this, $count);
		$tr->setTdTagName($this->_tdTagNames[$this->tagName]);
		if (isset($value) === true) {
			$tr->setColCount($value);
		}
		return $tr;
	}

	public function newRow($value) {
		return $this->createItem($value);
	}

	/**
	 * @param int $colCount
	 * @return HtmlTR
	 */
	public function addRow($colCount) {
		return $this->addItem($colCount);
	}

	/**
	 * @param mixed $row
	 * @return HtmlTR
	 */
	public function _addRow($row) {
		return $this->addItem($row);
	}

	/**
	 * Returns the cell (HtmlTD) at position $row,$col
	 * @param int $row
	 * @param int $col
	 * @return \Ajax\semantic\html\content\HtmlTD
	 */
	public function getCell($row, $col) {
		$row=$this->getItem($row);
		if (isset($row)) {
			$col=$row->getItem($col);
		}
		return $col;
	}

	/**
	 *
	 * @param int $index
	 * @return \Ajax\semantic\html\content\HtmlTR
	 */
	public function getRow($index) {
		return $this->getItem($index);
	}

	/**
	 *
	 * @param int $row
	 * @param int $col
	 * @param mixed $value
	 * @return \Ajax\semantic\html\content\table\HtmlTableContent
	 */
	public function setCellValue($row, $col, $value="") {
		$cell=$this->getCell($row, $col);
		if (isset($cell) === true) {
			$cell->setValue($value);
		}
		return $this;
	}

	/**
	 * Sets the cells values
	 * @param mixed $values
	 */
	public function setValues($values=array()) {
		return $this->_addOrSetValues($values, function($row,$_values){$row->setValues($_values);});
	}

	/**
	 * Adds the cells values
	 * @param mixed $values
	 */
	public function addValues($values=array()) {
		return $this->_addOrSetValues($values, function($row,$_values){$row->addValues($_values);});
	}

	/**
	 * Adds or sets the cells values
	 * @param mixed $values
	 * @param callable $callback
	 */
	protected function _addOrSetValues($values,$callback) {
		$count=$this->count();
		$isArray=true;
		if (!\is_array($values)) {
			$values=\array_fill(0, $count, $values);
			$isArray=false;
		}
		if (JArray::dimension($values) == 1 && $isArray)
			$values=[ $values ];

		$count=\min(\sizeof($values), $count);

		for($i=0; $i < $count; $i++) {

			$row=$this->content[$i];
			$callback($row,$values[$i]);
		}
		return $this;
	}

	public function setColValues($colIndex, $values=array()) {
		$count=$this->count();
		if (!\is_array($values)) {
			$values=\array_fill(0, $count, $values);
		}
		$count=\min(\sizeof($values), $count);
		for($i=0; $i < $count; $i++) {
			$this->getCell($i, $colIndex)->setValue($values[$i]);
		}
		return $this;
	}

	public function addColVariations($colIndex, $variations=array()) {
		$count=$this->count();
		for($i=0; $i < $count; $i++) {
			$this->getCell($i, $colIndex)->addVariations($variations);
		}
		return $this;
	}

	public function setRowValues($rowIndex, $values=array()) {
		$count=$this->count();
		if (!\is_array($values)) {
			$values=\array_fill(0, $count, $values);
		}
		$this->getItem($rowIndex)->setValues($values);
		return $this;
	}

	private function colAlign($colIndex, $function) {
		$count=$this->count();
		for($i=0; $i < $count; $i++) {
			$index=$this->content[$i]->getColPosition($colIndex);
			if ($index !== NULL)
				$this->getCell($i, $index)->$function();
		}
		return $this;
	}

	public function colCenter($colIndex) {
		return $this->colAlign($colIndex, "textCenterAligned");
	}

	public function colRight($colIndex) {
		return $this->colAlign($colIndex, "textRightAligned");
	}

	public function colLeft($colIndex) {
		return $this->colAlign($colIndex, "textLeftAligned");
	}

	/**
	 * Returns the number of rows (TR)
	 * @return int
	 */
	public function getRowCount() {
		return $this->count();
	}

	/**
	 * Returns the number of columns (TD)
	 * @return int
	 */
	public function getColCount() {
		$result=0;
		if ($this->count() > 0)
			$result=$this->getItem(0)->getColCount();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
		return $result;
	}

	/**
	 * Removes the cell at position $rowIndex,$colIndex
	 * @param int $rowIndex
	 * @param int $colIndex
	 * @return \Ajax\semantic\html\content\table\HtmlTableContent
	 */
	public function delete($rowIndex, $colIndex=NULL) {
		if (isset($colIndex)) {
			$row=$this->getItem($rowIndex);
			if (isset($row) === true) {
				$row->delete($colIndex);
			}
		} else {
			$this->removeItem($rowIndex);
		}
		return $this;
	}

	public function mergeCol($rowIndex=0, $colIndex=0) {
		return $this->getItem($rowIndex)->mergeCol($colIndex);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
	}

	public function mergeRow($rowIndex=0, $colIndex=0) {
		return $this->getItem($rowIndex)->mergeRow($colIndex);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
	}

	public function setFullWidth() {
		return $this->addToProperty("class", "full-width");
	}

	public function sort($colIndex) {
		$this->content[0]->getItem($colIndex)->addToProperty("class", "sorted ascending");
	}

	/**
	 * @param mixed $callback
	 * @param string $format
	 * @return \Ajax\semantic\html\content\table\HtmlTableContent
	 */
	public function conditionalCellFormat($callback, $format) {
		$rows=$this->content;
		foreach ( $rows as $row ) {
			$row->conditionalCellFormat($callback, $format);
		}
		return $this;
	}

	/**
	 * @param mixed $callback
	 * @param string $format
	 * @return \Ajax\semantic\html\content\table\HtmlTableContent
	 */
	public function conditionalRowFormat($callback, $format) {
		$rows=$this->content;
		foreach ( $rows as $row ) {
			$row->conditionalRowFormat($callback, $format);
		}
		return $this;
	}

	/**
	 * @param mixed $callback
	 * @return \Ajax\semantic\html\content\table\HtmlTableContent
	 */
	public function applyCells($callback) {
		$rows=$this->content;
		foreach ( $rows as $row ) {
			$row->applyCells($callback);
		}
		return $this;
	}

	/**
	 * @param mixed $callback
	 * @return \Ajax\semantic\html\content\table\HtmlTableContent
	 */
	public function applyRows($callback) {
		$rows=$this->content;
		foreach ( $rows as $row ) {
			$row->apply($callback);
		}
		return $this;
	}
}

Push — master ( f99fed...57dceb )

HtmlTableContent B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

31 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace Ajax\semantic\html\content\table;
4
5		use Ajax\semantic\html\base\HtmlSemCollection;
6		use Ajax\service\JArray;
7
8		/**
9		* a table content (thead, tbody or tfoot)
10		* @author jc
11		*
12		*/
13		class HtmlTableContent extends HtmlSemCollection {
14		protected $_tdTagNames=[ "thead" => "th","tbody" => "td","tfoot" => "th" ];
15
16		/**
17		*
18		* @param string $identifier
19		* @param string $tagName
20		* @param int $rowCount
21		* @param int $colCount
22		*/
23		public function __construct($identifier, $tagName="tbody", $rowCount=NULL, $colCount=NULL) {
24		parent::__construct($identifier, $tagName, "");
25		if (isset($rowCount) && isset($colCount))
26		$this->setRowCount($rowCount, $colCount);
27		}
28
29		/**
30		*
31		* @param int $rowCount
32		* @param int $colCount
33		* @return \Ajax\semantic\html\content\table\HtmlTableContent
34		*/
35		public function setRowCount($rowCount, $colCount) {
36		$count=$this->count();
37		for($i=$count; $i < $rowCount; $i++) {
38		$this->addItem($colCount);
39		}
40		return $this;
41		}
42
43		public function getTdTagName($tagName) {
		0 ignored issues – show Unused Code introduced 2016-06-16 17:04 UTC by Report Bug Copy Issue Report The parameter `$tagName` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
44		return $this->_tdTagNames[$this->tagName];
45		}
46
47		/**
48		*
49		* {@inheritDoc}
50		*
51		* @see \Ajax\common\html\HtmlCollection::createItem()
52		* @return HtmlTR
53		*/
54		protected function createItem($value) {
55		$count=$this->count();
56		$tr=new HtmlTR("", $value);
		0 ignored issues – show Unused Code introduced 2016-06-16 17:04 UTC by Report Bug Copy Issue Report The call to `HtmlTR::__construct()` has too many arguments starting with `$value`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
57		$tr->setContainer($this, $count);
58		$tr->setTdTagName($this->_tdTagNames[$this->tagName]);
59		if (isset($value) === true) {
60		$tr->setColCount($value);
61		}
62		return $tr;
63		}
64
65		public function newRow($value) {
66		return $this->createItem($value);
67		}
68
69		/**
70		* @param int $colCount
71		* @return HtmlTR
72		*/
73		public function addRow($colCount) {
74		return $this->addItem($colCount);
75		}
76
77		/**
78		* @param mixed $row
79		* @return HtmlTR
80		*/
81		public function _addRow($row) {
82		return $this->addItem($row);
83		}
84
85		/**
86		* Returns the cell (HtmlTD) at position $row,$col
87		* @param int $row
88		* @param int $col
89		* @return \Ajax\semantic\html\content\HtmlTD
90		*/
91		public function getCell($row, $col) {
92		$row=$this->getItem($row);
93		if (isset($row)) {
94		$col=$row->getItem($col);
95		}
96		return $col;
97		}
98
99		/**
100		*
101		* @param int $index
102		* @return \Ajax\semantic\html\content\HtmlTR
103		*/
104		public function getRow($index) {
105		return $this->getItem($index);
106		}
107
108		/**
109		*
110		* @param int $row
111		* @param int $col
112		* @param mixed $value
113		* @return \Ajax\semantic\html\content\table\HtmlTableContent
114		*/
115		public function setCellValue($row, $col, $value="") {
116		$cell=$this->getCell($row, $col);
117		if (isset($cell) === true) {
118		$cell->setValue($value);
119		}
120		return $this;
121		}
122
123		/**
124		* Sets the cells values
125		* @param mixed $values
126		*/
127		public function setValues($values=array()) {
128		return $this->_addOrSetValues($values, function($row,$_values){$row->setValues($_values);});
129		}
130
131		/**
132		* Adds the cells values
133		* @param mixed $values
134		*/
135		public function addValues($values=array()) {
136		return $this->_addOrSetValues($values, function($row,$_values){$row->addValues($_values);});
137		}
138
139		/**
140		* Adds or sets the cells values
141		* @param mixed $values
142		* @param callable $callback
143		*/
144		protected function _addOrSetValues($values,$callback) {
145		$count=$this->count();
146		$isArray=true;
147		if (!\is_array($values)) {
148		$values=\array_fill(0, $count, $values);
149		$isArray=false;
150		}
151		if (JArray::dimension($values) == 1 && $isArray)
152		$values=[ $values ];
153
154		$count=\min(\sizeof($values), $count);
155
156	View Code Duplication	for($i=0; $i < $count; $i++) {
		1 ignored issue – show Duplication introduced 2017-03-06 00:01 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
157		$row=$this->content[$i];
158		$callback($row,$values[$i]);
159		}
160		return $this;
161		}
162
163		public function setColValues($colIndex, $values=array()) {
164		$count=$this->count();
165		if (!\is_array($values)) {
166		$values=\array_fill(0, $count, $values);
167		}
168		$count=\min(\sizeof($values), $count);
169		for($i=0; $i < $count; $i++) {
170		$this->getCell($i, $colIndex)->setValue($values[$i]);
171		}
172		return $this;
173		}
174
175		public function addColVariations($colIndex, $variations=array()) {
176		$count=$this->count();
177		for($i=0; $i < $count; $i++) {
178		$this->getCell($i, $colIndex)->addVariations($variations);
179		}
180		return $this;
181		}
182
183		public function setRowValues($rowIndex, $values=array()) {
184		$count=$this->count();
185		if (!\is_array($values)) {
186		$values=\array_fill(0, $count, $values);
187		}
188		$this->getItem($rowIndex)->setValues($values);
189		return $this;
190		}
191
192		private function colAlign($colIndex, $function) {
193		$count=$this->count();
194		for($i=0; $i < $count; $i++) {
195		$index=$this->content[$i]->getColPosition($colIndex);
196		if ($index !== NULL)
197		$this->getCell($i, $index)->$function();
198		}
199		return $this;
200		}
201
202		public function colCenter($colIndex) {
203		return $this->colAlign($colIndex, "textCenterAligned");
204		}
205
206		public function colRight($colIndex) {
207		return $this->colAlign($colIndex, "textRightAligned");
208		}
209
210		public function colLeft($colIndex) {
211		return $this->colAlign($colIndex, "textLeftAligned");
212		}
213
214		/**
215		* Returns the number of rows (TR)
216		* @return int
217		*/
218		public function getRowCount() {
219		return $this->count();
220		}
221
222		/**
223		* Returns the number of columns (TD)
224		* @return int
225		*/
226		public function getColCount() {
227		$result=0;
228		if ($this->count() > 0)
229		$result=$this->getItem(0)->getColCount();
		0 ignored issues – show Bug introduced 2016-06-16 17:04 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Ajax\common\html\HtmlDoubleElement` as the method `getColCount()` does only exist in the following sub-classes of `Ajax\common\html\HtmlDoubleElement`: `Ajax\semantic\html\content\table\HtmlTableContent`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
230		return $result;
231		}
232
233		/**
234		* Removes the cell at position $rowIndex,$colIndex
235		* @param int $rowIndex
236		* @param int $colIndex
237		* @return \Ajax\semantic\html\content\table\HtmlTableContent
238		*/
239		public function delete($rowIndex, $colIndex=NULL) {
240		if (isset($colIndex)) {
241		$row=$this->getItem($rowIndex);
242		if (isset($row) === true) {
243		$row->delete($colIndex);
244		}
245		} else {
246		$this->removeItem($rowIndex);
247		}
248		return $this;
249		}
250
251		public function mergeCol($rowIndex=0, $colIndex=0) {
252		return $this->getItem($rowIndex)->mergeCol($colIndex);
		0 ignored issues – show Bug introduced 2016-06-16 17:04 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Ajax\common\html\HtmlDoubleElement` as the method `mergeCol()` does only exist in the following sub-classes of `Ajax\common\html\HtmlDoubleElement`: `Ajax\semantic\html\content\table\HtmlTD`, `Ajax\semantic\html\content\table\HtmlTR`, `Ajax\semantic\html\content\table\HtmlTableContent`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
253		}
254
255		public function mergeRow($rowIndex=0, $colIndex=0) {
256		return $this->getItem($rowIndex)->mergeRow($colIndex);
		0 ignored issues – show Bug introduced 2016-06-16 17:04 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Ajax\common\html\HtmlDoubleElement` as the method `mergeRow()` does only exist in the following sub-classes of `Ajax\common\html\HtmlDoubleElement`: `Ajax\semantic\html\content\table\HtmlTD`, `Ajax\semantic\html\content\table\HtmlTR`, `Ajax\semantic\html\content\table\HtmlTableContent`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
257		}
258
259		public function setFullWidth() {
260		return $this->addToProperty("class", "full-width");
261		}
262
263		public function sort($colIndex) {
264		$this->content[0]->getItem($colIndex)->addToProperty("class", "sorted ascending");
265		}
266
267		/**
268		* @param mixed $callback
269		* @param string $format
270		* @return \Ajax\semantic\html\content\table\HtmlTableContent
271		*/
272		public function conditionalCellFormat($callback, $format) {
273		$rows=$this->content;
274		foreach ( $rows as $row ) {
275		$row->conditionalCellFormat($callback, $format);
276		}
277		return $this;
278		}
279
280		/**
281		* @param mixed $callback
282		* @param string $format
283		* @return \Ajax\semantic\html\content\table\HtmlTableContent
284		*/
285		public function conditionalRowFormat($callback, $format) {
286		$rows=$this->content;
287		foreach ( $rows as $row ) {
288		$row->conditionalRowFormat($callback, $format);
289		}
290		return $this;
291		}
292
293		/**
294		* @param mixed $callback
295		* @return \Ajax\semantic\html\content\table\HtmlTableContent
296		*/
297		public function applyCells($callback) {
298		$rows=$this->content;
299		foreach ( $rows as $row ) {
300		$row->applyCells($callback);
301		}
302		return $this;
303		}
304
305		/**
306		* @param mixed $callback
307		* @return \Ajax\semantic\html\content\table\HtmlTableContent
308		*/
309		public function applyRows($callback) {
310		$rows=$this->content;
311		foreach ( $rows as $row ) {
312		$row->apply($callback);
313		}
314		return $this;
315		}
316		}

phpMv / phpMv-UI

Push — master ( f99fed...57dceb )

HtmlTableContent B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

31 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like