Ajax\semantic\widgets\dataform\FormInstanceViewer

Complexity

Total Complexity

13

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	2
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	1
A	_beforeAddProperty()	0	9	4
A	addSeparatorAfter()	0	5	2
A	getSeparators()	0	3	1
A	removeSeparator()	0	3	1
A	removeField()	0	11	3
A	setSeparators()	0	4	1

<?php

namespace Ajax\semantic\widgets\dataform;

use Ajax\semantic\widgets\base\InstanceViewer;
use Ajax\service\JString;
use Ajax\semantic\html\collections\form\HtmlFormInput;

class FormInstanceViewer extends InstanceViewer {
	protected $separators;

	public function __construct($identifier,$instance=NULL, $captions=NULL) {
		parent::__construct($identifier,$instance=NULL, $captions=NULL);
		$this->separators=[-1];
		$this->defaultValueFunction=function($name,$value,$index){
			$caption=$this->getCaption($index);
			$input=new HtmlFormInput($this->widgetIdentifier."-".$name,$caption,"text",$value);
			$input->setName($name);
			return $input;
		};
	}

	protected function _beforeAddProperty($index,&$field){
		if(JString::endswith($field, "\n")===true){
			$this->addSeparatorAfter($index);
		}
		if($index>1 && JString::startswith($field, "\n")===true){
			$this->addSeparatorAfter($index-1);
		}
		$field=\str_replace("\n", "", $field);
	}



	public function addSeparatorAfter($fieldNum){
		if(\array_search($fieldNum, $this->separators)===false)
			$this->separators[]=$fieldNum;
		return $this;
	}

	public function getSeparators() {
		return $this->separators;
	}

	public function removeSeparator($index){
		\array_splice($this->separators,$index,1);
	}

	public function removeField($index){
		parent::removeField($index);
		$pos=\array_search($index, $this->separators);
		if($pos!==false){
			for($i=$pos+1;$i<\sizeof($this->separators);$i++){

It seems like you are calling the size function sizeof() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

				$this->separators[$i]--;
			}
			\array_splice($this->separators, $pos, 1);
		}
		return $this;
	}

	public function setSeparators($separators) {
		$this->separators=\array_merge([-1], $separators);
		return $this;
	}

}