HtmlTab - Code Metrics - Inspection of "tab activation" - phpMv/phpMv-UI - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c8eebb...4924e4 )

by Jean-Christophe

created 2016-12-01 06:42 UTC

HtmlTab A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	77
Duplicated Lines	2.6 %

Coupling/Cohesion

Components	2
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	11
lcom	2
cbo	4
dl	2
loc	77
rs	10
c	1
b	0
f	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	createItem()	0	14	2
A	activate()	0	5	1
A	addPanel()	0	3	1
A	forwardPanel()	0	3	1
A	renderViewPanel()	0	3	1
A	run()	2	6	2
A	compile()	0	5	2

How to fix Duplicated Code

<?php
namespace Ajax\semantic\html\modules;

use Ajax\semantic\html\base\HtmlSemCollection;
use Ajax\semantic\html\elements\HtmlSegment;
use Ajax\semantic\html\collections\menus\HtmlMenu;
use Ajax\semantic\html\base\constants\Side;
use Ajax\JsUtils;

class HtmlTab extends HtmlSemCollection{
	protected $params=array("debug"=>true);

	public function __construct( $identifier, $tabs=array()){
		parent::__construct( $identifier, "div", "");
		$menu=new HtmlMenu("menu".$this->identifier);
		$menu->asTab(false)->setAttachment(NULL,Side::TOP);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$this->content["menu"]=$menu;
		$this->addItems($tabs);
	}

	protected function createItem($value){
		$count=$this->count();
		$title=$value;
		$content=NULL;
		if(\is_array($value)){
			$title=@$value[0];$content=@$value[1];
		}
		$menuItem=$this->content["menu"]->addItem($title);
		$menuItem->addToProperty("data-tab", $menuItem->getIdentifier());
		$menuItem->removeProperty("href");
		$segment=new HtmlSegment("item-".$this->identifier."-".$count, $content);
		$segment->setAttachment(NULL,Side::BOTTOM)->addToProperty("class", "tab")->addToProperty("data-tab",$menuItem->getIdentifier());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		return $segment;
	}

	public function activate($index){
		$this->content["menu"]->getItem($index)->setActive(true);
		$this->content[$index]->setActive(true);
		return $this;
	}

	public function addPanel($title,$content){
		return $this->addItem([$title,$content]);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
	}

	/**
	 * render the content of $controller::$action and set the response to a new panel
	 * @param JsUtils $js
	 * @param string $title The panel title
	 * @param Controller $initialController
	 * @param string $controller a Phalcon controller
	 * @param string $action a Phalcon action
	 * @param array $params
	 */
	public function forwardPanel(JsUtils $js,$title,$initialController,$controller,$action,$params=array()){
		return $this->addPanel($title, $js->forward($initialController, $controller, $action,$params));
	}

	/**
	 * render the content of an existing view : $controller/$action and set the response to a new panel
	 * @param JsUtils $js
	 * @param string $title The panel title
	 * @param Controller $initialController
	 * @param string $viewName
	 * @param $params The parameters to pass to the view
	 */
	public function renderViewPanel(JsUtils $js,$title,$initialController, $viewName, $params=array()) {
		return $this->addPanel($title, $js->renderContent($initialController, $viewName,$params));
	}

	/*
	 * (non-PHPdoc)
	 * @see BaseHtml::run()
	 */
	public function run(JsUtils $js) {
		if(isset($this->_bsComponent)===false)

			$this->_bsComponent=$js->semantic()->tab("#".$this->identifier." .item",$this->params);
			$this->addEventsOnRun($js);
			return $this->_bsComponent;
	}
	public function compile(JsUtils $js=NULL, &$view=NULL) {
		if($this->content["menu"]->count()>0)
			$this->activate(0);
		return parent::compile($js,$view);
	}
}

1		<?php
2		namespace Ajax\semantic\html\modules;
3
4		use Ajax\semantic\html\base\HtmlSemCollection;
5		use Ajax\semantic\html\elements\HtmlSegment;
6		use Ajax\semantic\html\collections\menus\HtmlMenu;
7		use Ajax\semantic\html\base\constants\Side;
8		use Ajax\JsUtils;
9
10		class HtmlTab extends HtmlSemCollection{
11		protected $params=array("debug"=>true);
12
13		public function __construct( $identifier, $tabs=array()){
14		parent::__construct( $identifier, "div", "");
15		$menu=new HtmlMenu("menu".$this->identifier);
16		$menu->asTab(false)->setAttachment(NULL,Side::TOP);
		0 ignored issues – show Documentation introduced 2016-11-30 01:44 UTC by Report Bug Copy Issue Report `NULL` is of type `null`, but the function expects a `object<Ajax\semantic\htm...e\HtmlSemDoubleElement>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
17		$this->content["menu"]=$menu;
18		$this->addItems($tabs);
19		}
20
21		protected function createItem($value){
22		$count=$this->count();
23		$title=$value;
24		$content=NULL;
25		if(\is_array($value)){
26		$title=@$value[0];$content=@$value[1];
27		}
28		$menuItem=$this->content["menu"]->addItem($title);
29		$menuItem->addToProperty("data-tab", $menuItem->getIdentifier());
30		$menuItem->removeProperty("href");
31		$segment=new HtmlSegment("item-".$this->identifier."-".$count, $content);
32		$segment->setAttachment(NULL,Side::BOTTOM)->addToProperty("class", "tab")->addToProperty("data-tab",$menuItem->getIdentifier());
		0 ignored issues – show Documentation introduced 2016-11-30 01:44 UTC by Report Bug Copy Issue Report `NULL` is of type `null`, but the function expects a `object<Ajax\semantic\htm...e\HtmlSemDoubleElement>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33		return $segment;
34		}
35
36		public function activate($index){
37		$this->content["menu"]->getItem($index)->setActive(true);
38		$this->content[$index]->setActive(true);
39		return $this;
40		}
41
42		public function addPanel($title,$content){
43		return $this->addItem([$title,$content]);
		0 ignored issues – show Documentation introduced 2016-11-30 01:44 UTC by Report Bug Copy Issue Report `array($title, $content)` is of type `array<integer,?,{"0":"?","1":"?"}>`, but the function expects a `object<Ajax\common\html\HtmlDoubleElement>\|string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
44		}
45
46		/**
47		* render the content of $controller::$action and set the response to a new panel
48		* @param JsUtils $js
49		* @param string $title The panel title
50		* @param Controller $initialController
51		* @param string $controller a Phalcon controller
52		* @param string $action a Phalcon action
53		* @param array $params
54		*/
55		public function forwardPanel(JsUtils $js,$title,$initialController,$controller,$action,$params=array()){
56		return $this->addPanel($title, $js->forward($initialController, $controller, $action,$params));
57		}
58
59		/**
60		* render the content of an existing view : $controller/$action and set the response to a new panel
61		* @param JsUtils $js
62		* @param string $title The panel title
63		* @param Controller $initialController
64		* @param string $viewName
65		* @param $params The parameters to pass to the view
66		*/
67		public function renderViewPanel(JsUtils $js,$title,$initialController, $viewName, $params=array()) {
68		return $this->addPanel($title, $js->renderContent($initialController, $viewName,$params));
69		}
70
71		/*
72		* (non-PHPdoc)
73		* @see BaseHtml::run()
74		*/
75		public function run(JsUtils $js) {
76	View Code Duplication	if(isset($this->_bsComponent)===false)
		0 ignored issues – show Duplication introduced 2016-11-30 01:44 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
77		$this->_bsComponent=$js->semantic()->tab("#".$this->identifier." .item",$this->params);
78		$this->addEventsOnRun($js);
79		return $this->_bsComponent;
80		}
81		public function compile(JsUtils $js=NULL, &$view=NULL) {
82		if($this->content["menu"]->count()>0)
83		$this->activate(0);
84		return parent::compile($js,$view);
85		}
86		}

phpMv / phpMv-UI

Push — master ( c8eebb...4924e4 )

HtmlTab A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like