Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 15 | abstract class Widget extends HtmlDoubleElement { |
||
| 16 | use FieldAsTrait; |
||
| 17 | |||
| 18 | /** |
||
| 19 | * @var string classname |
||
| 20 | */ |
||
| 21 | protected $_model; |
||
| 22 | protected $_modelInstance; |
||
| 23 | /** |
||
| 24 | * @var InstanceViewer |
||
| 25 | */ |
||
| 26 | protected $_instanceViewer; |
||
| 27 | /** |
||
| 28 | * @var boolean |
||
| 29 | */ |
||
| 30 | protected $_toolbar; |
||
| 31 | /** |
||
| 32 | * @var PositionInTable |
||
| 33 | */ |
||
| 34 | protected $_toolbarPosition; |
||
| 35 | |||
| 36 | |||
| 37 | public function __construct($identifier,$model,$modelInstance=NULL) { |
||
| 44 | |||
| 45 | protected function _getFieldIdentifier($prefix){ |
||
| 48 | |||
| 49 | abstract protected function _setToolbarPosition($table,$captions=NULL); |
||
| 50 | |||
| 51 | public function show($modelInstance){ |
||
| 54 | |||
| 55 | public function getModel() { |
||
| 58 | |||
| 59 | public function setModel($_model) { |
||
| 63 | |||
| 64 | public function getInstanceViewer() { |
||
| 67 | |||
| 68 | public function setInstanceViewer($_instanceViewer) { |
||
| 72 | |||
| 73 | public abstract function getHtmlComponent(); |
||
| 74 | |||
| 75 | public function setColor($color){ |
||
| 78 | |||
| 79 | |||
| 80 | public function setCaptions($captions){ |
||
| 84 | |||
| 85 | public function setFields($fields){ |
||
| 89 | |||
| 90 | public function addField($field){ |
||
| 94 | |||
| 95 | public function insertField($index,$field){ |
||
| 99 | |||
| 100 | public function insertInField($index,$field){ |
||
| 104 | |||
| 105 | public function setValueFunction($index,$callback){ |
||
| 109 | |||
| 110 | public function setIdentifierFunction($callback){ |
||
| 114 | |||
| 115 | /** |
||
| 116 | * @return \Ajax\semantic\html\collections\menus\HtmlMenu |
||
| 117 | */ |
||
| 118 | public function getToolbar(){ |
||
| 125 | |||
| 126 | /** |
||
| 127 | * Adds a new element in toolbar |
||
| 128 | * @param mixed $element |
||
| 129 | * @param callable $callback function to call on $element |
||
| 130 | * @return \Ajax\common\html\HtmlDoubleElement |
||
| 131 | */ |
||
| 132 | public function addInToolbar($element,$callback=NULL){ |
||
| 141 | |||
| 142 | public function addItemInToolbar($caption,$icon=NULL,$callback=NULL){ |
||
| 148 | |||
| 149 | public function addItemsInToolbar(array $items,$callback=NULL){ |
||
| 161 | |||
| 162 | View Code Duplication | public function addDropdownInToolbar($value,$items=NULL,$callback=NULL){ |
|
| 169 | |||
| 170 | public function addButtonInToolbar($caption,$callback=NULL){ |
||
| 174 | |||
| 175 | public function addButtonsInToolbar(array $captions,$asIcon=false,$callback=NULL){ |
||
| 179 | |||
| 180 | public function addLabelledIconButtonInToolbar($caption,$icon,$before=true,$labeled=false){ |
||
| 185 | |||
| 186 | /** |
||
| 187 | * Defines a callback function to call for modifying captions |
||
| 188 | * function parameters are $captions: the captions to modify and $instance: the active model instance |
||
| 189 | * @param callable $captionCallback |
||
| 190 | * @return Widget |
||
| 191 | */ |
||
| 192 | public function setCaptionCallback($captionCallback) { |
||
| 196 | } |