Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class _JsUtils extends \Ajax\JsUtils{ |
||
9 | public function getUrl($url){ |
||
22 | |||
23 | public function createScriptVariable(&$view,$view_var, $output){ |
||
26 | |||
27 | /** |
||
28 | * @param Symfony\Component\DependencyInjection\ContainerInterface $initialControllerInstance |
||
29 | * @param string $controllerName |
||
30 | * @param string $actionName |
||
31 | * @param array $params |
||
32 | * @see \Ajax\JsUtils::forward() |
||
33 | */ |
||
34 | View Code Duplication | public function forward($initialControllerInstance,$controllerName,$actionName,$params=array()){ |
|
43 | |||
44 | View Code Duplication | public function renderContent($initialControllerInstance,$viewName, $params=NULL) { |
|
55 | |||
56 | public function fromDispatcher($dispatcher){ |
||
59 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.