PhpUtils::parseFile() - Code Metrics - Inspection of "test regrouping all tests, refactor removing usele..." - phpMv/php-vuejs - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( 1c4e95...6e2581 )

by Guillaume

created 2021-06-02 20:13 UTC

PhpUtils::parseFile() A

↳ Parent: PhpUtils

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	6
nc	2
nop	2
dl	0
loc	8
ccs	0
cts	7
cp	0
crap	6
rs	10
c	1
b	0
f	0

<?php

namespace PHPMV\utils;

class PhpUtils {
	static private string $delimiter = '---';
	static private array $parsedJs = [];

	public static function importFromFile(string $filename, string $extension): string {
		return \file_get_contents($filename . '.' . $extension, true);
	}

	public static function parseFile(string $filename, string $extension): array {
		$pattern = '/' . self::$delimiter . '(.+?)' . self::$delimiter . '(.+?)' . self::$delimiter . 'end' . self::$delimiter . '/s';
		$templateString = self::importFromFile($filename, $extension);
		\preg_match_all($pattern, $templateString, $templateArray);
		for ($i = 0; $i < count($templateArray[0]); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
			self::$parsedJs[$templateArray[1][$i]] = $templateArray[2][$i];
		}
		return $templateArray;
	}

	public static function getParsedJs(string $name): string {
		return self::$parsedJs[$name];
	}
}



1			<?php
2
3			namespace PHPMV\utils;
4
5			class PhpUtils {
6			static private string $delimiter = '---';
7			static private array $parsedJs = [];
8
9			public static function importFromFile(string $filename, string $extension): string {
10			return \file_get_contents($filename . '.' . $extension, true);
11			}
12
13			public static function parseFile(string $filename, string $extension): array {
14			$pattern = '/' . self::$delimiter . '(.+?)' . self::$delimiter . '(.+?)' . self::$delimiter . 'end' . self::$delimiter . '/s';
15			$templateString = self::importFromFile($filename, $extension);
16			\preg_match_all($pattern, $templateString, $templateArray);
17			for ($i = 0; $i < count($templateArray[0]); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2021-06-02 02:31 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
18			self::$parsedJs[$templateArray[1][$i]] = $templateArray[2][$i];
19			}
20			return $templateArray;
21			}
22
23			public static function getParsedJs(string $name): string {
24			return self::$parsedJs[$name];
25			}
26			}
27
28

phpMv / php-vuejs

Push — main ( 1c4e95...6e2581 )

PhpUtils::parseFile() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like