Issues in ConfigureCacheTest.php - Fixed Issues - Inspection of "Remove JMS Serializer and refactor infra packages" - phpDocumentor/phpDocumentor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( d73a05...7ce957 )

by Mike

created 2019-06-14 17:33 UTC

Application/Stage/Parser/ConfigureCacheTest.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 *  This file is part of phpDocumentor.
 *
 *  For the full copyright and license information, please view the LICENSE
 *  file that was distributed with this source code.
 *
 *  @copyright 2010-2018 Mike van Riel<[email protected]>
 *  @license   http://www.opensource.org/licenses/mit-license.php MIT
 *  @link      http://phpdoc.org
 */

namespace phpDocumentor\Application\Stage\Parser;

use \Mockery as m;
use Mockery\Adapter\Phpunit\MockeryTestCase;
use phpDocumentor\DomainModel\Path;
use Zend\Cache\Storage\StorageInterface;

class ConfigureCacheTest extends MockeryTestCase
{
    /**
     * @dataProvider cacheDirProvider
     * @throws \Exception
     */
    public function testInvokeWithCachePath($configuredPath, $expectedPath)
    {
        $configuration = [
            'phpdocumentor' => [
                'paths' => [
                    'cache' => $configuredPath,
                ],
            ],
        ];

        $cacheStorage = m::mock(StorageInterface::class);
        $cacheStorage->shouldReceive('getOptions->setCacheDir')->withArgs([$expectedPath])->once();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $stage = new ConfigureCache($cacheStorage);

        self::assertSame($configuration, $stage($configuration));
    }

    public function cacheDirProvider()
    {
        return [
            [
                '/tmp/cache',
                '/tmp/cache',
            ],
            [
                'cache/relative',
                getcwd() . DIRECTORY_SEPARATOR . 'cache/relative',
            ],
            [
                new Path('/tmp/cache'),
                '/tmp/cache',
            ],
            [
                new Path('cache/relative'),
                getcwd() . DIRECTORY_SEPARATOR . 'cache/relative',
            ],
        ];
    }
}


Push — develop ( d73a05...7ce957 )

Application/Stage/Parser/ConfigureCacheTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

1			<?php
2			/**
3			* This file is part of phpDocumentor.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*
8			* @copyright 2010-2018 Mike van Riel<[email protected]>
9			* @license http://www.opensource.org/licenses/mit-license.php MIT
10			* @link http://phpdoc.org
11			*/
12
13			namespace phpDocumentor\Application\Stage\Parser;
14
15			use \Mockery as m;
16			use Mockery\Adapter\Phpunit\MockeryTestCase;
17			use phpDocumentor\DomainModel\Path;
18			use Zend\Cache\Storage\StorageInterface;
19
20			class ConfigureCacheTest extends MockeryTestCase
21			{
22			/**
23			* @dataProvider cacheDirProvider
24			* @throws \Exception
25			*/
26			public function testInvokeWithCachePath($configuredPath, $expectedPath)
27			{
28			$configuration = [
29			'phpdocumentor' => [
30			'paths' => [
31			'cache' => $configuredPath,
32			],
33			],
34			];
35
36			$cacheStorage = m::mock(StorageInterface::class);
37			$cacheStorage->shouldReceive('getOptions->setCacheDir')->withArgs([$expectedPath])->once();
			0 ignored issues – show Bug introduced 2018-06-13 21:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `withArgs` does only exist in `Mockery\HigherOrderMessage`, but not in `Mockery\ExpectationInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
38
39			$stage = new ConfigureCache($cacheStorage);
40
41			self::assertSame($configuration, $stage($configuration));
42			}
43
44			public function cacheDirProvider()
45			{
46			return [
47			[
48			'/tmp/cache',
49			'/tmp/cache',
50			],
51			[
52			'cache/relative',
53			getcwd() . DIRECTORY_SEPARATOR . 'cache/relative',
54			],
55			[
56			new Path('/tmp/cache'),
57			'/tmp/cache',
58			],
59			[
60			new Path('cache/relative'),
61			getcwd() . DIRECTORY_SEPARATOR . 'cache/relative',
62			],
63			];
64			}
65			}
66

phpDocumentor / phpDocumentor

Push — develop ( d73a05...7ce957 )

Application/Stage/Parser/ConfigureCacheTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like