FromContainerFactoryTest::setUp() - Code Metrics - Inspection of "Moves cache tests" - phpDocumentor/phpDocumentor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 3bf98d...ad187c )

by Jaap

created 2016-12-27 15:05 UTC

FromContainerFactoryTest::setUp() A

↳ Parent: FromContainerFactoryTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	0
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * This file is part of phpDocumentor.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @copyright 2010-2016 Mike van Riel<[email protected]>
 * @license   http://www.opensource.org/licenses/mit-license.php MIT
 * @link      http://phpdoc.org
 */

namespace phpDocumentor\Application\ReadModel;

use Interop\Container\ContainerInterface;
use Mockery as m;
use phpDocumentor\DomainModel\ReadModel\Type;

/**
 * @coversDefaultClass phpDocumentor\Application\ReadModel\FromContainerFactory
 * @covers ::<private>
 */
final class FromContainerFactoryTest extends \PHPUnit_Framework_TestCase
{
    /** @var ContainerInterface|m\MockInterface */
    private $container;

    /** @var FromContainerFactory */
    private $factory;

    protected function setUp()
    {
        $this->container = m::mock(ContainerInterface::class);
        $this->factory = new FromContainerFactory($this->container, [ 'alias' => 'phpDocumentor2' ]);
    }

    /**
     * @test
     * @covers ::__construct
     * @covers ::create
     */
    public function itShouldCreateANewReadModelByRetrievingItFromTheContainer()
    {
        $expectedReadModelName = 'phpDocumentor2';
        $expected = 'readModel';
        $this->container->shouldReceive('get')->once()
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->with($expectedReadModelName)->andReturn($expected);

        $this->assertSame($expected, $this->factory->create(new Type($expectedReadModelName)));
    }

    /**
     * @test
     * @covers ::__construct
     * @covers ::create
     */
    public function itShouldCreateANewReadModelByRetrievingItFromTheContainerBasedOnAnAlias()
    {
        $expectedReadModelName = 'phpDocumentor2';
        $expected = 'readModel';
        $this->container->shouldReceive('get')->once()
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->with($expectedReadModelName)->andReturn($expected);

        $this->assertSame($expected, $this->factory->create(new Type('alias')));
    }
}


Push — develop ( 3bf98d...ad187c )

FromContainerFactoryTest::setUp() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2			/**
3			* This file is part of phpDocumentor.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*
8			* @copyright 2010-2016 Mike van Riel<[email protected]>
9			* @license http://www.opensource.org/licenses/mit-license.php MIT
10			* @link http://phpdoc.org
11			*/
12
13			namespace phpDocumentor\Application\ReadModel;
14
15			use Interop\Container\ContainerInterface;
16			use Mockery as m;
17			use phpDocumentor\DomainModel\ReadModel\Type;
18
19			/**
20			* @coversDefaultClass phpDocumentor\Application\ReadModel\FromContainerFactory
21			* @covers ::<private>
22			*/
23			final class FromContainerFactoryTest extends \PHPUnit_Framework_TestCase
24			{
25			/** @var ContainerInterface\|m\MockInterface */
26			private $container;
27
28			/** @var FromContainerFactory */
29			private $factory;
30
31			protected function setUp()
32			{
33			$this->container = m::mock(ContainerInterface::class);
34			$this->factory = new FromContainerFactory($this->container, [ 'alias' => 'phpDocumentor2' ]);
35			}
36
37			/**
38			* @test
39			* @covers ::__construct
40			* @covers ::create
41			*/
42			public function itShouldCreateANewReadModelByRetrievingItFromTheContainer()
43			{
44			$expectedReadModelName = 'phpDocumentor2';
45			$expected = 'readModel';
46			$this->container->shouldReceive('get')->once()
			0 ignored issues – show Bug introduced 2016-02-29 06:55 UTC by Report Bug Copy Issue Report The method `shouldReceive` does only exist in `Mockery\MockInterface`, but not in `Interop\Container\ContainerInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
47			->with($expectedReadModelName)->andReturn($expected);
48
49			$this->assertSame($expected, $this->factory->create(new Type($expectedReadModelName)));
50			}
51
52			/**
53			* @test
54			* @covers ::__construct
55			* @covers ::create
56			*/
57			public function itShouldCreateANewReadModelByRetrievingItFromTheContainerBasedOnAnAlias()
58			{
59			$expectedReadModelName = 'phpDocumentor2';
60			$expected = 'readModel';
61			$this->container->shouldReceive('get')->once()
			0 ignored issues – show Bug introduced 2016-02-29 06:55 UTC by Report Bug Copy Issue Report The method `shouldReceive` does only exist in `Mockery\MockInterface`, but not in `Interop\Container\ContainerInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
62			->with($expectedReadModelName)->andReturn($expected);
63
64			$this->assertSame($expected, $this->factory->create(new Type('alias')));
65			}
66			}
67

phpDocumentor / phpDocumentor

Push — develop ( 3bf98d...ad187c )

FromContainerFactoryTest::setUp() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like