Issues in FileDescriptorTest.php (develop) - Issues in develop - phpDocumentor/phpDocumentor - Measure and Improve Code Quality continuously with Scrutinizer

Issues (387)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

phpDocumentor/Descriptor/FileDescriptorTest.php (1 issue)

Labels

Bug 1

Severity

Major 1

slaubi schlau 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * phpDocumentor
 *
 * PHP Version 5.3
 *
 * @copyright 2010-2018 Mike van Riel / Naenius (http://www.naenius.com)
 * @license   http://www.opensource.org/licenses/mit-license.php MIT
 * @link      http://phpdoc.org
 */

namespace phpDocumentor\Descriptor;

use \Mockery as m;

/**
 * Tests the functionality for the FileDescriptor class.
 */
class FileDescriptorTest extends \Mockery\Adapter\Phpunit\MockeryTestCase
{
    const EXAMPLE_HASH = 'a-hash-string';

    const EXAMPLE_PATH = 'a-path-string';

    const EXAMPLE_SOURCE = 'a-source-string';

    /** @var FileDescriptor $fixture */
    protected $fixture;

    /**
     * Creates a new (empty) fixture object.
     */
    protected function setUp()
    {
        $this->fixture = new FileDescriptor(self::EXAMPLE_HASH);
    }

    /**
     * Tests whether all collection objects and hash are properly initialized
     *
     * @covers phpDocumentor\Descriptor\FileDescriptor::__construct
     */
    public function testInitialize()
    {
        $this->assertAttributeEquals(self::EXAMPLE_HASH, 'hash', $this->fixture);

        $this->assertAttributeInstanceOf('phpDocumentor\Descriptor\Collection', 'namespaceAliases', $this->fixture);
        $this->assertAttributeInstanceOf('phpDocumentor\Descriptor\Collection', 'includes', $this->fixture);
        $this->assertAttributeInstanceOf('phpDocumentor\Descriptor\Collection', 'constants', $this->fixture);
        $this->assertAttributeInstanceOf('phpDocumentor\Descriptor\Collection', 'functions', $this->fixture);
        $this->assertAttributeInstanceOf('phpDocumentor\Descriptor\Collection', 'classes', $this->fixture);
        $this->assertAttributeInstanceOf('phpDocumentor\Descriptor\Collection', 'interfaces', $this->fixture);
        $this->assertAttributeInstanceOf('phpDocumentor\Descriptor\Collection', 'traits', $this->fixture);
        $this->assertAttributeInstanceOf('phpDocumentor\Descriptor\Collection', 'markers', $this->fixture);
    }

    /**
     * @covers phpDocumentor\Descriptor\FileDescriptor::__construct
     * @covers phpDocumentor\Descriptor\FileDescriptor::getHash
     */
    public function testGetHash()
    {
        $this->assertSame(self::EXAMPLE_HASH, $this->fixture->getHash());
    }

    /**
     * @covers phpDocumentor\Descriptor\FileDescriptor::setPath
     * @covers phpDocumentor\Descriptor\FileDescriptor::getPath
     */
    public function testSetAndGetPath()
    {
        $this->assertSame('', $this->fixture->getPath());

        $this->fixture->setPath(self::EXAMPLE_PATH);

        $this->assertSame(self::EXAMPLE_PATH, $this->fixture->getPath());
    }

    /**
     * @covers phpDocumentor\Descriptor\FileDescriptor::setSource
     * @covers phpDocumentor\Descriptor\FileDescriptor::getSource
     */
    public function testSetAndGetSource()
    {
        $this->assertNull($this->fixture->getSource());

        $this->fixture->setSource(self::EXAMPLE_SOURCE);

        $this->assertSame(self::EXAMPLE_SOURCE, $this->fixture->getSource());
    }

    /**
     * @covers phpDocumentor\Descriptor\FileDescriptor::setNamespaceAliases
     * @covers phpDocumentor\Descriptor\FileDescriptor::getNamespaceAliases
     */
    public function testSetAndGetNamespaceAliases()
    {
        $this->assertInstanceOf('phpDocumentor\Descriptor\Collection', $this->fixture->getNamespaceAliases());

        $mockInstance = m::mock('phpDocumentor\Descriptor\Collection');
        $mock = $mockInstance;

        $this->fixture->setNamespaceAliases($mock);

        $this->assertSame($mockInstance, $this->fixture->getNamespaceAliases());
    }

    /**
     * @covers phpDocumentor\Descriptor\FileDescriptor::setIncludes
     * @covers phpDocumentor\Descriptor\FileDescriptor::getIncludes
     */
    public function testSetAndGetIncludes()
    {
        $this->assertInstanceOf('phpDocumentor\Descriptor\Collection', $this->fixture->getIncludes());

        $mockInstance = m::mock('phpDocumentor\Descriptor\Collection');
        $mock = $mockInstance;

        $this->fixture->setIncludes($mock);

        $this->assertSame($mockInstance, $this->fixture->getIncludes());
    }

    /**
     * @covers phpDocumentor\Descriptor\FileDescriptor::setConstants
     * @covers phpDocumentor\Descriptor\FileDescriptor::getConstants
     */
    public function testSetAndGetConstants()
    {
        $this->assertInstanceOf('phpDocumentor\Descriptor\Collection', $this->fixture->getConstants());

        $mockInstance = m::mock('phpDocumentor\Descriptor\Collection');
        $mock = $mockInstance;

        $this->fixture->setConstants($mock);

        $this->assertSame($mockInstance, $this->fixture->getConstants());
    }

    /**
     * @covers phpDocumentor\Descriptor\FileDescriptor::setFunctions
     * @covers phpDocumentor\Descriptor\FileDescriptor::getFunctions
     */
    public function testSetAndGetFunctions()
    {
        $this->assertInstanceOf('phpDocumentor\Descriptor\Collection', $this->fixture->getFunctions());

        $mockInstance = m::mock('phpDocumentor\Descriptor\Collection');
        $mock = $mockInstance;

        $this->fixture->setFunctions($mock);

        $this->assertSame($mockInstance, $this->fixture->getFunctions());
    }

    /**
     * @covers phpDocumentor\Descriptor\FileDescriptor::setClasses
     * @covers phpDocumentor\Descriptor\FileDescriptor::getClasses
     */
    public function testSetAndGetClasses()
    {
        $this->assertInstanceOf('phpDocumentor\Descriptor\Collection', $this->fixture->getClasses());

        $mockInstance = m::mock('phpDocumentor\Descriptor\Collection');
        $mock = $mockInstance;

        $this->fixture->setClasses($mock);

        $this->assertSame($mockInstance, $this->fixture->getClasses());
    }

    /**
     * @covers phpDocumentor\Descriptor\FileDescriptor::setInterfaces
     * @covers phpDocumentor\Descriptor\FileDescriptor::getInterfaces
     */
    public function testSetAndGetInterfaces()
    {
        $this->assertInstanceOf('phpDocumentor\Descriptor\Collection', $this->fixture->getInterfaces());

        $mockInstance = m::mock('phpDocumentor\Descriptor\Collection');
        $mock = $mockInstance;

        $this->fixture->setInterfaces($mock);

        $this->assertSame($mockInstance, $this->fixture->getInterfaces());
    }

    /**
     * @covers phpDocumentor\Descriptor\FileDescriptor::setTraits
     * @covers phpDocumentor\Descriptor\FileDescriptor::getTraits
     */
    public function testSetAndGetTraits()
    {
        $this->assertInstanceOf('phpDocumentor\Descriptor\Collection', $this->fixture->getTraits());

        $mockInstance = m::mock('phpDocumentor\Descriptor\Collection');
        $mock = $mockInstance;

        $this->fixture->setTraits($mock);

        $this->assertSame($mockInstance, $this->fixture->getTraits());
    }

    /**
     * @covers phpDocumentor\Descriptor\FileDescriptor::setMarkers
     * @covers phpDocumentor\Descriptor\FileDescriptor::getMarkers
     */
    public function testSetAndGetMarkers()
    {
        $this->assertInstanceOf('phpDocumentor\Descriptor\Collection', $this->fixture->getMarkers());

        $mockInstance = m::mock('phpDocumentor\Descriptor\Collection');
        $mock = $mockInstance;

        $this->fixture->setMarkers($mock);

        $this->assertSame($mockInstance, $this->fixture->getMarkers());
    }

    /**
     * @covers phpDocumentor\Descriptor\FileDescriptor::__construct
     * @covers phpDocumentor\Descriptor\FileDescriptor::getAllErrors
     */
    public function testIfErrorsAreInitializedToAnEmptyCollectionOnInstantiation()
    {
        // construct
        $this->assertInstanceOf('phpDocumentor\Descriptor\Collection', $this->fixture->getAllErrors());

        // default returns empty array
        $this->assertObjectHasAttribute('items', $this->fixture->getAllErrors());

        $items = $this->fixture->getAllErrors()->getAll();
        $this->assertEmpty($items);
    }

    /**
     * @covers phpDocumentor\Descriptor\FileDescriptor::__construct
     * @covers phpDocumentor\Descriptor\FileDescriptor::getAllErrors
     */
    public function testGetAllErrors()
    {
        /*
         * constant
         * function
         * class
         *     property
         *     constant
         *     method
         * interface
         *     constant
         *     method
         * traits
         *     property
         *     method
         */

        // setup error list
        $errorGlobal = ['error-global'];
        $errorClasses = ['error-class'];
        $errorClassMethods = ['error-class-method'];
        $errorClassConstants = ['error-class-constant'];
        $errorClassProperties = ['error-class-property'];
        $errorInterfaces = ['error-interface'];
        $errorInterfacesConstants = ['error-interface-constant'];
        $errorInterfacesMethods = ['error-interface-method'];
        $errorTraits = ['error-traits'];
        $errorTraitsProperties = ['error-traits-property'];
        $errorTraitsMethods = ['error-traits-method'];
        $errorFunctions = ['error-functions'];

        // setup global check
        $collection = new Collection($errorGlobal);
        $this->fixture->setErrors($collection);

        // setup class-property check
        $mockClassProperties = m::mock('phpDocumentor\Descriptor\PropertyDescriptor');
        $mockClassProperties->shouldReceive('getErrors')->andReturn(new Collection($errorClassProperties));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        // setup class-constant check
        $mockClassConstants = m::mock('phpDocumentor\Descriptor\ConstantDescriptor');
        $mockClassConstants->shouldReceive('getErrors')->andReturn(new Collection($errorClassConstants));

        // setup class-method check
        $mockClassMethods = m::mock('phpDocumentor\Descriptor\MethodDescriptor');
        $mockClassMethods->shouldReceive('getErrors')->andReturn(new Collection($errorClassMethods));

        // setup class check
        $mockClasses = m::mock('phpDocumentor\Descriptor\ClassDescriptor');
        $mockClasses->shouldReceive('getProperties')->andReturn(new Collection([$mockClassProperties]));
        $mockClasses->shouldReceive('getConstants')->andReturn(new Collection([$mockClassConstants]));
        $mockClasses->shouldReceive('getMethods')->andReturn(new Collection([$mockClassMethods]));
        $mockClasses->shouldReceive('getErrors')->andReturn(new Collection($errorClasses));

        $this->fixture->getClasses()->set('my-test-class', $mockClasses);

        // setup interface-constant check
        $mockInterfaceConstants = m::mock('phpDocumentor\Descriptor\ConstantDescriptor');
        $mockInterfaceConstants->shouldReceive('getErrors')->andReturn(new Collection($errorInterfacesConstants));

        // setup interface-method check
        $mockInterfaceMethods = m::mock('phpDocumentor\Descriptor\MethodDescriptor');
        $mockInterfaceMethods->shouldReceive('getErrors')->andReturn(new Collection($errorInterfacesMethods));

        // setup interface check
        $mockInterfaces = m::mock('phpDocumentor\Descriptor\ClassDescriptor');
        $mockInterfaces->shouldReceive('getProperties')->andReturn([]);
        $mockInterfaces->shouldReceive('getConstants')->andReturn(new Collection([$mockInterfaceConstants]));
        $mockInterfaces->shouldReceive('getMethods')->andReturn(new Collection([$mockInterfaceMethods]));
        $mockInterfaces->shouldReceive('getErrors')->andReturn(new Collection($errorInterfaces));

        $this->fixture->getClasses()->set('my-test-interface', $mockInterfaces);

        // setup traits-constant check
        $mockTraitsProperties = m::mock('phpDocumentor\Descriptor\ConstantDescriptor');
        $mockTraitsProperties->shouldReceive('getErrors')->andReturn(new Collection($errorTraitsProperties));

        // setup traits-method check
        $mockTraitsMethods = m::mock('phpDocumentor\Descriptor\MethodDescriptor');
        $mockTraitsMethods->shouldReceive('getErrors')->andReturn(new Collection($errorTraitsMethods));

        // setup traits check
        $mockTraits = m::mock('phpDocumentor\Descriptor\ClassDescriptor');
        $mockTraits->shouldReceive('getConstants')->andReturn([]);
        $mockTraits->shouldReceive('getProperties')->andReturn(new Collection([$mockTraitsProperties]));
        $mockTraits->shouldReceive('getMethods')->andReturn(new Collection([$mockTraitsMethods]));
        $mockTraits->shouldReceive('getErrors')->andReturn(new Collection($errorTraits));

        $this->fixture->getClasses()->set('my-test-traits', $mockTraits);

        // setup functions check
        $mockFunctions = m::mock('phpDocumentor\Descriptor\FunctionDescriptor');

        // create dummy instances of constants/methods
        $mockFunctions->shouldReceive('getConstants')->andReturn([]);
        $mockFunctions->shouldReceive('getProperties')->andReturn([]);
        $mockFunctions->shouldReceive('getMethods')->andReturn([]);
        $mockFunctions->shouldReceive('getErrors')->andReturn(new Collection($errorFunctions));

        $this->fixture->getClasses()->set('my-test-function', $mockFunctions);

        // final merge and check
        $expectedErrors = array_merge(
            $errorGlobal,
            $errorClasses,
            $errorInterfaces,
            $errorTraits,
            $errorFunctions,
            $errorClassMethods,
            $errorClassConstants,
            $errorClassProperties,
            $errorInterfacesMethods,
            $errorInterfacesConstants,
            $errorTraitsMethods,
            $errorTraitsProperties
        );

        $this->assertSame($expectedErrors, $this->fixture->getAllErrors()->getAll());
    }
}


Issues (387)

Security Analysis no request data

phpDocumentor/Descriptor/FileDescriptorTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

1			<?php
2			/**
3			* phpDocumentor
4			*
5			* PHP Version 5.3
6			*
7			* @copyright 2010-2018 Mike van Riel / Naenius (http://www.naenius.com)
8			* @license http://www.opensource.org/licenses/mit-license.php MIT
9			* @link http://phpdoc.org
10			*/
11
12			namespace phpDocumentor\Descriptor;
13
14			use \Mockery as m;
15
16			/**
17			* Tests the functionality for the FileDescriptor class.
18			*/
19			class FileDescriptorTest extends \Mockery\Adapter\Phpunit\MockeryTestCase
20			{
21			const EXAMPLE_HASH = 'a-hash-string';
22
23			const EXAMPLE_PATH = 'a-path-string';
24
25			const EXAMPLE_SOURCE = 'a-source-string';
26
27			/** @var FileDescriptor $fixture */
28			protected $fixture;
29
30			/**
31			* Creates a new (empty) fixture object.
32			*/
33			protected function setUp()
34			{
35			$this->fixture = new FileDescriptor(self::EXAMPLE_HASH);
36			}
37
38			/**
39			* Tests whether all collection objects and hash are properly initialized
40			*
41			* @covers phpDocumentor\Descriptor\FileDescriptor::__construct
42			*/
43			public function testInitialize()
44			{
45			$this->assertAttributeEquals(self::EXAMPLE_HASH, 'hash', $this->fixture);
46
47			$this->assertAttributeInstanceOf('phpDocumentor\Descriptor\Collection', 'namespaceAliases', $this->fixture);
48			$this->assertAttributeInstanceOf('phpDocumentor\Descriptor\Collection', 'includes', $this->fixture);
49			$this->assertAttributeInstanceOf('phpDocumentor\Descriptor\Collection', 'constants', $this->fixture);
50			$this->assertAttributeInstanceOf('phpDocumentor\Descriptor\Collection', 'functions', $this->fixture);
51			$this->assertAttributeInstanceOf('phpDocumentor\Descriptor\Collection', 'classes', $this->fixture);
52			$this->assertAttributeInstanceOf('phpDocumentor\Descriptor\Collection', 'interfaces', $this->fixture);
53			$this->assertAttributeInstanceOf('phpDocumentor\Descriptor\Collection', 'traits', $this->fixture);
54			$this->assertAttributeInstanceOf('phpDocumentor\Descriptor\Collection', 'markers', $this->fixture);
55			}
56
57			/**
58			* @covers phpDocumentor\Descriptor\FileDescriptor::__construct
59			* @covers phpDocumentor\Descriptor\FileDescriptor::getHash
60			*/
61			public function testGetHash()
62			{
63			$this->assertSame(self::EXAMPLE_HASH, $this->fixture->getHash());
64			}
65
66			/**
67			* @covers phpDocumentor\Descriptor\FileDescriptor::setPath
68			* @covers phpDocumentor\Descriptor\FileDescriptor::getPath
69			*/
70			public function testSetAndGetPath()
71			{
72			$this->assertSame('', $this->fixture->getPath());
73
74			$this->fixture->setPath(self::EXAMPLE_PATH);
75
76			$this->assertSame(self::EXAMPLE_PATH, $this->fixture->getPath());
77			}
78
79			/**
80			* @covers phpDocumentor\Descriptor\FileDescriptor::setSource
81			* @covers phpDocumentor\Descriptor\FileDescriptor::getSource
82			*/
83			public function testSetAndGetSource()
84			{
85			$this->assertNull($this->fixture->getSource());
86
87			$this->fixture->setSource(self::EXAMPLE_SOURCE);
88
89			$this->assertSame(self::EXAMPLE_SOURCE, $this->fixture->getSource());
90			}
91
92			/**
93			* @covers phpDocumentor\Descriptor\FileDescriptor::setNamespaceAliases
94			* @covers phpDocumentor\Descriptor\FileDescriptor::getNamespaceAliases
95			*/
96			public function testSetAndGetNamespaceAliases()
97			{
98			$this->assertInstanceOf('phpDocumentor\Descriptor\Collection', $this->fixture->getNamespaceAliases());
99
100			$mockInstance = m::mock('phpDocumentor\Descriptor\Collection');
101			$mock = $mockInstance;
102
103			$this->fixture->setNamespaceAliases($mock);
104
105			$this->assertSame($mockInstance, $this->fixture->getNamespaceAliases());
106			}
107
108			/**
109			* @covers phpDocumentor\Descriptor\FileDescriptor::setIncludes
110			* @covers phpDocumentor\Descriptor\FileDescriptor::getIncludes
111			*/
112			public function testSetAndGetIncludes()
113			{
114			$this->assertInstanceOf('phpDocumentor\Descriptor\Collection', $this->fixture->getIncludes());
115
116			$mockInstance = m::mock('phpDocumentor\Descriptor\Collection');
117			$mock = $mockInstance;
118
119			$this->fixture->setIncludes($mock);
120
121			$this->assertSame($mockInstance, $this->fixture->getIncludes());
122			}
123
124			/**
125			* @covers phpDocumentor\Descriptor\FileDescriptor::setConstants
126			* @covers phpDocumentor\Descriptor\FileDescriptor::getConstants
127			*/
128			public function testSetAndGetConstants()
129			{
130			$this->assertInstanceOf('phpDocumentor\Descriptor\Collection', $this->fixture->getConstants());
131
132			$mockInstance = m::mock('phpDocumentor\Descriptor\Collection');
133			$mock = $mockInstance;
134
135			$this->fixture->setConstants($mock);
136
137			$this->assertSame($mockInstance, $this->fixture->getConstants());
138			}
139
140			/**
141			* @covers phpDocumentor\Descriptor\FileDescriptor::setFunctions
142			* @covers phpDocumentor\Descriptor\FileDescriptor::getFunctions
143			*/
144			public function testSetAndGetFunctions()
145			{
146			$this->assertInstanceOf('phpDocumentor\Descriptor\Collection', $this->fixture->getFunctions());
147
148			$mockInstance = m::mock('phpDocumentor\Descriptor\Collection');
149			$mock = $mockInstance;
150
151			$this->fixture->setFunctions($mock);
152
153			$this->assertSame($mockInstance, $this->fixture->getFunctions());
154			}
155
156			/**
157			* @covers phpDocumentor\Descriptor\FileDescriptor::setClasses
158			* @covers phpDocumentor\Descriptor\FileDescriptor::getClasses
159			*/
160			public function testSetAndGetClasses()
161			{
162			$this->assertInstanceOf('phpDocumentor\Descriptor\Collection', $this->fixture->getClasses());
163
164			$mockInstance = m::mock('phpDocumentor\Descriptor\Collection');
165			$mock = $mockInstance;
166
167			$this->fixture->setClasses($mock);
168
169			$this->assertSame($mockInstance, $this->fixture->getClasses());
170			}
171
172			/**
173			* @covers phpDocumentor\Descriptor\FileDescriptor::setInterfaces
174			* @covers phpDocumentor\Descriptor\FileDescriptor::getInterfaces
175			*/
176			public function testSetAndGetInterfaces()
177			{
178			$this->assertInstanceOf('phpDocumentor\Descriptor\Collection', $this->fixture->getInterfaces());
179
180			$mockInstance = m::mock('phpDocumentor\Descriptor\Collection');
181			$mock = $mockInstance;
182
183			$this->fixture->setInterfaces($mock);
184
185			$this->assertSame($mockInstance, $this->fixture->getInterfaces());
186			}
187
188			/**
189			* @covers phpDocumentor\Descriptor\FileDescriptor::setTraits
190			* @covers phpDocumentor\Descriptor\FileDescriptor::getTraits
191			*/
192			public function testSetAndGetTraits()
193			{
194			$this->assertInstanceOf('phpDocumentor\Descriptor\Collection', $this->fixture->getTraits());
195
196			$mockInstance = m::mock('phpDocumentor\Descriptor\Collection');
197			$mock = $mockInstance;
198
199			$this->fixture->setTraits($mock);
200
201			$this->assertSame($mockInstance, $this->fixture->getTraits());
202			}
203
204			/**
205			* @covers phpDocumentor\Descriptor\FileDescriptor::setMarkers
206			* @covers phpDocumentor\Descriptor\FileDescriptor::getMarkers
207			*/
208			public function testSetAndGetMarkers()
209			{
210			$this->assertInstanceOf('phpDocumentor\Descriptor\Collection', $this->fixture->getMarkers());
211
212			$mockInstance = m::mock('phpDocumentor\Descriptor\Collection');
213			$mock = $mockInstance;
214
215			$this->fixture->setMarkers($mock);
216
217			$this->assertSame($mockInstance, $this->fixture->getMarkers());
218			}
219
220			/**
221			* @covers phpDocumentor\Descriptor\FileDescriptor::__construct
222			* @covers phpDocumentor\Descriptor\FileDescriptor::getAllErrors
223			*/
224			public function testIfErrorsAreInitializedToAnEmptyCollectionOnInstantiation()
225			{
226			// construct
227			$this->assertInstanceOf('phpDocumentor\Descriptor\Collection', $this->fixture->getAllErrors());
228
229			// default returns empty array
230			$this->assertObjectHasAttribute('items', $this->fixture->getAllErrors());
231
232			$items = $this->fixture->getAllErrors()->getAll();
233			$this->assertEmpty($items);
234			}
235
236			/**
237			* @covers phpDocumentor\Descriptor\FileDescriptor::__construct
238			* @covers phpDocumentor\Descriptor\FileDescriptor::getAllErrors
239			*/
240			public function testGetAllErrors()
241			{
242			/*
243			* constant
244			* function
245			* class
246			* property
247			* constant
248			* method
249			* interface
250			* constant
251			* method
252			* traits
253			* property
254			* method
255			*/
256
257			// setup error list
258			$errorGlobal = ['error-global'];
259			$errorClasses = ['error-class'];
260			$errorClassMethods = ['error-class-method'];
261			$errorClassConstants = ['error-class-constant'];
262			$errorClassProperties = ['error-class-property'];
263			$errorInterfaces = ['error-interface'];
264			$errorInterfacesConstants = ['error-interface-constant'];
265			$errorInterfacesMethods = ['error-interface-method'];
266			$errorTraits = ['error-traits'];
267			$errorTraitsProperties = ['error-traits-property'];
268			$errorTraitsMethods = ['error-traits-method'];
269			$errorFunctions = ['error-functions'];
270
271			// setup global check
272			$collection = new Collection($errorGlobal);
273			$this->fixture->setErrors($collection);
274
275			// setup class-property check
276			$mockClassProperties = m::mock('phpDocumentor\Descriptor\PropertyDescriptor');
277			$mockClassProperties->shouldReceive('getErrors')->andReturn(new Collection($errorClassProperties));
			0 ignored issues – show Bug introduced 2017-10-10 14:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `andReturn` does only exist in `Mockery\ExpectationInterface`, but not in `Mockery\HigherOrderMessage`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
278
279			// setup class-constant check
280			$mockClassConstants = m::mock('phpDocumentor\Descriptor\ConstantDescriptor');
281			$mockClassConstants->shouldReceive('getErrors')->andReturn(new Collection($errorClassConstants));
282
283			// setup class-method check
284			$mockClassMethods = m::mock('phpDocumentor\Descriptor\MethodDescriptor');
285			$mockClassMethods->shouldReceive('getErrors')->andReturn(new Collection($errorClassMethods));
286
287			// setup class check
288			$mockClasses = m::mock('phpDocumentor\Descriptor\ClassDescriptor');
289			$mockClasses->shouldReceive('getProperties')->andReturn(new Collection([$mockClassProperties]));
290			$mockClasses->shouldReceive('getConstants')->andReturn(new Collection([$mockClassConstants]));
291			$mockClasses->shouldReceive('getMethods')->andReturn(new Collection([$mockClassMethods]));
292			$mockClasses->shouldReceive('getErrors')->andReturn(new Collection($errorClasses));
293
294			$this->fixture->getClasses()->set('my-test-class', $mockClasses);
295
296			// setup interface-constant check
297			$mockInterfaceConstants = m::mock('phpDocumentor\Descriptor\ConstantDescriptor');
298			$mockInterfaceConstants->shouldReceive('getErrors')->andReturn(new Collection($errorInterfacesConstants));
299
300			// setup interface-method check
301			$mockInterfaceMethods = m::mock('phpDocumentor\Descriptor\MethodDescriptor');
302			$mockInterfaceMethods->shouldReceive('getErrors')->andReturn(new Collection($errorInterfacesMethods));
303
304			// setup interface check
305			$mockInterfaces = m::mock('phpDocumentor\Descriptor\ClassDescriptor');
306			$mockInterfaces->shouldReceive('getProperties')->andReturn([]);
307			$mockInterfaces->shouldReceive('getConstants')->andReturn(new Collection([$mockInterfaceConstants]));
308			$mockInterfaces->shouldReceive('getMethods')->andReturn(new Collection([$mockInterfaceMethods]));
309			$mockInterfaces->shouldReceive('getErrors')->andReturn(new Collection($errorInterfaces));
310
311			$this->fixture->getClasses()->set('my-test-interface', $mockInterfaces);
312
313			// setup traits-constant check
314			$mockTraitsProperties = m::mock('phpDocumentor\Descriptor\ConstantDescriptor');
315			$mockTraitsProperties->shouldReceive('getErrors')->andReturn(new Collection($errorTraitsProperties));
316
317			// setup traits-method check
318			$mockTraitsMethods = m::mock('phpDocumentor\Descriptor\MethodDescriptor');
319			$mockTraitsMethods->shouldReceive('getErrors')->andReturn(new Collection($errorTraitsMethods));
320
321			// setup traits check
322			$mockTraits = m::mock('phpDocumentor\Descriptor\ClassDescriptor');
323			$mockTraits->shouldReceive('getConstants')->andReturn([]);
324			$mockTraits->shouldReceive('getProperties')->andReturn(new Collection([$mockTraitsProperties]));
325			$mockTraits->shouldReceive('getMethods')->andReturn(new Collection([$mockTraitsMethods]));
326			$mockTraits->shouldReceive('getErrors')->andReturn(new Collection($errorTraits));
327
328			$this->fixture->getClasses()->set('my-test-traits', $mockTraits);
329
330			// setup functions check
331			$mockFunctions = m::mock('phpDocumentor\Descriptor\FunctionDescriptor');
332
333			// create dummy instances of constants/methods
334			$mockFunctions->shouldReceive('getConstants')->andReturn([]);
335			$mockFunctions->shouldReceive('getProperties')->andReturn([]);
336			$mockFunctions->shouldReceive('getMethods')->andReturn([]);
337			$mockFunctions->shouldReceive('getErrors')->andReturn(new Collection($errorFunctions));
338
339			$this->fixture->getClasses()->set('my-test-function', $mockFunctions);
340
341			// final merge and check
342			$expectedErrors = array_merge(
343			$errorGlobal,
344			$errorClasses,
345			$errorInterfaces,
346			$errorTraits,
347			$errorFunctions,
348			$errorClassMethods,
349			$errorClassConstants,
350			$errorClassProperties,
351			$errorInterfacesMethods,
352			$errorInterfacesConstants,
353			$errorTraitsMethods,
354			$errorTraitsProperties
355			);
356
357			$this->assertSame($expectedErrors, $this->fixture->getAllErrors()->getAll());
358			}
359			}
360

phpDocumentor / phpDocumentor

Issues (387)

Security Analysis no request data

phpDocumentor/Descriptor/FileDescriptorTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like