Issues in CollectionTest.php - All Issues - Inspection of "Delete Scrybe" - phpDocumentor/phpDocumentor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 8eb671...133594 )

by Mike

created 2019-06-14 08:00 UTC

Transformer/Writer/CollectionTest.php (1 issue)

Labels

Documentation 1

Severity

Marieke 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * phpDocumentor
 *
 * PHP Version 5.3
 *
 * @author    Mike van Riel <[email protected]>
 * @copyright 2010-2018 Mike van Riel / Naenius (http://www.naenius.com)
 * @license   http://www.opensource.org/licenses/mit-license.php MIT
 * @link      http://phpdoc.org
 */

namespace phpDocumentor\Transformer\Writer;

use Mockery as m;
use Mockery\MockInterface;
use phpDocumentor\Transformer\Writer\Xsl;
use phpDocumentor\Transformer\Router\Queue;

/**
 * Test class for phpDocumentor\Transformer\Writer\Collection
 */
class CollectionTest extends \Mockery\Adapter\Phpunit\MockeryTestCase
{
    /** @var MockInterface|Queue */
    protected $routers;

    /** @var MockInterface|Xsl */
    protected $writer;

    /** @var Collection */
    protected $fixture;

    /**
     * Initializes the fixture and dependencies for this testcase.
     */
    protected function setUp()
    {
        $this->routers = m::mock('phpDocumentor\Transformer\Router\Queue');
        $this->writer = m::mock('phpDocumentor\Transformer\Writer\Xsl');
        $this->fixture = new Collection($this->routers);
    }

    /**
     * @covers phpDocumentor\Transformer\Writer\Collection::__construct
     */
    public function testIfDependenciesAreCorrectlyRegisteredOnInitialization()
    {
        $this->assertAttributeSame($this->routers, 'routers', $this->fixture);
    }

    /**
     * @expectedException \InvalidArgumentException
     * @covers phpDocumentor\Transformer\Writer\Collection::offsetSet
     */
    public function testOffsetSetWithWriterNotDescendingFromWriterAbstract()
    {
        $this->fixture->offsetSet('index', new \stdClass());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @expectedException \InvalidArgumentException
     * @covers phpDocumentor\Transformer\Writer\Collection::offsetSet
     */
    public function testOffsetSetWithInvalidIndexName()
    {
        $this->fixture->offsetSet('i', $this->writer);
    }

    /**
     * @covers phpDocumentor\Transformer\Writer\Collection::offsetSet
     */
    public function testOffsetSetWriterReceivesRouterQueue()
    {
        $this->writer->shouldReceive('setRouters')->once()->with($this->routers);
        $this->fixture->offsetSet('index', $this->writer);

        $this->assertTrue(true);
    }

    /**
     * @expectedException \InvalidArgumentException
     * @covers phpDocumentor\Transformer\Writer\Collection::offsetGet
     */
    public function testOffsetGetWithNonExistingIndex()
    {
        $this->fixture->offsetGet('nonExistingIndex');
    }

    /**
     * @covers phpDocumentor\Transformer\Writer\Collection::offsetGet
     */
    public function testOffsetGetWithExistingIndex()
    {
        $this->registerWriter();

        $this->assertSame($this->writer, $this->fixture->offsetGet('index'));
    }

    /**
     * @covers phpDocumentor\Transformer\Writer\Collection::checkRequirements
     */
    public function testCheckRequirements()
    {
        $this->registerWriter();

        $this->writer->shouldReceive('checkRequirements')->once();
        $this->fixture->checkRequirements();

        $this->assertTrue(true);
    }

    /**
     * Registers a writer for tests that need a collection item
     */
    private function registerWriter()
    {
        $this->writer->shouldReceive('setRouters')->with($this->routers);
        $this->fixture->offsetSet('index', $this->writer);
    }
}


1			<?php
2			/**
3			* phpDocumentor
4			*
5			* PHP Version 5.3
6			*
7			* @author Mike van Riel <[email protected]>
8			* @copyright 2010-2018 Mike van Riel / Naenius (http://www.naenius.com)
9			* @license http://www.opensource.org/licenses/mit-license.php MIT
10			* @link http://phpdoc.org
11			*/
12
13			namespace phpDocumentor\Transformer\Writer;
14
15			use Mockery as m;
16			use Mockery\MockInterface;
17			use phpDocumentor\Transformer\Writer\Xsl;
18			use phpDocumentor\Transformer\Router\Queue;
19
20			/**
21			* Test class for phpDocumentor\Transformer\Writer\Collection
22			*/
23			class CollectionTest extends \Mockery\Adapter\Phpunit\MockeryTestCase
24			{
25			/** @var MockInterface\|Queue */
26			protected $routers;
27
28			/** @var MockInterface\|Xsl */
29			protected $writer;
30
31			/** @var Collection */
32			protected $fixture;
33
34			/**
35			* Initializes the fixture and dependencies for this testcase.
36			*/
37			protected function setUp()
38			{
39			$this->routers = m::mock('phpDocumentor\Transformer\Router\Queue');
40			$this->writer = m::mock('phpDocumentor\Transformer\Writer\Xsl');
41			$this->fixture = new Collection($this->routers);
42			}
43
44			/**
45			* @covers phpDocumentor\Transformer\Writer\Collection::__construct
46			*/
47			public function testIfDependenciesAreCorrectlyRegisteredOnInitialization()
48			{
49			$this->assertAttributeSame($this->routers, 'routers', $this->fixture);
50			}
51
52			/**
53			* @expectedException \InvalidArgumentException
54			* @covers phpDocumentor\Transformer\Writer\Collection::offsetSet
55			*/
56			public function testOffsetSetWithWriterNotDescendingFromWriterAbstract()
57			{
58			$this->fixture->offsetSet('index', new \stdClass());
			0 ignored issues – show Documentation introduced 2015-12-02 21:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `new \stdClass()` is of type `object<stdClass>`, but the function expects a `object<phpDocumentor\Tra...\Writer\WriterAbstract>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
59			}
60
61			/**
62			* @expectedException \InvalidArgumentException
63			* @covers phpDocumentor\Transformer\Writer\Collection::offsetSet
64			*/
65			public function testOffsetSetWithInvalidIndexName()
66			{
67			$this->fixture->offsetSet('i', $this->writer);
68			}
69
70			/**
71			* @covers phpDocumentor\Transformer\Writer\Collection::offsetSet
72			*/
73			public function testOffsetSetWriterReceivesRouterQueue()
74			{
75			$this->writer->shouldReceive('setRouters')->once()->with($this->routers);
76			$this->fixture->offsetSet('index', $this->writer);
77
78			$this->assertTrue(true);
79			}
80
81			/**
82			* @expectedException \InvalidArgumentException
83			* @covers phpDocumentor\Transformer\Writer\Collection::offsetGet
84			*/
85			public function testOffsetGetWithNonExistingIndex()
86			{
87			$this->fixture->offsetGet('nonExistingIndex');
88			}
89
90			/**
91			* @covers phpDocumentor\Transformer\Writer\Collection::offsetGet
92			*/
93			public function testOffsetGetWithExistingIndex()
94			{
95			$this->registerWriter();
96
97			$this->assertSame($this->writer, $this->fixture->offsetGet('index'));
98			}
99
100			/**
101			* @covers phpDocumentor\Transformer\Writer\Collection::checkRequirements
102			*/
103			public function testCheckRequirements()
104			{
105			$this->registerWriter();
106
107			$this->writer->shouldReceive('checkRequirements')->once();
108			$this->fixture->checkRequirements();
109
110			$this->assertTrue(true);
111			}
112
113			/**
114			* Registers a writer for tests that need a collection item
115			*/
116			private function registerWriter()
117			{
118			$this->writer->shouldReceive('setRouters')->with($this->routers);
119			$this->fixture->offsetSet('index', $this->writer);
120			}
121			}
122

phpDocumentor / phpDocumentor

Push — develop ( 8eb671...133594 )

Transformer/Writer/CollectionTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like