Issues in Api.php - All Issues - Inspection of "Delete Scrybe" - phpDocumentor/phpDocumentor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 8eb671...133594 )

by Mike

created 2019-06-14 08:00 UTC

tests/features/assets/singlefile/tags/Api.php (5 issues)

Labels

Severity

Minor 5

Jaapio 5

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Class A
 *
 * @api
 */
class A
namespace YourVendor;

class YourClass { }
{
    /**
     * @api
     */
    public function someMethod()
    {
    }

    public function someOtherMethod()
    {
    }
}

class B extends A
namespace YourVendor;

class YourClass { }
{
}


1			<?php
2
3			/**
4			* Class A
5			*
6			* @api
7			*/
8			class A
			0 ignored issues – show Comprehensibility Best Practice introduced 2017-08-12 09:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this The type `A` has been defined more than once; this definition is ignored, only the first definition in `tests/features/assets/si...sicClassInheritance.php` (L10-19) is considered. This check looks for classes that have been defined more than once. If you can, we would recommend to use standard object-oriented programming techniques. For example, to avoid multiple types, it might make sense to create a common interface, and then multiple, different implementations for that interface. This also has the side-effect of providing you with better IDE auto-completion, static analysis and also better OPCode caching from PHP. Loading history... Coding Style Compatibility introduced 2017-08-12 09:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
9			{
10			/**
11			* @api
12			*/
13			public function someMethod()
14			{
15			}
16
17			public function someOtherMethod()
18			{
19			}
20			}
21
22			class B extends A
			0 ignored issues – show Comprehensibility Best Practice introduced 2017-08-12 09:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this The type `B` has been defined more than once; this definition is ignored, only the first definition in `tests/features/assets/si...sicClassInheritance.php` (L21-28) is considered. This check looks for classes that have been defined more than once. If you can, we would recommend to use standard object-oriented programming techniques. For example, to avoid multiple types, it might make sense to create a common interface, and then multiple, different implementations for that interface. This also has the side-effect of providing you with better IDE auto-completion, static analysis and also better OPCode caching from PHP. Loading history... Coding Style Compatibility introduced 2017-08-12 09:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2017-08-12 09:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
23			{
24			}
25

phpDocumentor / phpDocumentor

Push — develop ( 8eb671...133594 )

tests/features/assets/singlefile/tags/Api.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like