Completed
Push — develop ( 8eb671...133594 )
by Mike
19:30 queued 09:24
created

features/assets/singlefile/syntax/nullable.php (2 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
3
class A
0 ignored issues
show
Comprehensibility Best Practice introduced by
The type A has been defined more than once; this definition is ignored, only the first definition in tests/features/assets/si...sicClassInheritance.php (L10-19) is considered.

This check looks for classes that have been defined more than once.

If you can, we would recommend to use standard object-oriented programming techniques. For example, to avoid multiple types, it might make sense to create a common interface, and then multiple, different implementations for that interface.

This also has the side-effect of providing you with better IDE auto-completion, static analysis and also better OPCode caching from PHP.

Loading history...
4
{
5
    public function getId(): ?int
6
    {
7
        return $this->id;
0 ignored issues
show
The property id does not exist. Did you maybe forget to declare it?

In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:

class MyClass { }

$x = new MyClass();
$x->foo = true;

Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion:

class MyClass {
    public $foo;
}

$x = new MyClass();
$x->foo = true;
Loading history...
8
    }
9
}
10