Issues in XmlTest.php - All Issues - Inspection of "Restore setting target dir" - phpDocumentor/phpDocumentor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( a89061...54507c )

by Jaap

created 2018-06-17 18:08 UTC

Plugin/Core/Transformer/Writer/XmlTest.php (11 issues)

Labels

Severity

Frank van den Brink 11

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * phpDocumentor
 *
 * PHP Version 5.3
 *
 * @author    Mike van Riel <[email protected]>
 * @copyright 2010-2018 Mike van Riel / Naenius (http://www.naenius.com)
 * @license   http://www.opensource.org/licenses/mit-license.php MIT
 * @link      http://phpdoc.org
 */

namespace phpDocumentor\Plugin\Core\Transformer\Writer;

use Mockery as m;
use org\bovigo\vfs\vfsStream;

use org\bovigo\vfs\vfsStreamDirectory;
use phpDocumentor\Descriptor\ProjectDescriptor;
use phpDocumentor\Transformer\Router\RouterAbstract;
use phpDocumentor\Translator\Translator;

/**
 * Test class for \phpDocumentor\Plugin\Core\Transformer\Writer\Xml.
 *
 * @covers phpDocumentor\Plugin\Core\Transformer\Writer\Xml
 */
class XmlTest extends \Mockery\Adapter\Phpunit\MockeryTestCase
{
    /** @var Xml $xml */
    protected $xml;

    /** @var m\MockInterface|RouterAbstract */
    protected $routerMock;

    /** @var m\MockInterface|Translator */
    private $translator;

    /** @var m\MockInterface|ProjectDescriptor */
    protected $projectDescriptor;

    /** @var vfsStreamDirectory */
    protected $fs;

    /**
     * Sets up the test suite
     */
    protected function setUp()
    {
        $this->fs = vfsStream::setup('XmlTest');
        $this->translator = m::mock('phpDocumentor\Translator\Translator');
        $this->projectDescriptor = m::mock('phpDocumentor\Descriptor\ProjectDescriptor');
        $this->routerMock = m::mock('phpDocumentor\Transformer\Router\RouterAbstract');
        $this->xml = new Xml($this->routerMock);
        $this->xml->setTranslator($this->translator);
    }

    /**
     * @covers phpDocumentor\Plugin\Core\Transformer\Writer\Xml::transform
     */
    public function testTransformWithoutFiles()
    {
        $transformer = m::mock('phpDocumentor\Transformer\Transformer');
        $transformation = m::mock('phpDocumentor\Transformer\Transformation');
        $transformation->shouldReceive('getTransformer->getTarget')->andReturn(vfsStream::url('XmlTest'));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $transformation->shouldReceive('getArtifact')->andReturn('artifact.xml');
        $transformation->shouldReceive('getTransformer')->andReturn($transformer);

        $this->projectDescriptor->shouldReceive('getFiles')->andReturn([]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->projectDescriptor->shouldReceive('getName')->andReturn('project');
        $this->projectDescriptor->shouldReceive('getPartials')->andReturn([]);

        $this->implementProtectedFinalize($this->projectDescriptor);

        // Call the actual method
        $this->xml->transform($this->projectDescriptor, $transformation);

        // Check file exists
        $this->assertTrue($this->fs->hasChild('artifact.xml'));

        // Inspect XML
        $xml = <<<XML
<?xml version="1.0" encoding="utf-8"?>
<project version="2.0.0b8&#10;" title="project">
  <partials/>
  <package name="global" full_name="global"/>
  <deprecated count="0"/>
</project>
XML;
        $expectedXml = new \DOMDocument();
        $expectedXml->loadXML($xml);

        $actualXml = new \DOMDocument();
        $actualXml->load(vfsStream::url('XmlTest/artifact.xml'));

        $this->assertEqualXMLStructure($expectedXml->firstChild, $actualXml->firstChild, true);

    }

    /**
     * @covers phpDocumentor\Plugin\Core\Transformer\Writer\Xml::transform
     */
    public function testTransformWithEmptyFileDescriptor()
    {
        $transformer = m::mock('phpDocumentor\Transformer\Transformer');
        $transformer->shouldReceive('getTarget')->andReturn(vfsStream::url('XmlTest'));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $transformation = m::mock('phpDocumentor\Transformer\Transformation');
        $transformation->shouldReceive('getArtifact')->andReturn('artifact.xml');
        $transformation->shouldReceive('getTransformer')->andReturn($transformer);

        $fileDescriptor = m::mock('phpDocumentor\Descriptor\FileDescriptor');
        $fileDescriptor->shouldReceive('getPath')->andReturn('foo.php');
        $fileDescriptor->shouldReceive('getInheritedElement')->andReturn(null);
        $transformer->shouldReceive('generateFilename')->with('foo.php')->andReturn('generated-foo.php');
        $fileDescriptor->shouldReceive('getHash')->andReturn('hash');
        $fileDescriptor->shouldReceive('getAllErrors')->andReturn([]);

        $this->projectDescriptor->shouldReceive('getFiles')->andReturn([$fileDescriptor]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->projectDescriptor->shouldReceive('getName')->andReturn('project');
        $this->projectDescriptor->shouldReceive('getPartials')->andReturn([]);

        $this->implementProtectedFinalize($this->projectDescriptor);
        $this->implementProtectedBuildDocBlock($fileDescriptor);

        $fileDescriptor->shouldReceive('getNamespaceAliases')->andReturn(['foo', 'bar']);
        $fileDescriptor->shouldReceive('getConstants')->andReturn([]);
        $fileDescriptor->shouldReceive('getFunctions')->andReturn([]);
        $fileDescriptor->shouldReceive('getInterfaces')->andReturn([]);
        $fileDescriptor->shouldReceive('getClasses')->andReturn([]);
        $fileDescriptor->shouldReceive('getTraits')->andReturn([]);
        $fileDescriptor->shouldReceive('getMarkers')->andReturn([]);
        $fileDescriptor->shouldReceive('getErrors')->andReturn([]);
        $fileDescriptor->shouldReceive('getPartials')->andReturn([]);
        $fileDescriptor->shouldReceive('getSource')->andReturn(null);

        // Call the actual method
        $this->xml->transform($this->projectDescriptor, $transformation);

        // Check file exists
        $this->assertTrue($this->fs->hasChild('artifact.xml'));

        // Inspect XML
        $xml = <<<XML
<?xml version="1.0" encoding="utf-8"?>
<project version="2.0.0b8" title="project">
  <partials/>
  <file path="foo.php" generated-path="generated-foo.php" hash="hash" package="myPackage">
    <docblock line="666">
      <description>my summary</description>
      <long-description>my description</long-description>
    </docblock>
    <namespace-alias name="0">foo</namespace-alias>
    <namespace-alias name="1">bar</namespace-alias>
  </file>
  <package name="global" full_name="global"/>
  <package name="myPackage" full_name="myPackage"/>
  <deprecated count="0"/>
</project>
XML;
        $expectedXml = new \DOMDocument();
        $expectedXml->loadXML($xml);

        $actualXml = new \DOMDocument();
        $actualXml->load(vfsStream::url('XmlTest/artifact.xml'));

        $this->assertEqualXMLStructure($expectedXml->firstChild, $actualXml->firstChild, true);

    }

    /**
     * This implements testing of the protected finalize method.
     */
    protected function implementProtectedFinalize(ProjectDescriptor $projectDescriptor)

    {
        $this->projectDescriptor->shouldReceive('isVisibilityAllowed')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->with(ProjectDescriptor\Settings::VISIBILITY_INTERNAL)
            ->andReturn(true);
    }

    /**
     * This implements testing of the protected buildDocBlock method
     */
    protected function implementProtectedBuildDocBlock(m\MockInterface $descriptor)
    {
        $descriptor->shouldReceive('getLine')->andReturn(666);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $descriptor->shouldReceive('getPackage')->andReturn('myPackage');
        $descriptor->shouldReceive('getSummary')->andReturn('my summary');
        $descriptor->shouldReceive('getDescription')->andReturn('my description');
        $descriptor->shouldReceive('getTags')->andReturn([]);
    }
}


Push — develop ( a89061...54507c )

Plugin/Core/Transformer/Writer/XmlTest.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			/**
4			* phpDocumentor
5			*
6			* PHP Version 5.3
7			*
8			* @author Mike van Riel <[email protected]>
9			* @copyright 2010-2018 Mike van Riel / Naenius (http://www.naenius.com)
10			* @license http://www.opensource.org/licenses/mit-license.php MIT
11			* @link http://phpdoc.org
12			*/
13
14			namespace phpDocumentor\Plugin\Core\Transformer\Writer;
15
16			use Mockery as m;
17			use org\bovigo\vfs\vfsStream;
18
19			use org\bovigo\vfs\vfsStreamDirectory;
20			use phpDocumentor\Descriptor\ProjectDescriptor;
21			use phpDocumentor\Transformer\Router\RouterAbstract;
22			use phpDocumentor\Translator\Translator;
23
24			/**
25			* Test class for \phpDocumentor\Plugin\Core\Transformer\Writer\Xml.
26			*
27			* @covers phpDocumentor\Plugin\Core\Transformer\Writer\Xml
28			*/
29			class XmlTest extends \Mockery\Adapter\Phpunit\MockeryTestCase
30			{
31			/** @var Xml $xml */
32			protected $xml;
33
34			/** @var m\MockInterface\|RouterAbstract */
35			protected $routerMock;
36
37			/** @var m\MockInterface\|Translator */
38			private $translator;
39
40			/** @var m\MockInterface\|ProjectDescriptor */
41			protected $projectDescriptor;
42
43			/** @var vfsStreamDirectory */
44			protected $fs;
45
46			/**
47			* Sets up the test suite
48			*/
49			protected function setUp()
50			{
51			$this->fs = vfsStream::setup('XmlTest');
52			$this->translator = m::mock('phpDocumentor\Translator\Translator');
53			$this->projectDescriptor = m::mock('phpDocumentor\Descriptor\ProjectDescriptor');
54			$this->routerMock = m::mock('phpDocumentor\Transformer\Router\RouterAbstract');
55			$this->xml = new Xml($this->routerMock);
56			$this->xml->setTranslator($this->translator);
57			}
58
59			/**
60			* @covers phpDocumentor\Plugin\Core\Transformer\Writer\Xml::transform
61			*/
62			public function testTransformWithoutFiles()
63			{
64			$transformer = m::mock('phpDocumentor\Transformer\Transformer');
65			$transformation = m::mock('phpDocumentor\Transformer\Transformation');
66			$transformation->shouldReceive('getTransformer->getTarget')->andReturn(vfsStream::url('XmlTest'));
			0 ignored issues – show Bug introduced 2017-10-10 14:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `andReturn` does only exist in `Mockery\ExpectationInterface`, but not in `Mockery\HigherOrderMessage`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
67			$transformation->shouldReceive('getArtifact')->andReturn('artifact.xml');
68			$transformation->shouldReceive('getTransformer')->andReturn($transformer);
69
70			$this->projectDescriptor->shouldReceive('getFiles')->andReturn([]);
			0 ignored issues – show Bug introduced 2016-10-31 17:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `shouldReceive` does only exist in `Mockery\MockInterface`, but not in `phpDocumentor\Descriptor\ProjectDescriptor`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
71			$this->projectDescriptor->shouldReceive('getName')->andReturn('project');
72			$this->projectDescriptor->shouldReceive('getPartials')->andReturn([]);
73
74			$this->implementProtectedFinalize($this->projectDescriptor);
75
76			// Call the actual method
77			$this->xml->transform($this->projectDescriptor, $transformation);
78
79			// Check file exists
80			$this->assertTrue($this->fs->hasChild('artifact.xml'));
81
82			// Inspect XML
83			$xml = <<<XML
84			<?xml version="1.0" encoding="utf-8"?>
85			<project version="2.0.0b8 " title="project">
86			<partials/>
87			<package name="global" full_name="global"/>
88			<deprecated count="0"/>
89			</project>
90			XML;
91			$expectedXml = new \DOMDocument();
92			$expectedXml->loadXML($xml);
93
94			$actualXml = new \DOMDocument();
95			$actualXml->load(vfsStream::url('XmlTest/artifact.xml'));
96
97			$this->assertEqualXMLStructure($expectedXml->firstChild, $actualXml->firstChild, true);
			0 ignored issues – show Compatibility introduced 2017-10-10 14:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$expectedXml->firstChild` of type `object<DOMNode>` is not a sub-type of `object<DOMElement>`. It seems like you assume a child class of the class `DOMNode` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history... Compatibility introduced 2017-10-10 14:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$actualXml->firstChild` of type `object<DOMNode>` is not a sub-type of `object<DOMElement>`. It seems like you assume a child class of the class `DOMNode` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
98			}
99
100			/**
101			* @covers phpDocumentor\Plugin\Core\Transformer\Writer\Xml::transform
102			*/
103			public function testTransformWithEmptyFileDescriptor()
104			{
105			$transformer = m::mock('phpDocumentor\Transformer\Transformer');
106			$transformer->shouldReceive('getTarget')->andReturn(vfsStream::url('XmlTest'));
			0 ignored issues – show Bug introduced 2017-10-10 14:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `andReturn` does only exist in `Mockery\ExpectationInterface`, but not in `Mockery\HigherOrderMessage`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
107
108			$transformation = m::mock('phpDocumentor\Transformer\Transformation');
109			$transformation->shouldReceive('getArtifact')->andReturn('artifact.xml');
110			$transformation->shouldReceive('getTransformer')->andReturn($transformer);
111
112			$fileDescriptor = m::mock('phpDocumentor\Descriptor\FileDescriptor');
113			$fileDescriptor->shouldReceive('getPath')->andReturn('foo.php');
114			$fileDescriptor->shouldReceive('getInheritedElement')->andReturn(null);
115			$transformer->shouldReceive('generateFilename')->with('foo.php')->andReturn('generated-foo.php');
116			$fileDescriptor->shouldReceive('getHash')->andReturn('hash');
117			$fileDescriptor->shouldReceive('getAllErrors')->andReturn([]);
118
119			$this->projectDescriptor->shouldReceive('getFiles')->andReturn([$fileDescriptor]);
			0 ignored issues – show Bug introduced 2016-10-31 17:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `shouldReceive` does only exist in `Mockery\MockInterface`, but not in `phpDocumentor\Descriptor\ProjectDescriptor`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
120			$this->projectDescriptor->shouldReceive('getName')->andReturn('project');
121			$this->projectDescriptor->shouldReceive('getPartials')->andReturn([]);
122
123			$this->implementProtectedFinalize($this->projectDescriptor);
124			$this->implementProtectedBuildDocBlock($fileDescriptor);
125
126			$fileDescriptor->shouldReceive('getNamespaceAliases')->andReturn(['foo', 'bar']);
127			$fileDescriptor->shouldReceive('getConstants')->andReturn([]);
128			$fileDescriptor->shouldReceive('getFunctions')->andReturn([]);
129			$fileDescriptor->shouldReceive('getInterfaces')->andReturn([]);
130			$fileDescriptor->shouldReceive('getClasses')->andReturn([]);
131			$fileDescriptor->shouldReceive('getTraits')->andReturn([]);
132			$fileDescriptor->shouldReceive('getMarkers')->andReturn([]);
133			$fileDescriptor->shouldReceive('getErrors')->andReturn([]);
134			$fileDescriptor->shouldReceive('getPartials')->andReturn([]);
135			$fileDescriptor->shouldReceive('getSource')->andReturn(null);
136
137			// Call the actual method
138			$this->xml->transform($this->projectDescriptor, $transformation);
139
140			// Check file exists
141			$this->assertTrue($this->fs->hasChild('artifact.xml'));
142
143			// Inspect XML
144			$xml = <<<XML
145			<?xml version="1.0" encoding="utf-8"?>
146			<project version="2.0.0b8" title="project">
147			<partials/>
148			<file path="foo.php" generated-path="generated-foo.php" hash="hash" package="myPackage">
149			<docblock line="666">
150			<description>my summary</description>
151			<long-description>my description</long-description>
152			</docblock>
153			<namespace-alias name="0">foo</namespace-alias>
154			<namespace-alias name="1">bar</namespace-alias>
155			</file>
156			<package name="global" full_name="global"/>
157			<package name="myPackage" full_name="myPackage"/>
158			<deprecated count="0"/>
159			</project>
160			XML;
161			$expectedXml = new \DOMDocument();
162			$expectedXml->loadXML($xml);
163
164			$actualXml = new \DOMDocument();
165			$actualXml->load(vfsStream::url('XmlTest/artifact.xml'));
166
167			$this->assertEqualXMLStructure($expectedXml->firstChild, $actualXml->firstChild, true);
			0 ignored issues – show Compatibility introduced 2017-10-10 14:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$expectedXml->firstChild` of type `object<DOMNode>` is not a sub-type of `object<DOMElement>`. It seems like you assume a child class of the class `DOMNode` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history... Compatibility introduced 2017-10-10 14:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$actualXml->firstChild` of type `object<DOMNode>` is not a sub-type of `object<DOMElement>`. It seems like you assume a child class of the class `DOMNode` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
168			}
169
170			/**
171			* This implements testing of the protected finalize method.
172			*/
173			protected function implementProtectedFinalize(ProjectDescriptor $projectDescriptor)
			0 ignored issues – show Unused Code introduced 2017-08-12 09:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$projectDescriptor` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
174			{
175			$this->projectDescriptor->shouldReceive('isVisibilityAllowed')
			0 ignored issues – show Bug introduced 2016-10-31 17:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `shouldReceive` does only exist in `Mockery\MockInterface`, but not in `phpDocumentor\Descriptor\ProjectDescriptor`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
176			->with(ProjectDescriptor\Settings::VISIBILITY_INTERNAL)
177			->andReturn(true);
178			}
179
180			/**
181			* This implements testing of the protected buildDocBlock method
182			*/
183			protected function implementProtectedBuildDocBlock(m\MockInterface $descriptor)
184			{
185			$descriptor->shouldReceive('getLine')->andReturn(666);
			0 ignored issues – show Bug introduced 2017-12-26 19:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `andReturn` does only exist in `Mockery\ExpectationInterface`, but not in `Mockery\HigherOrderMessage`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
186			$descriptor->shouldReceive('getPackage')->andReturn('myPackage');
187			$descriptor->shouldReceive('getSummary')->andReturn('my summary');
188			$descriptor->shouldReceive('getDescription')->andReturn('my description');
189			$descriptor->shouldReceive('getTags')->andReturn([]);
190			}
191			}
192

phpDocumentor / phpDocumentor

Push — develop ( a89061...54507c )

Plugin/Core/Transformer/Writer/XmlTest.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like