phpDocumentor / phpDocumentor

src/phpDocumentor/Application/Configuration/ConfigurationFactory.php

<?php
/**
 * This file is part of phpDocumentor.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @copyright 2010-2015 Mike van Riel<mike@phpdoc.org>
 * @license   http://www.opensource.org/licenses/mit-license.php MIT
 * @link      http://phpdoc.org
 */

namespace phpDocumentor\Application\Configuration;

use phpDocumentor\Application\Configuration\Factory\Strategy;
use phpDocumentor\Application\Configuration\Factory\Version3;
use phpDocumentor\DomainModel\Uri;

/**
 * The ConfigurationFactory converts the configuration xml from a Uri into an array.
 */
final class ConfigurationFactory
{
    /** @var Uri The Uri that contains the path to the configuration file. */
    private $uri;

    /** @var string[] The cached configuration as an array so that we improve performance */
    private $cachedConfiguration = [];

    /** @var Strategy[] All strategies that are used by the ConfigurationFactory. */
    private $strategies = [];

    /**
     * A series of callables that take the configuration array as parameter and should return that array or a modified
     * version of it.
     *
     * @var callable[]
     */
    private $middlewares = [];

    /**
     * Initializes the ConfigurationFactory.
     *
     * @param Strategy[] $strategies
     * @param callable[] $middlewares
     */
    public function __construct(array $strategies, Uri $uri, array $middlewares = [])
    {
        foreach ($strategies as $strategy) {
            $this->registerStrategy($strategy);
        }

        $this->replaceLocation($uri);
        $this->middlewares = $middlewares;
    }

    public static function createInstance(iterable $strategiesBuilder): self
    {
        $strategies = [];

        foreach ($strategiesBuilder as $stategy) {
            $strategies[] = $stategy;
        }

        return new static($strategies, new Uri('file://' . getcwd() . '/phpdoc.dist.xml'));
    }

    /**
     * Adds a middleware callback that allows the consumer to alter the configuration array when it is constructed.
     *
     * @param callable $middleware
     */
    public function addMiddleware(callable $middleware)
    {
        $this->middlewares[] = $middleware;

        // Middleware's changed; we must rebuild the cache
        $this->clearCache();
    }

    /**
     * Replaces the location of the configuration file if it differs from the existing one.
     */
    public function replaceLocation(Uri $uri)
    {
        if (!isset($this->uri) || !$this->uri->equals($uri)) {
            $this->uri = $uri;
            $this->clearCache();
        }
    }

    /**
     * Converts the phpDocumentor configuration xml to an array.
     *
     * @return array
     *
     * @throws \RuntimeException if no matching strategy can be found.
     */
    public function get()
    {
        if ($this->cachedConfiguration) {

The expression $this->cachedConfiguration of type string[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $this->cachedConfiguration;
        }

        if (file_exists($this->uri)) {
            $xml = new \SimpleXMLElement($this->uri, 0, true);
            $this->cachedConfiguration = $this->extractConfigurationArray($xml);
        } else {
            $this->cachedConfiguration = Version3::buildDefault();

It seems like \phpDocumentor\Application\Configuration\Factory\Version3::buildDefault() of type array<string,array<string,string|boolean|array,{"title":"string","use-cache":"boolean","paths":"array<string,object<phpDocumentor\\DomainModel\\Dsn>|object<phpDocumentor\\DomainModel\\Path>,{\"output\":\"object<phpDocumentor\\\\DomainModel\\\\Dsn>\",\"cache\":\"object<phpDocumentor\\\\DomainModel\\\\Path>\"}>","versions":"array","templates":"array<integer,array,{\"0\":\"array\"}>"}>,{"phpdocumentor":"array<string,string|boolean|array,{\"title\":\"string\",\"use-cache\":\"boolean\",\"paths\":\"array<string,object<phpDocumentor\\\\DomainModel\\\\Dsn>|object<phpDocumentor\\\\DomainModel\\\\Path>,{\\\"output\\\":\\\"object<phpDocumentor\\\\\\\\DomainModel\\\\\\\\Dsn>\\\",\\\"cache\\\":\\\"object<phpDocumentor\\\\\\\\DomainModel\\\\\\\\Path>\\\"}>\",\"versions\":\"array\",\"templates\":\"array<integer,array,{\\\"0\\\":\\\"array\\\"}>\"}>"}> is incompatible with the declared type array<integer,string> of property $cachedConfiguration.

        }

        $this->applyMiddleware();

        return $this->cachedConfiguration;
    }

    /**
     * Clears the cache for the configuration.
     */
    public function clearCache()
    {
        return $this->cachedConfiguration = null;

It seems like null of type null is incompatible with the declared type array<integer,string> of property $cachedConfiguration.

    }

    /**
     * Adds strategies that are used in the ConfigurationFactory.
     */
    private function registerStrategy(Strategy $strategy)
    {
        $this->strategies[] = $strategy;
    }

    /**
     * Converts the given XML structure into an array containing the configuration.
     *
     * @param \SimpleXMLElement $xml
     *
     * @return array
     */
    private function extractConfigurationArray($xml)
    {
        foreach ($this->strategies as $strategy) {
            if ($strategy->match($xml) === true) {
                return $strategy->convert($xml);
            }
        }

        throw new \RuntimeException('No strategy found that matches the configuration xml');
    }

    /**
     * Applies all middleware callbacks onto the configuration.
     */
    private function applyMiddleware()
    {
        foreach ($this->middlewares as $middleware) {
            $this->cachedConfiguration = $middleware($this->cachedConfiguration);
        }
    }
}