phpDocumentor / phpDocumentor

src/phpDocumentor/Command/Phar/UpdateCommand.php

<?php
/**
 * phpDocumentor
 *
 * PHP Version 5.3
 *
 * @copyright 2010-2014 Mike van Riel / Naenius (http://www.naenius.com)
 * @license   http://www.opensource.org/licenses/mit-license.php MIT
 * @link      http://phpdoc.org
 */

namespace phpDocumentor\Command\Phar;

use Herrera\Json\Exception\FileException;
use Herrera\Phar\Update\Manager;
use Herrera\Phar\Update\Manifest;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Input\InputArgument;

/**
 * Updates phpDocumentor.phar to the latest version.
 *
 * ```
 * $ php phpDocumentor.phar phar:update [-m|--major] [-p|--pre] [version]
 * ```
 */
class UpdateCommand extends Command
{
    const MANIFEST_FILE = 'http://www.phpdoc.org/get/manifest.json';

    /**
     * Initializes this command and sets the name, description, options and arguments.
     *
     * @return void
     */
    protected function configure()
    {
        $this->setName('phar:update')
            ->setAliases(array('selfupdate', 'self-update'))
            ->setDescription('Updates phpDocumentor.phar to the indicated version or the latest if none is specified')
            ->addArgument(
                'version',
                InputArgument::OPTIONAL,
                'Updates to version-number (i.e. 2.6.0). When omitted phpDocumentor will update to the latest version'
            )
            ->addOption('major', 'm', InputOption::VALUE_NONE, 'Lock to current major version')
            ->addOption('pre', 'p', InputOption::VALUE_NONE, 'Allow pre-release version update');
    }

    /**
     * Executes the business logic involved with this command.
     *
     * @param \Symfony\Component\Console\Input\InputInterface $input
     * @param \Symfony\Component\Console\Output\OutputInterface $output
     *
     * @return int
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $output->writeln('Looking for updates...');

        $manager         = $this->createManager($output);
        $version         = $input->getArgument('version')
            ? $input->getArgument('version')
            : $this->getApplication()->getVersion();
        $allowMajor      = $input->getOption('major');
        $allowPreRelease = $input->getOption('pre');

        if (strpos($version, 'v') === 0) {
            // strip v tag from phar version for self-update
            $version = str_replace('v', '', $version);
        }

        $this->updateCurrentVersion($manager, $version, $allowMajor, $allowPreRelease, $output);

It seems like $manager defined by $this->createManager($output) on line 65 can be null; however, phpDocumentor\Command\Phar\UpdateCommand::updateCurrentVersion() does not accept null, maybe add an additional type check?

        return 0;
    }

    /**
     * Returns manager instance or exit with status code 1 on failure.
     *
     * @param OutputInterface $output
     *
     * @return \Herrera\Phar\Update\Manager
     */
    private function createManager(OutputInterface $output)
    {
        try {
            return new Manager(Manifest::loadFile(self::MANIFEST_FILE));
        } catch (FileException $e) {
            $output->writeln('<error>Unable to search for updates.</error>');

            exit(1);

The method createManager() contains an exit expression.

        }
    }

    /**
     * Updates current version.
     *
     * @param Manager         $manager
     * @param string          $version
     * @param bool|null       $allowMajor
     * @param bool|null       $allowPreRelease
     * @param OutputInterface $output
     *
     * @return void
     */
    private function updateCurrentVersion(
        Manager $manager,
        $version,
        $allowMajor,
        $allowPreRelease,
        OutputInterface $output
    ) {
        if ($manager->update($version, $allowMajor, $allowPreRelease)) {

It seems like $allowMajor defined by parameter $allowMajor on line 114 can also be of type null; however, Herrera\Phar\Update\Manager::update() does only seem to accept boolean, maybe add an additional type check?

It seems like $allowPreRelease defined by parameter $allowPreRelease on line 115 can also be of type null; however, Herrera\Phar\Update\Manager::update() does only seem to accept boolean, maybe add an additional type check?

            $output->writeln('<info>Updated to latest version.</info>');
        } else {
            $output->writeln('<comment>Already up-to-date.</comment>');
        }
    }
}