Issues in ParseCommandTest.php - New Issues - Inspection of "Merge pull request #1932 from jaapio/feature/v3-co..." - phpDocumentor/phpDocumentor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 8fda15...dbbcf5 )

by Jaap

created 2018-04-29 17:43 UTC

Console/Command/Project/ParseCommandTest.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * This file is part of phpDocumentor.
 *
 *  For the full copyright and license information, please view the LICENSE
 *  file that was distributed with this source code.
 *
 *  @copyright 2010-2018 Mike van Riel<[email protected]>
 *  @license   http://www.opensource.org/licenses/mit-license.php MIT
 *  @link      http://phpdoc.org
 */

namespace phpDocumentor\Application\Console\Command\Project;

use \Mockery as m;
use League\Pipeline\PipelineInterface;
use Mockery\Adapter\Phpunit\MockeryTestCase;
use phpDocumentor\Descriptor\ProjectDescriptor;
use phpDocumentor\Descriptor\ProjectDescriptorBuilder;
use phpDocumentor\Parser\Parser;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Tests\Fixtures\DummyOutput;
use Zend\Cache\Storage\Adapter\Memory;
use Zend\I18n\Translator\Translator;

/**
 * @coversDefaultClass phpDocumentor\Application\Console\Command\Project\ParseCommand
 * @covers ::<protected>
 */
class ParseCommandTest extends MockeryTestCase
{
    /**
     * Tests the processing of target directory when non is provided.
     * @covers ::execute
     */
    public function testDefaultTargetDirCreation()
    {
        $this->markTestIncomplete('Needs to be updated, to new command');
        $input = new ArrayInput([]);
        $output = new DummyOutput();

        $cache = m::mock(Memory::class);
        $cache->shouldReceive('getOptions->setCacheDir')->with(m::type('string'));
        $cache->shouldReceive('getOptions->getCacheDir')->andReturn(sys_get_temp_dir());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $cache->shouldReceive('getOptions->getReadable')->andReturn(true);
        $cache->shouldReceive('getOptions->getWritable')->andReturn(true);
        $cache->shouldReceive('getOptions->getKeyPattern')->andReturn('/.+/');
        $cache->shouldReceive('getOptions->getNamespace')->andReturn('PhpDoc\\Cache');
        $cache->shouldDeferMissing();

        $translator = m::mock(Translator::class);
        $translator->shouldReceive('translate')
            ->zeroOrMoreTimes();

        $parser = m::mock(Parser::class);
        $parser->shouldReceive(
            'setForced',
            'setEncoding',
            'setMarkers',
            'setIgnoredTags',
            'setValidate',
            'setDefaultPackageName',
            'setPath',
            'parse'
        );

        $projectDescriptorBuilder = m::mock(ProjectDescriptorBuilder::class);
        $projectDescriptorBuilder->shouldReceive('createProjectDescriptor', 'getProjectDescriptor')
            ->andReturn(new ProjectDescriptor('test'));

        $command = new ParseCommand(
            m::mock(PipelineInterface::class),
            m::mock(\phpDocumentor\Translator\Translator::class)
        );

        $command->run($input, $output);
    }
}


Push — develop ( 8fda15...dbbcf5 )

Console/Command/Project/ParseCommandTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

1			<?php
2			/**
3			* This file is part of phpDocumentor.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*
8			* @copyright 2010-2018 Mike van Riel<[email protected]>
9			* @license http://www.opensource.org/licenses/mit-license.php MIT
10			* @link http://phpdoc.org
11			*/
12
13			namespace phpDocumentor\Application\Console\Command\Project;
14
15			use \Mockery as m;
16			use League\Pipeline\PipelineInterface;
17			use Mockery\Adapter\Phpunit\MockeryTestCase;
18			use phpDocumentor\Descriptor\ProjectDescriptor;
19			use phpDocumentor\Descriptor\ProjectDescriptorBuilder;
20			use phpDocumentor\Parser\Parser;
21			use Symfony\Component\Console\Input\ArrayInput;
22			use Symfony\Component\Console\Tests\Fixtures\DummyOutput;
23			use Zend\Cache\Storage\Adapter\Memory;
24			use Zend\I18n\Translator\Translator;
25
26			/**
27			* @coversDefaultClass phpDocumentor\Application\Console\Command\Project\ParseCommand
28			* @covers ::<protected>
29			*/
30			class ParseCommandTest extends MockeryTestCase
31			{
32			/**
33			* Tests the processing of target directory when non is provided.
34			* @covers ::execute
35			*/
36			public function testDefaultTargetDirCreation()
37			{
38			$this->markTestIncomplete('Needs to be updated, to new command');
39			$input = new ArrayInput([]);
40			$output = new DummyOutput();
41
42			$cache = m::mock(Memory::class);
43			$cache->shouldReceive('getOptions->setCacheDir')->with(m::type('string'));
44			$cache->shouldReceive('getOptions->getCacheDir')->andReturn(sys_get_temp_dir());
			0 ignored issues – show Bug introduced 2018-04-29 12:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `andReturn` does only exist in `Mockery\ExpectationInterface`, but not in `Mockery\HigherOrderMessage`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
45			$cache->shouldReceive('getOptions->getReadable')->andReturn(true);
46			$cache->shouldReceive('getOptions->getWritable')->andReturn(true);
47			$cache->shouldReceive('getOptions->getKeyPattern')->andReturn('/.+/');
48			$cache->shouldReceive('getOptions->getNamespace')->andReturn('PhpDoc\\Cache');
49			$cache->shouldDeferMissing();
50
51			$translator = m::mock(Translator::class);
52			$translator->shouldReceive('translate')
53			->zeroOrMoreTimes();
54
55			$parser = m::mock(Parser::class);
56			$parser->shouldReceive(
57			'setForced',
58			'setEncoding',
59			'setMarkers',
60			'setIgnoredTags',
61			'setValidate',
62			'setDefaultPackageName',
63			'setPath',
64			'parse'
65			);
66
67			$projectDescriptorBuilder = m::mock(ProjectDescriptorBuilder::class);
68			$projectDescriptorBuilder->shouldReceive('createProjectDescriptor', 'getProjectDescriptor')
69			->andReturn(new ProjectDescriptor('test'));
70
71			$command = new ParseCommand(
72			m::mock(PipelineInterface::class),
73			m::mock(\phpDocumentor\Translator\Translator::class)
74			);
75
76			$command->run($input, $output);
77			}
78			}
79

phpDocumentor / phpDocumentor

Push — develop ( 8fda15...dbbcf5 )

Console/Command/Project/ParseCommandTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like