phpDocumentor\Reflection\Php\Factory\AbstractFactory

Complexity

Total Complexity

6

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
	matches()	0	1	?
A	create()	0	13	3
	doCreate()	0	1	?
A	createMember()	0	5	1
A	createDocBlock()	0	8	2

<?php

namespace phpDocumentor\Reflection\Php\Factory;

use phpDocumentor\Reflection\Element;
use phpDocumentor\Reflection\Php\ProjectFactoryStrategy;
use phpDocumentor\Reflection\Php\StrategyContainer;
use phpDocumentor\Reflection\Types\Context;
use PhpParser\Comment\Doc;
use PhpParser\Node;

abstract class AbstractFactory implements ProjectFactoryStrategy
{
    abstract public function matches($object);

    public final function create($object, StrategyContainer $strategies, Context $context = null)

As per PSR2, final should precede the visibility keyword.

    {
        if (! $this->matches($object)) {
            throw new \InvalidArgumentException(
                sprintf('%s cannot handle objects with the type %s',
                    __CLASS__,
                    is_object($object) ? get_class($object) : gettype($object)
                )
            );
        }

        return $this->doCreate($object, $strategies, $context);
    }

    abstract protected function doCreate($object, StrategyContainer $strategies, Context $context = null);

    /**
     * @param Node|PropertyIterator|ClassConstantIterator $stmt
     * @param StrategyContainer $strategies
     * @param Context $context
     * @return Element
     */
    protected function createMember($stmt, StrategyContainer $strategies, Context $context = null)
    {
        $strategy = $strategies->findMatching($stmt);
        return $strategy->create($stmt, $strategies, $context);
    }

    /**
     * @param Doc $docBlock
     * @param StrategyContainer $strategies
     * @param Context $context
     * @return null|\phpDocumentor\Reflection\DocBlock
     */
    protected function createDocBlock(Doc $docBlock = null, StrategyContainer $strategies, Context $context = null)

Parameters which have default values should be placed at the end.

    {
        if ($docBlock === null) {
            return null;
        }

        return $this->createMember($docBlock, $strategies, $context);

$docBlock is of type object<PhpParser\Comment\Doc>, but the function expects a object<PhpParser\Node>|object<phpDocumentor\Reflection\Php\Factory\PropertyIterator>|object<phpDocumentor\Reflection\Php\Factory\ClassConstantIterator>.

    }
}