Interface_::doCreate() - Code Metrics - Inspection of "[WIP] Moved generic parts to an abstract factory" - phpDocumentor/Reflection - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#91)

by Jaap

created 2016-01-07 20:04 UTC

Interface_::doCreate() C

↳ Parent: Interface_

Complexity

Conditions	7
Paths	4

Size

Total Lines	30
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	24
CRAP Score	7.0031

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	30
ccs	24
cts	25
cp	0.96
rs	6.7273
nc	4
cc	7
eloc	20
nop	3
crap	7.0031

<?php
/**
 * This file is part of phpDocumentor.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @copyright 2010-2015 Mike van Riel<[email protected]>
 * @license   http://www.opensource.org/licenses/mit-license.php MIT
 * @link      http://phpdoc.org
 */


namespace phpDocumentor\Reflection\Php\Factory;
use InvalidArgumentException;
use phpDocumentor\Reflection\Element;
use phpDocumentor\Reflection\Fqsen;
use phpDocumentor\Reflection\Php\ProjectFactoryStrategy;
use phpDocumentor\Reflection\Php\StrategyContainer;
use phpDocumentor\Reflection\Types\Context;
use PhpParser\Comment\Doc;
use PhpParser\Node;
use PhpParser\Node\Stmt\ClassConst;
use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Interface_ as InterfaceNode;
use phpDocumentor\Reflection\Php\Interface_ as InterfaceElement;

/**
 * Strategy to create a InterfaceElement including all sub elements.
 */
final class Interface_ extends AbstractFactory implements ProjectFactoryStrategy

{

    /**
     * Returns true when the strategy is able to handle the object.
     *
     * @param InterfaceNode $object object to check.
     * @return boolean
     */
    public function matches($object)
    {
        return $object instanceof InterfaceNode;
    }

    /**
     * Creates an Interface_ out of the given object.
     * Since an object might contain other objects that need to be converted the $factory is passed so it can be
     * used to create nested Elements.
     *
     * @param InterfaceNode $object object to convert to an Element
     * @param StrategyContainer $strategies used to convert nested objects.
     * @param Context $context of the created object
     * @return InterfaceElement
     */
    protected function doCreate($object, StrategyContainer $strategies, Context $context = null)
    {
        $docBlock = $this->createDocBlock($object->getDocComment(), $strategies, $context);
        $parents = array();
        foreach ($object->extends as $extend) {
            $parents['\\' . (string)$extend] = new Fqsen('\\' . (string)$extend);
        }

        $interface = new InterfaceElement($object->fqsen, $parents, $docBlock);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        if (isset($object->stmts)) {
            foreach ($object->stmts as $stmt) {
                switch (get_class($stmt)) {
                    case ClassMethod::class:
                        $method = $this->createMember($stmt, $strategies, $context);
                        $interface->addMethod($method);

                        break;
                    case ClassConst::class:
                        $constants = new ClassConstantIterator($stmt);

                        foreach ($constants as $const) {
                            $element = $this->createMember($const, $strategies, $context);
                            $interface->addConstant($element);

                        }
                        break;
                }
            }
        }

        return $interface;
    }
}


1		<?php
2		/**
3		* This file is part of phpDocumentor.
4		*
5		* For the full copyright and license information, please view the LICENSE
6		* file that was distributed with this source code.
7		*
8		* @copyright 2010-2015 Mike van Riel<[email protected]>
9		* @license http://www.opensource.org/licenses/mit-license.php MIT
10		* @link http://phpdoc.org
11		*/
12
13
14		namespace phpDocumentor\Reflection\Php\Factory;
15		use InvalidArgumentException;
16		use phpDocumentor\Reflection\Element;
17		use phpDocumentor\Reflection\Fqsen;
18		use phpDocumentor\Reflection\Php\ProjectFactoryStrategy;
19		use phpDocumentor\Reflection\Php\StrategyContainer;
20		use phpDocumentor\Reflection\Types\Context;
21		use PhpParser\Comment\Doc;
22		use PhpParser\Node;
23		use PhpParser\Node\Stmt\ClassConst;
24		use PhpParser\Node\Stmt\ClassMethod;
25		use PhpParser\Node\Stmt\Interface_ as InterfaceNode;
26		use phpDocumentor\Reflection\Php\Interface_ as InterfaceElement;
27
28		/**
29		* Strategy to create a InterfaceElement including all sub elements.
30		*/
31		final class Interface_ extends AbstractFactory implements ProjectFactoryStrategy
		0 ignored issues – show Coding Style introduced 2015-11-23 21:15 UTC by Report Bug Copy Issue Report This class is not in CamelCase format. Classes in PHP are usually named in CamelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. The whole name starts with a capital letter as well. Thus the name database provider becomes `DatabaseProvider`. Loading history...
32		{
33
34		/**
35		* Returns true when the strategy is able to handle the object.
36		*
37		* @param InterfaceNode $object object to check.
38		* @return boolean
39		*/
40	1	public function matches($object)
41		{
42	1	return $object instanceof InterfaceNode;
43		}
44
45		/**
46		* Creates an Interface_ out of the given object.
47		* Since an object might contain other objects that need to be converted the $factory is passed so it can be
48		* used to create nested Elements.
49		*
50		* @param InterfaceNode $object object to convert to an Element
51		* @param StrategyContainer $strategies used to convert nested objects.
52		* @param Context $context of the created object
53		* @return InterfaceElement
54		*/
55	4	protected function doCreate($object, StrategyContainer $strategies, Context $context = null)
56		{
57	4	$docBlock = $this->createDocBlock($object->getDocComment(), $strategies, $context);
58	4	$parents = array();
59	4	foreach ($object->extends as $extend) {
60		$parents['\\' . (string)$extend] = new Fqsen('\\' . (string)$extend);
61	4	}
62
63	4	$interface = new InterfaceElement($object->fqsen, $parents, $docBlock);
		0 ignored issues – show Bug introduced 2015-11-23 21:15 UTC by Report Bug Copy Issue Report The property `fqsen` does not seem to exist in `PhpParser\Node\Stmt\Interface_`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history... Bug introduced 2016-01-07 20:06 UTC by Report Bug Copy Issue Report It seems like `$docBlock` defined by `$this->createDocBlock($o... $strategies, $context)` on line `57` can also be of type `object<phpDocumentor\Reflection\Element>`; however, `phpDocumentor\Reflection...terface_::__construct()` does only seem to accept `null\|object<phpDocumentor\Reflection\DocBlock>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
64
65	4	if (isset($object->stmts)) {
66	2	foreach ($object->stmts as $stmt) {
67	2	switch (get_class($stmt)) {
68	2	case ClassMethod::class:
69	1	$method = $this->createMember($stmt, $strategies, $context);
70	1	$interface->addMethod($method);
		0 ignored issues – show Compatibility introduced 2015-11-23 21:15 UTC by Report Bug Copy Issue Report `$method` of type `object<phpDocumentor\Reflection\Element>` is not a sub-type of `object<phpDocumentor\Reflection\Php\Method>`. It seems like you assume a concrete implementation of the interface `phpDocumentor\Reflection\Element` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
71	1	break;
72	1	case ClassConst::class:
73	1	$constants = new ClassConstantIterator($stmt);
		0 ignored issues – show Compatibility introduced 2015-11-23 21:15 UTC by Report Bug Copy Issue Report `$stmt` of type `object<PhpParser\Node>` is not a sub-type of `object<PhpParser\Node\Stmt\ClassConst>`. It seems like you assume a concrete implementation of the interface `PhpParser\Node` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
74	1	foreach ($constants as $const) {
75	1	$element = $this->createMember($const, $strategies, $context);
76	1	$interface->addConstant($element);
		0 ignored issues – show Compatibility introduced 2015-11-23 21:15 UTC by Report Bug Copy Issue Report `$element` of type `object<phpDocumentor\Reflection\Element>` is not a sub-type of `object<phpDocumentor\Reflection\Php\Constant>`. It seems like you assume a concrete implementation of the interface `phpDocumentor\Reflection\Element` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
77	1	}
78	1	break;
79	2	}
80	2	}
81	2	}
82
83	4	return $interface;
84		}
85		}
86

phpDocumentor / Reflection

Pull Request — develop (#91)

Interface_::doCreate() C

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like