Interface_::doCreate() - Code Metrics - Inspection of "add more typing" - phpDocumentor/Reflection - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#127)

by Chuck

created 2018-06-15 19:52 UTC

Interface_::doCreate() C

↳ Parent: Interface_

Complexity

Conditions	7
Paths	4

Size

Total Lines	30
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	7.0061

Importance

Changes

Metric	Value
cc	7
eloc	20
nc	4
nop	3
dl	0
loc	30
ccs	19
cts	20
cp	0.95
crap	7.0061
rs	6.7272
c	0
b	0
f	0

<?php
declare(strict_types=1);

/**
 * This file is part of phpDocumentor.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @copyright 2010-2018 Mike van Riel<[email protected]>
 * @license   http://www.opensource.org/licenses/mit-license.php MIT
 * @link      http://phpdoc.org
 */

namespace phpDocumentor\Reflection\Php\Factory;

use phpDocumentor\Reflection\Fqsen;
use phpDocumentor\Reflection\Location;
use phpDocumentor\Reflection\Php\Interface_ as InterfaceElement;
use phpDocumentor\Reflection\Php\ProjectFactoryStrategy;
use phpDocumentor\Reflection\Php\StrategyContainer;
use phpDocumentor\Reflection\Types\Context;
use PhpParser\Node\Stmt\ClassConst;
use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Interface_ as InterfaceNode;

/**
 * Strategy to create a InterfaceElement including all sub elements.
 */
// @codingStandardsIgnoreStart
final class Interface_ extends AbstractFactory implements ProjectFactoryStrategy
// @codingStandardsIgnoreEnd
{
    public function matches($object): bool
    {
        return $object instanceof InterfaceNode;
    }

    /**
     * Creates an Interface_ out of the given object.
     * Since an object might contain other objects that need to be converted the $factory is passed so it can be
     * used to create nested Elements.
     *
     * @param InterfaceNode $object object to convert to an Element
     * @param StrategyContainer $strategies used to convert nested objects.
     * @param Context $context of the created object
     * @return InterfaceElement
     */
    protected function doCreate($object, StrategyContainer $strategies, ?Context $context = null)
    {
        $docBlock = $this->createDocBlock($strategies, $object->getDocComment(), $context);
        $parents = [];
        foreach ($object->extends as $extend) {
            $parents['\\' . (string) $extend] = new Fqsen('\\' . (string) $extend);
        }

        $interface = new InterfaceElement($object->fqsen, $parents, $docBlock, new Location($object->getLine()));

        if (isset($object->stmts)) {
            foreach ($object->stmts as $stmt) {
                switch (get_class($stmt)) {
                    case ClassMethod::class:
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                        $method = $this->createMember($stmt, $strategies, $context);
                        $interface->addMethod($method);

                        break;
                    case ClassConst::class:
                        $constants = new ClassConstantIterator($stmt);

                        foreach ($constants as $const) {
                            $element = $this->createMember($const, $strategies, $context);
                            $interface->addConstant($element);

                        }
                        break;
                }
            }
        }

        return $interface;
    }
}


1		<?php
2		declare(strict_types=1);
3
4		/**
5		* This file is part of phpDocumentor.
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*
10		* @copyright 2010-2018 Mike van Riel<[email protected]>
11		* @license http://www.opensource.org/licenses/mit-license.php MIT
12		* @link http://phpdoc.org
13		*/
14
15		namespace phpDocumentor\Reflection\Php\Factory;
16
17		use phpDocumentor\Reflection\Fqsen;
18		use phpDocumentor\Reflection\Location;
19		use phpDocumentor\Reflection\Php\Interface_ as InterfaceElement;
20		use phpDocumentor\Reflection\Php\ProjectFactoryStrategy;
21		use phpDocumentor\Reflection\Php\StrategyContainer;
22		use phpDocumentor\Reflection\Types\Context;
23		use PhpParser\Node\Stmt\ClassConst;
24		use PhpParser\Node\Stmt\ClassMethod;
25		use PhpParser\Node\Stmt\Interface_ as InterfaceNode;
26
27		/**
28		* Strategy to create a InterfaceElement including all sub elements.
29		*/
30		// @codingStandardsIgnoreStart
31		final class Interface_ extends AbstractFactory implements ProjectFactoryStrategy
32		// @codingStandardsIgnoreEnd
33		{
34	1	public function matches($object): bool
35		{
36	1	return $object instanceof InterfaceNode;
37		}
38
39		/**
40		* Creates an Interface_ out of the given object.
41		* Since an object might contain other objects that need to be converted the $factory is passed so it can be
42		* used to create nested Elements.
43		*
44		* @param InterfaceNode $object object to convert to an Element
45		* @param StrategyContainer $strategies used to convert nested objects.
46		* @param Context $context of the created object
47		* @return InterfaceElement
48		*/
49	4	protected function doCreate($object, StrategyContainer $strategies, ?Context $context = null)
50		{
51	4	$docBlock = $this->createDocBlock($strategies, $object->getDocComment(), $context);
52	4	$parents = [];
53	4	foreach ($object->extends as $extend) {
54		$parents['\\' . (string) $extend] = new Fqsen('\\' . (string) $extend);
55		}
56
57	4	$interface = new InterfaceElement($object->fqsen, $parents, $docBlock, new Location($object->getLine()));
58
59	4	if (isset($object->stmts)) {
60	2	foreach ($object->stmts as $stmt) {
61	2	switch (get_class($stmt)) {
62	2	case ClassMethod::class:
		0 ignored issues – show Coding Style introduced 2018-02-27 19:18 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
63	1	$method = $this->createMember($stmt, $strategies, $context);
64	1	$interface->addMethod($method);
		0 ignored issues – show Compatibility introduced 2015-11-23 21:15 UTC by Report Bug Copy Issue Report `$method` of type `object<phpDocumentor\Reflection\Element>` is not a sub-type of `object<phpDocumentor\Reflection\Php\Method>`. It seems like you assume a concrete implementation of the interface `phpDocumentor\Reflection\Element` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
65	1	break;
66	1	case ClassConst::class:
67	1	$constants = new ClassConstantIterator($stmt);
		0 ignored issues – show Compatibility introduced 2015-11-23 21:15 UTC by Report Bug Copy Issue Report `$stmt` of type `object<PhpParser\Node>` is not a sub-type of `object<PhpParser\Node\Stmt\ClassConst>`. It seems like you assume a concrete implementation of the interface `PhpParser\Node` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
68	1	foreach ($constants as $const) {
69	1	$element = $this->createMember($const, $strategies, $context);
70	1	$interface->addConstant($element);
		0 ignored issues – show Compatibility introduced 2015-11-23 21:15 UTC by Report Bug Copy Issue Report `$element` of type `object<phpDocumentor\Reflection\Element>` is not a sub-type of `object<phpDocumentor\Reflection\Php\Constant>`. It seems like you assume a concrete implementation of the interface `phpDocumentor\Reflection\Element` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
71		}
72	2	break;
73		}
74		}
75		}
76
77	4	return $interface;
78		}
79		}
80

phpDocumentor / Reflection

Pull Request — develop (#127)

Interface_::doCreate() C

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like