ContextNormalizer::normalize() - Code Metrics - php-xapi/symfony-serializer - Measure and Improve Code Quality continuously with Scrutinizer

ContextNormalizer::normalize() F
last analyzed 2021-03-26 19:13 UTC

↳ Parent: ContextNormalizer

Complexity

Conditions	12
Paths	1025

Size

Total Lines

Duplication

Lines	3
Ratio	6 %

Importance

Changes

Metric	Value
dl	3
loc	50
rs	2.8
c	0
b	0
f	0
cc	12
nc	1025
nop	3

How to fix Complexity

<?php

/*
 * This file is part of the xAPI package.
 *
 * (c) Christian Flothmann <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Xabbuh\XApi\Serializer\Symfony\Normalizer;

use Xabbuh\XApi\Model\Context;

/**
 * Normalizes and denormalizes xAPI statement contexts.
 *
 * @author Christian Flothmann <[email protected]>
 */
final class ContextNormalizer extends Normalizer
{
    public function normalize($object, $format = null, array $context = array())
    {
        if (!$object instanceof Context) {
            return;
        }

        $data = array();

        if (null !== $registration = $object->getRegistration()) {
            $data['registration'] = $registration;
        }

        if (null !== $instructor = $object->getInstructor()) {
            $data['instructor'] = $this->normalizeAttribute($instructor, $format, $context);
        }

        if (null !== $team = $object->getTeam()) {
            $data['team'] = $this->normalizeAttribute($team, $format, $context);
        }

        if (null !== $contextActivities = $object->getContextActivities()) {
            $data['contextActivities'] = $this->normalizeAttribute($contextActivities, $format, $context);
        }

        if (null !== $revision = $object->getRevision()) {
            $data['revision'] = $revision;
        }

        if (null !== $platform = $object->getPlatform()) {
            $data['platform'] = $platform;
        }

        if (null !== $language = $object->getLanguage()) {
            $data['language'] = $language;
        }

        if (null !== $statement = $object->getStatement()) {
            $data['statement'] = $this->normalizeAttribute($statement, $format, $context);
        }

        if (null !== $extensions = $object->getExtensions()) {

            $data['extensions'] = $this->normalizeAttribute($extensions, $format, $context);
        }

        if (empty($data)) {
            return new \stdClass();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        return $data;
    }

    public function supportsNormalization($data, $format = null)
    {
        return $data instanceof Context;
    }

    public function denormalize($data, $class, $format = null, array $context = array())
    {
        $statementContext = new Context();

        if (isset($data['registration'])) {
            $statementContext = $statementContext->withRegistration($data['registration']);
        }

        if (isset($data['instructor'])) {
            $statementContext = $statementContext->withInstructor($this->denormalizeData($data['instructor'], 'Xabbuh\XApi\Model\Actor', $format, $context));
        }

        if (isset($data['team'])) {
            $statementContext = $statementContext->withTeam($this->denormalizeData($data['team'], 'Xabbuh\XApi\Model\Group', $format, $context));
        }

        if (isset($data['contextActivities'])) {
            $statementContext = $statementContext->withContextActivities($this->denormalizeData($data['contextActivities'], 'Xabbuh\XApi\Model\ContextActivities', $format, $context));
        }

        if (isset($data['revision'])) {
            $statementContext = $statementContext->withRevision($data['revision']);
        }

        if (isset($data['platform'])) {
            $statementContext = $statementContext->withPlatform($data['platform']);
        }

        if (isset($data['language'])) {
            $statementContext = $statementContext->withLanguage($data['language']);
        }

        if (isset($data['statement'])) {
            $statementContext = $statementContext->withStatement($this->denormalizeData($data['statement'], 'Xabbuh\XApi\Model\StatementReference', $format, $context));
        }

        if (isset($data['extensions'])) {

            $statementContext = $statementContext->withExtensions($this->denormalizeData($data['extensions'], 'Xabbuh\XApi\Model\Extensions', $format, $context));
        }

        return $statementContext;
    }

    public function supportsDenormalization($data, $type, $format = null)
    {
        return 'Xabbuh\XApi\Model\Context' === $type;
    }
}


1		<?php
2
3		/*
4		* This file is part of the xAPI package.
5		*
6		* (c) Christian Flothmann <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Xabbuh\XApi\Serializer\Symfony\Normalizer;
13
14		use Xabbuh\XApi\Model\Context;
15
16		/**
17		* Normalizes and denormalizes xAPI statement contexts.
18		*
19		* @author Christian Flothmann <[email protected]>
20		*/
21		final class ContextNormalizer extends Normalizer
22		{
23		public function normalize($object, $format = null, array $context = array())
24		{
25		if (!$object instanceof Context) {
26		return;
27		}
28
29		$data = array();
30
31		if (null !== $registration = $object->getRegistration()) {
32		$data['registration'] = $registration;
33		}
34
35		if (null !== $instructor = $object->getInstructor()) {
36		$data['instructor'] = $this->normalizeAttribute($instructor, $format, $context);
37		}
38
39		if (null !== $team = $object->getTeam()) {
40		$data['team'] = $this->normalizeAttribute($team, $format, $context);
41		}
42
43		if (null !== $contextActivities = $object->getContextActivities()) {
44		$data['contextActivities'] = $this->normalizeAttribute($contextActivities, $format, $context);
45		}
46
47		if (null !== $revision = $object->getRevision()) {
48		$data['revision'] = $revision;
49		}
50
51		if (null !== $platform = $object->getPlatform()) {
52		$data['platform'] = $platform;
53		}
54
55		if (null !== $language = $object->getLanguage()) {
56		$data['language'] = $language;
57		}
58
59		if (null !== $statement = $object->getStatement()) {
60		$data['statement'] = $this->normalizeAttribute($statement, $format, $context);
61		}
62
63	View Code Duplication	if (null !== $extensions = $object->getExtensions()) {
		0 ignored issues – show Duplication introduced 2016-09-28 12:29 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
64		$data['extensions'] = $this->normalizeAttribute($extensions, $format, $context);
65		}
66
67		if (empty($data)) {
68		return new \stdClass();
		0 ignored issues – show Bug Best Practice introduced 2021-03-26 18:24 UTC by Report Bug Copy Issue Report The return type of `return new \stdClass();` (`stdClass`) is incompatible with the return type declared by the interface `Symfony\Component\Serial...zerInterface::normalize` of type `array\|string\|integer\|dou...oolean\|ArrayObject\|null`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
69		}
70
71		return $data;
72		}
73
74		public function supportsNormalization($data, $format = null)
75		{
76		return $data instanceof Context;
77		}
78
79		public function denormalize($data, $class, $format = null, array $context = array())
80		{
81		$statementContext = new Context();
82
83		if (isset($data['registration'])) {
84		$statementContext = $statementContext->withRegistration($data['registration']);
85		}
86
87		if (isset($data['instructor'])) {
88		$statementContext = $statementContext->withInstructor($this->denormalizeData($data['instructor'], 'Xabbuh\XApi\Model\Actor', $format, $context));
89		}
90
91		if (isset($data['team'])) {
92		$statementContext = $statementContext->withTeam($this->denormalizeData($data['team'], 'Xabbuh\XApi\Model\Group', $format, $context));
93		}
94
95		if (isset($data['contextActivities'])) {
96		$statementContext = $statementContext->withContextActivities($this->denormalizeData($data['contextActivities'], 'Xabbuh\XApi\Model\ContextActivities', $format, $context));
97		}
98
99		if (isset($data['revision'])) {
100		$statementContext = $statementContext->withRevision($data['revision']);
101		}
102
103		if (isset($data['platform'])) {
104		$statementContext = $statementContext->withPlatform($data['platform']);
105		}
106
107		if (isset($data['language'])) {
108		$statementContext = $statementContext->withLanguage($data['language']);
109		}
110
111		if (isset($data['statement'])) {
112		$statementContext = $statementContext->withStatement($this->denormalizeData($data['statement'], 'Xabbuh\XApi\Model\StatementReference', $format, $context));
113		}
114
115	View Code Duplication	if (isset($data['extensions'])) {
		0 ignored issues – show Duplication introduced 2016-09-28 12:29 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
116		$statementContext = $statementContext->withExtensions($this->denormalizeData($data['extensions'], 'Xabbuh\XApi\Model\Extensions', $format, $context));
117		}
118
119		return $statementContext;
120		}
121
122		public function supportsDenormalization($data, $type, $format = null)
123		{
124		return 'Xabbuh\XApi\Model\Context' === $type;
125		}
126		}
127

php-xapi / symfony-serializer

ContextNormalizer::normalize() F last analyzed 2021-03-26 19:13 UTC

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like

ContextNormalizer::normalize() F
last analyzed 2021-03-26 19:13 UTC