Xabbuh\XApi\Serializer\Symfony\StatementResultSerializer

Complexity

Total Complexity

3

Size/Duplication

Total Lines	35
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	4	4	1
A	serializeStatementResult()	4	4	1
A	deserializeStatementResult()	11	11	1

<?php

/*
 * This file is part of the xAPI package.
 *
 * (c) Christian Flothmann <christian.flothmann@xabbuh.de>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Xabbuh\XApi\Serializer\Symfony;

use Symfony\Component\Serializer\SerializerInterface;
use Xabbuh\XApi\Model\StatementResult;
use Xabbuh\XApi\Serializer\StatementResultSerializerInterface;

/**
 * Serializes and deserializes {@link StatementResult statement results} using the Symfony Serializer component.
 *
 * @author Christian Flothmann <christian.flothmann@xabbuh.de>
 */
final class StatementResultSerializer implements StatementResultSerializerInterface

This class seems to be duplicated in your project.

{
    /**
     * @var SerializerInterface The underlying serializer
     */
    private $serializer;

    public function __construct(SerializerInterface $serializer)
    {
        $this->serializer = $serializer;
    }

    /**
     * {@inheritDoc}
     */
    public function serializeStatementResult(StatementResult $statementResult)
    {
        return $this->serializer->serialize($statementResult, 'json');
    }

    /**
     * {@inheritDoc}
     */
    public function deserializeStatementResult($data, array $attachments = array())
    {
        return $this->serializer->deserialize(

The expression $this->serializer->deserialize($data, 'Xabbuh\\XApi\\Model\\StatementResult', 'json', array('xapi_attachments' => $attachments)); of type object|array adds the type array to the return on line 48 which is incompatible with the return type declared by the interface Xabbuh\XApi\Serializer\StatementResultSerializerInterface::deserializeStatementResult of type Xabbuh\XApi\Model\StatementResult.

            $data,
            'Xabbuh\XApi\Model\StatementResult',
            'json',
            array(
                'xapi_attachments' => $attachments,
            )
        );
    }
}