MappedStatementRepository - Code Metrics - Inspection of "change base namespace to XApi\Repository\MongoDB" - php-xapi/repository-mongodb - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b0b9f9...ac0d74 )

by Christian

created 2016-03-21 21:53 UTC

MappedStatementRepository A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	4
c	1
b	0
f	0
lcom	0
cbo	2
dl	0
loc	30
rs	10

3 Methods

Rating	Name	Size	Complexity
A	findMappedStatement()	4	1
A	findMappedStatements()	4	1
A	storeMappedStatement()	8	2

<?php

/*
 * This file is part of the xAPI package.
 *
 * (c) Christian Flothmann <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace XApi\Repository\MongoDB\Repository;

use Doctrine\ODM\MongoDB\DocumentRepository;
use XApi\Repository\Api\Mapping\MappedStatement;
use XApi\Repository\Doctrine\Repository\MappedStatementRepository as MappedStatementRepositoryInteface;

/**
 * A MongoDB backed statement repository.
 *
 * @author Christian Flothmann <[email protected]>
 */
class MappedStatementRepository extends DocumentRepository implements MappedStatementRepositoryInteface
{
    /**
     * {@inheritdoc}
     */
    public function findMappedStatement(array $criteria)
    {
        return parent::findOneBy($criteria);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * {@inheritdoc}
     */
    public function findMappedStatements(array $criteria)
    {
        return parent::findBy($criteria);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * {@inheritdoc}
     */
    public function storeMappedStatement(MappedStatement $mappedStatement, $flush = true)
    {
        $this->getDocumentManager()->persist($mappedStatement);

        if ($flush) {
            $this->getDocumentManager()->flush();
        }
    }
}


1			<?php
2
3			/*
4			* This file is part of the xAPI package.
5			*
6			* (c) Christian Flothmann <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace XApi\Repository\MongoDB\Repository;
13
14			use Doctrine\ODM\MongoDB\DocumentRepository;
15			use XApi\Repository\Api\Mapping\MappedStatement;
16			use XApi\Repository\Doctrine\Repository\MappedStatementRepository as MappedStatementRepositoryInteface;
17
18			/**
19			* A MongoDB backed statement repository.
20			*
21			* @author Christian Flothmann <[email protected]>
22			*/
23			class MappedStatementRepository extends DocumentRepository implements MappedStatementRepositoryInteface
24			{
25			/**
26			* {@inheritdoc}
27			*/
28			public function findMappedStatement(array $criteria)
29			{
30			return parent::findOneBy($criteria);
			0 ignored issues – show Comprehensibility Bug introduced 2016-03-21 12:15 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`findOneBy()` instead of `findMappedStatement()`). Are you sure this is correct? If so, you might want to change this to `$this->findOneBy()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
31			}
32
33			/**
34			* {@inheritdoc}
35			*/
36			public function findMappedStatements(array $criteria)
37			{
38			return parent::findBy($criteria);
			0 ignored issues – show Comprehensibility Bug introduced 2016-03-21 12:15 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`findBy()` instead of `findMappedStatements()`). Are you sure this is correct? If so, you might want to change this to `$this->findBy()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
39			}
40
41			/**
42			* {@inheritdoc}
43			*/
44			public function storeMappedStatement(MappedStatement $mappedStatement, $flush = true)
45			{
46			$this->getDocumentManager()->persist($mappedStatement);
47
48			if ($flush) {
49			$this->getDocumentManager()->flush();
50			}
51			}
52			}
53

php-xapi / repository-mongodb

Push — master ( b0b9f9...ac0d74 )

MappedStatementRepository A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like