Xabbuh\XApi\Model\Definition

Complexity

Total Complexity

16

Size/Duplication

Total Lines	131
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

0%

Importance

Changes	8
Bugs	0	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	getName()	0	4	1
A	getDescription()	0	4	1
A	getType()	0	4	1
A	getMoreInfo()	0	4	1
C	equals()	0	40	11

<?php

/*
 * This file is part of the xAPI package.
 *
 * (c) Christian Flothmann <christian.flothmann@xabbuh.de>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Xabbuh\XApi\Model;

/**
 * Definition of an {@link Activity}.
 *
 * @author Christian Flothmann <christian.flothmann@xabbuh.de>
 */
final class Definition
{
    /**
     * The human readable activity name
     * @var array
     */
    private $name;

    /**
     * The human readable activity description
     * @var array
     */
    private $description;

    /**
     * The type of the {@link Activity}
     * @var string
     */
    private $type;

    /**
     * An IRL where human-readable information describing the {@link Activity} can be found.
     *
     * @var string|null
     */
    private $moreInfo;

    /**
     * @param array|null  $name
     * @param array|null  $description
     * @param string|null $type
     * @param string|null $moreInfo
     */
    public function __construct(array $name = null, array $description = null, $type = null, $moreInfo = null)
    {
        $this->name = $name;

It seems like $name can be null. However, the property $name is declared as array. Maybe change the type of the property to array|null or add a type check?

        $this->description = $description;

It seems like $description can be null. However, the property $description is declared as array. Maybe change the type of the property to array|null or add a type check?

        $this->type = $type;
        $this->moreInfo = $moreInfo;
    }

    /**
     * Returns the human readable names.
     *
     * @return array The name language map
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * Returns the human readable descriptions.
     *
     * @return array The description language map
     */
    public function getDescription()
    {
        return $this->description;
    }

    /**
     * Returns the {@link Activity} type.
     *
     * @return string The type
     */
    public function getType()
    {
        return $this->type;
    }

    /**
     * Returns an IRL where human-readable information about the activity can be found.
     *
     * @return string|null
     */
    public function getMoreInfo()
    {
        return $this->moreInfo;
    }

    /**
     * Checks if another definition is equal.
     *
     * Two definitions are equal if and only if all of their properties are equal.
     *
     * @param Definition $definition The definition to compare with
     *
     * @return bool True if the definitions are equal, false otherwise
     */
    public function equals(Definition $definition)
    {
        if ($this->type !== $definition->type) {
            return false;
        }

        if ($this->moreInfo !== $definition->moreInfo) {
            return false;
        }

        if (count($this->name) !== count($definition->name)) {
            return false;
        }

        if (count($this->description) !== count($definition->description)) {
            return false;
        }

        foreach ($this->name as $language => $value) {
            if (!isset($definition->name[$language])) {
                return false;
            }

            if ($value !== $definition->name[$language]) {
                return false;
            }
        }

        foreach ($this->description as $language => $value) {
            if (!isset($definition->description[$language])) {
                return false;
            }

            if ($value !== $definition->description[$language]) {
                return false;
            }
        }

        return true;
    }
}