XliffConverterTest::testContentToCatalogue() - Code Metrics - Inspection of "Merge pull request #49 from Guite/master" - php-translation/symfony-storage - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7ace69...caa23d )

by Mathieu

created 2020-01-19 19:30 UTC

XliffConverterTest::testContentToCatalogue() A

↳ Parent: XliffConverterTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.9666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

/*
 * This file is part of the PHP Translation package.
 *
 * (c) PHP Translation team <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Translation\SymfonyStorage\Tests\Unit;

use PHPUnit\Framework\TestCase;
use Symfony\Component\Translation\MessageCatalogue;
use Translation\SymfonyStorage\XliffConverter;

/**
 * @author Tobias Nyholm <[email protected]>
 */
class XliffConverterTest extends TestCase
{
    public function testContentToCatalogue()
    {
        $content = file_get_contents(__DIR__.'/../Fixtures/single-file/messages.en.xlf');
        $catalogue = XliffConverter::contentToCatalogue($content, 'en', 'messages');

        $this->assertEquals('en', $catalogue->getLocale());
        $this->assertEquals(['messages'], $catalogue->getDomains());
        $this->assertCount(2, $catalogue->all('messages'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testCatalogueToContent()
    {
        $catalogue = new MessageCatalogue('en');
        $catalogue->add(['foobar' => 'bar']);
        $content = XliffConverter::catalogueToContent($catalogue, 'messages');

        $this->assertRegExp('|foobar|', $content);
    }
}


1			<?php
2
3			/*
4			* This file is part of the PHP Translation package.
5			*
6			* (c) PHP Translation team <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Translation\SymfonyStorage\Tests\Unit;
13
14			use PHPUnit\Framework\TestCase;
15			use Symfony\Component\Translation\MessageCatalogue;
16			use Translation\SymfonyStorage\XliffConverter;
17
18			/**
19			* @author Tobias Nyholm <[email protected]>
20			*/
21			class XliffConverterTest extends TestCase
22			{
23			public function testContentToCatalogue()
24			{
25			$content = file_get_contents(__DIR__.'/../Fixtures/single-file/messages.en.xlf');
26			$catalogue = XliffConverter::contentToCatalogue($content, 'en', 'messages');
27
28			$this->assertEquals('en', $catalogue->getLocale());
29			$this->assertEquals(['messages'], $catalogue->getDomains());
30			$this->assertCount(2, $catalogue->all('messages'));
			0 ignored issues – show Documentation introduced 2019-11-29 14:47 UTC by Report Bug Copy Issue Report `$catalogue->all('messages')` is of type `array`, but the function expects a `object<Countable>\|object...nit\Framework\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
31			}
32
33			public function testCatalogueToContent()
34			{
35			$catalogue = new MessageCatalogue('en');
36			$catalogue->add(['foobar' => 'bar']);
37			$content = XliffConverter::catalogueToContent($catalogue, 'messages');
38
39			$this->assertRegExp('\|foobar\|', $content);
40			}
41			}
42

php-translation / symfony-storage

Push — master ( 7ace69...caa23d )

XliffConverterTest::testContentToCatalogue() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like