Translation\Bundle\Command\StatusCommand

Complexity

Total Complexity

8

Size/Duplication

Total Lines	84
Duplicated Lines	13.1 %

Coupling/Cohesion

Components	2
Dependencies	9

Test Coverage

Coverage

77.14%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
A	configure()	11	11	1
B	execute()	0	33	6

<?php

/*
 * This file is part of the PHP Translation package.
 *
 * (c) PHP Translation team <tobias.nyholm@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Translation\Bundle\Command;

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Style\SymfonyStyle;
use Translation\Bundle\Catalogue\CatalogueCounter;
use Translation\Bundle\Catalogue\CatalogueFetcher;
use Translation\Bundle\Service\ConfigurationManager;

/**
 * @author Tobias Nyholm <tobias.nyholm@gmail.com>
 */
class StatusCommand extends Command
{
    use BundleTrait;

    protected static $defaultName = 'translation:status';

    /**
     * @var CatalogueCounter
     */
    private $catalogueCounter;

    /**
     * @var ConfigurationManager
     */
    private $configurationManager;

    /**
     * @var CatalogueFetcher
     */
    private $catalogueFetcher;

    /**
     * @param CatalogueCounter     $catalogueCounter
     * @param ConfigurationManager $configurationManager
     * @param CatalogueFetcher     $catalogueFetcher
     */
    public function __construct(
        CatalogueCounter $catalogueCounter,
        ConfigurationManager $configurationManager,
        CatalogueFetcher $catalogueFetcher
    ) {
        $this->catalogueCounter = $catalogueCounter;
        $this->configurationManager = $configurationManager;
        $this->catalogueFetcher = $catalogueFetcher;

        parent::__construct();
    }

    protected function configure()

This method seems to be duplicated in your project.

    {
        $this
            ->setName(self::$defaultName)
            ->setDescription('Show status about your translations.')
            ->addArgument('configuration', InputArgument::OPTIONAL, 'The configuration to use', 'default')
            ->addArgument('locale', InputArgument::OPTIONAL, 'The locale ot use. If omitted, we use all configured locales.', false)
            ->addOption('json', null, InputOption::VALUE_NONE, 'If we should output in Json format')
            ->addOption('bundle', 'b', InputOption::VALUE_REQUIRED, 'The translations for bundle you want to check.')
        ;
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $config = $this->configurationManager->getConfiguration($input->getArgument('configuration'));
        $this->configureBundleDirs($input, $config);

It seems like $config defined by $this->configurationManager->getConfiguration($input->getArgument('configuration')) on line 79 can be null; however, Translation\Bundle\Command\BundleTrait::configureBundleDirs() does not accept null, maybe add an additional type check?

        $locales = [];
        if ($inputLocale = $input->getArgument('locale')) {
            $locales = [$inputLocale];
        }

        $catalogues = $this->catalogueFetcher->getCatalogues($config, $locales);

It seems like $config defined by $this->configurationManager->getConfiguration($input->getArgument('configuration')) on line 79 can be null; however, Translation\Bundle\Catalogue\CatalogueFetcher::getCatalogues() does not accept null, maybe add an additional type check?

        $stats = [];
        foreach ($catalogues as $catalogue) {
            $stats[$catalogue->getLocale()] = $this->catalogueCounter->getCatalogueStatistics($catalogue);
        }

        if ($input->getOption('json')) {
            $output->writeln(json_encode($stats));

            return;
        }

        $io = new SymfonyStyle($input, $output);
        foreach ($stats as $locale => $stat) {
            $rows = [];
            foreach ($stat as $domain => $data) {
                $rows[] = [$domain, $data['defined'], $data['new'], $data['obsolete']];
            }
            $io->title('Locale: '.$locale);
            $io->table(['Domain', 'Defined', 'New', 'Obsolete'], $rows);
        }
    }
}