Translation\Bundle\Command\ExtractCommand

Complexity

Total Complexity

9

Size/Duplication

Total Lines	132
Duplicated Lines	8.33 %

Coupling/Cohesion

Components	2
Dependencies	13

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	15	1
A	configure()	11	11	1
A	execute()	0	44	4
A	getConfiguredFinder()	0	15	3

<?php

/*
 * This file is part of the PHP Translation package.
 *
 * (c) PHP Translation team <tobias.nyholm@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Translation\Bundle\Command;

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Style\SymfonyStyle;
use Symfony\Component\Finder\Finder;
use Translation\Bundle\Catalogue\CatalogueCounter;
use Translation\Bundle\Catalogue\CatalogueFetcher;
use Translation\Bundle\Catalogue\CatalogueWriter;
use Translation\Bundle\Model\Configuration;
use Translation\Bundle\Service\ConfigurationManager;
use Translation\Bundle\Service\Importer;
use Translation\Extractor\Model\Error;

/**
 * @author Tobias Nyholm <tobias.nyholm@gmail.com>
 */
class ExtractCommand extends Command
{
    use BundleTrait;

    protected static $defaultName = 'translation:extract';

    /**
     * @var CatalogueFetcher
     */
    private $catalogueFetcher;

    /**
     * @var CatalogueWriter
     */
    private $catalogueWriter;

    /**
     * @var CatalogueCounter
     */
    private $catalogueCounter;

    /**
     * @var Importer
     */
    private $importer;

    /**
     * @var ConfigurationManager
     */
    private $configurationManager;

    /**
     * @param CatalogueFetcher     $catalogueFetcher
     * @param CatalogueWriter      $catalogueWriter
     * @param CatalogueCounter     $catalogueCounter
     * @param Importer             $importer
     * @param ConfigurationManager $configurationManager
     */
    public function __construct(
        CatalogueFetcher $catalogueFetcher,
        CatalogueWriter $catalogueWriter,
        CatalogueCounter $catalogueCounter,
        Importer $importer,
        ConfigurationManager $configurationManager
    ) {
        $this->catalogueFetcher = $catalogueFetcher;
        $this->catalogueWriter = $catalogueWriter;
        $this->catalogueCounter = $catalogueCounter;
        $this->importer = $importer;
        $this->configurationManager = $configurationManager;

        parent::__construct();
    }

    protected function configure()

This method seems to be duplicated in your project.

    {
        $this
            ->setName(self::$defaultName)
            ->setDescription('Extract translations from source code.')
            ->addArgument('configuration', InputArgument::OPTIONAL, 'The configuration to use', 'default')
            ->addArgument('locale', InputArgument::OPTIONAL, 'The locale ot use. If omitted, we use all configured locales.', false)
            ->addOption('hide-errors', null, InputOption::VALUE_NONE, 'If we should print error or not')
            ->addOption('bundle', 'b', InputOption::VALUE_REQUIRED, 'The bundle you want extract translations from.')
        ;
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $config = $this->configurationManager->getConfiguration($input->getArgument('configuration'));

        $locales = [];
        if ($inputLocale = $input->getArgument('locale')) {
            $locales = [$inputLocale];
        }

        $catalogues = $this->catalogueFetcher->getCatalogues($config, $locales);

It seems like $config defined by $this->configurationManager->getConfiguration($input->getArgument('configuration')) on line 100 can be null; however, Translation\Bundle\Catalogue\CatalogueFetcher::getCatalogues() does not accept null, maybe add an additional type check?

        $this->configureBundleDirs($input, $config);

It seems like $config defined by $this->configurationManager->getConfiguration($input->getArgument('configuration')) on line 100 can be null; however, Translation\Bundle\Command\BundleTrait::configureBundleDirs() does not accept null, maybe add an additional type check?

        $finder = $this->getConfiguredFinder($config);

It seems like $config defined by $this->configurationManager->getConfiguration($input->getArgument('configuration')) on line 100 can be null; however, Translation\Bundle\Command\ExtractCommand::getConfiguredFinder() does not accept null, maybe add an additional type check?

        $result = $this->importer->extractToCatalogues($finder, $catalogues, [
            'blacklist_domains' => $config->getBlacklistDomains(),
            'whitelist_domains' => $config->getWhitelistDomains(),
            'project_root' => $config->getProjectRoot(),
        ]);
        $errors = $result->getErrors();

        $this->catalogueWriter->writeCatalogues($config, $result->getMessageCatalogues());

It seems like $config defined by $this->configurationManager->getConfiguration($input->getArgument('configuration')) on line 100 can be null; however, Translation\Bundle\Catalogue\CatalogueWriter::writeCatalogues() does not accept null, maybe add an additional type check?

$result->getMessageCatalogues() is of type array<integer,object<Symfony\Component\Translation\MessageCatalogueInterface>>, but the function expects a array<integer,object<Symfony\Component\Translation\MessageCatalogue>>.

        $definedBefore = $this->catalogueCounter->getNumberOfDefinedMessages($catalogues[0]);
        $definedAfter = $this->catalogueCounter->getNumberOfDefinedMessages($result->getMessageCatalogues()[0]);

        /*
         * Print results
         */
        $io = new SymfonyStyle($input, $output);
        $io->table(['Type', 'Count'], [
            ['Total defined messages', $definedAfter],
            ['New messages', $definedAfter - $definedBefore],
            ['Errors', count($errors)],
        ]);

        if (!$input->getOption('hide-errors')) {
            /** @var Error $error */
            foreach ($errors as $error) {
                $io->error(
                    sprintf("%s\nLine: %s\nMessage: %s", $error->getPath(), $error->getLine(), $error->getMessage())
                );
            }
        }
    }

    /**
     * @param Configuration $config
     *
     * @return Finder
     */
    private function getConfiguredFinder(Configuration $config)
    {
        $finder = new Finder();
        $finder->in($config->getDirs());

        foreach ($config->getExcludedDirs() as $exclude) {
            $finder->notPath($exclude);
        }

        foreach ($config->getExcludedNames() as $exclude) {
            $finder->notName($exclude);
        }

        return $finder;
    }
}