ConfigurationManager::getConfiguration() - Code Metrics - Inspection of "Bugfix. We should use "get" instead of has two tim..." - php-translation/symfony-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 28dd7c...705fb1 )

by Tobias

created 2017-01-05 04:59 UTC

ConfigurationManager::getConfiguration() B

↳ Parent: ConfigurationManager

Complexity

Conditions	5
Paths	4

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	12.4085

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	3
cts	9
cp	0.3333
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	7
nc	4
nop	1
crap	12.4085

<?php

/*
 * This file is part of the PHP Translation package.
 *
 * (c) PHP Translation team <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Translation\Bundle\Service;

use Translation\Bundle\Model\Configuration;

/**
 * A service to easily access different configurations.
 *
 * @author Tobias Nyholm <[email protected]>
 */
final class ConfigurationManager
{
    /**
     * @var Configuration[]
     */
    private $configuration = [];

    /**
     * @param string        $name
     * @param Configuration $configuration
     */
    public function addConfiguration($name, Configuration $configuration)
    {
        $this->configuration[$name] = $configuration;
    }

    /**
     * @param string $name
     *
     * @return null|Configuration
     */
    public function getConfiguration($name = 'default')
    {
        if (isset($this->configuration[$name])) {
            return $this->configuration[$name];
        }

        if ($name === 'default' || empty($name)) {
            $name = $this->getFirstName();
            if (isset($this->configuration[$name])) {
                return $this->configuration[$name];
            }
        }
    }

    /**
     * @return string
     */
    public function getFirstName()
    {
        foreach ($this->configuration as $name => $config) {
            return $name;
        }
    }

    /**
     * @return array
     */
    public function getNames()
    {
        return array_keys($this->configuration);
    }
}


1		<?php
2
3		/*
4		* This file is part of the PHP Translation package.
5		*
6		* (c) PHP Translation team <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Translation\Bundle\Service;
13
14		use Translation\Bundle\Model\Configuration;
15
16		/**
17		* A service to easily access different configurations.
18		*
19		* @author Tobias Nyholm <[email protected]>
20		*/
21		final class ConfigurationManager
22		{
23		/**
24		* @var Configuration[]
25		*/
26		private $configuration = [];
27
28		/**
29		* @param string $name
30		* @param Configuration $configuration
31		*/
32	1	public function addConfiguration($name, Configuration $configuration)
33		{
34	1	$this->configuration[$name] = $configuration;
35	1	}
36
37		/**
38		* @param string $name
39		*
40		* @return null\|Configuration
41		*/
42	1	public function getConfiguration($name = 'default')
43		{
44	1	if (isset($this->configuration[$name])) {
45	1	return $this->configuration[$name];
46		}
47
48		if ($name === 'default' \|\| empty($name)) {
49		$name = $this->getFirstName();
50		if (isset($this->configuration[$name])) {
51		return $this->configuration[$name];
52		}
53		}
54		}
55
56		/**
57		* @return string
58		*/
59		public function getFirstName()
60		{
61		foreach ($this->configuration as $name => $config) {
62		return $name;
63		}
64		}
65
66		/**
67		* @return array
68		*/
69		public function getNames()
70		{
71		return array_keys($this->configuration);
72		}
73		}
74

php-translation / symfony-bundle

Push — master ( 28dd7c...705fb1 )

ConfigurationManager::getConfiguration() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like