BundleTrait - Code Metrics - Inspection of "Removing empty messages in the total count in webu..." - php-translation/symfony-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 396a44...7d840c )

by Tobias

created 2017-12-31 12:20 UTC

BundleTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	22
Duplicated Lines	31.82 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

27.27%

Importance

Changes

Metric	Value
wmc	4
lcom	0
cbo	2
dl	7
loc	22
ccs	3
cts	11
cp	0.2727
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	configureBundleDirs()	7	19	4

How to fix Duplicated Code

<?php

/*
 * This file is part of the PHP Translation package.
 *
 * (c) PHP Translation team <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Translation\Bundle\Command;

use Symfony\Component\Console\Input\InputInterface;
use Translation\Bundle\Model\Configuration;

trait BundleTrait
{
    private function configureBundleDirs(InputInterface $input, Configuration $config)
    {
        if ($bundleName = $input->getOption('bundle')) {
            if ('@' === $bundleName[0]) {

                if (false === $pos = strpos($bundleName, '/')) {
                    $bundleName = substr($bundleName, 1);
                } else {
                    $bundleName = substr($bundleName, 1, $pos - 2);
                }
            }

            $bundle = $this->getApplication()
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                ->getKernel()
                ->getBundle($bundleName)
            ;

            $config->reconfigureBundleDirs($bundle->getPath(), $bundle->getPath().'/Resources/translations');
        }
    }
}


1			<?php
2
3			/*
4			* This file is part of the PHP Translation package.
5			*
6			* (c) PHP Translation team <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Translation\Bundle\Command;
13
14			use Symfony\Component\Console\Input\InputInterface;
15			use Translation\Bundle\Model\Configuration;
16
17			trait BundleTrait
18			{
19	2		private function configureBundleDirs(InputInterface $input, Configuration $config)
20			{
21	2		if ($bundleName = $input->getOption('bundle')) {
22		View Code Duplication	if ('@' === $bundleName[0]) {
			0 ignored issues – show Duplication introduced 2017-12-31 12:31 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23			if (false === $pos = strpos($bundleName, '/')) {
24			$bundleName = substr($bundleName, 1);
25			} else {
26			$bundleName = substr($bundleName, 1, $pos - 2);
27			}
28			}
29
30			$bundle = $this->getApplication()
			0 ignored issues – show Bug introduced 2017-12-31 12:31 UTC by Report Bug Copy Issue Report It seems like `getApplication()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
31			->getKernel()
32			->getBundle($bundleName)
33			;
34
35			$config->reconfigureBundleDirs($bundle->getPath(), $bundle->getPath().'/Resources/translations');
36			}
37	2		}
38			}
39

php-translation / symfony-bundle

Push — master ( 396a44...7d840c )

BundleTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like