FlysystemXliffLoader::load() - Code Metrics - Inspection of "Added XliffCoventer (#3)" - php-translation/flysystem-adapter - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1e4ad0...0fbc71 )

by Tobias

created 2017-01-03 08:55 UTC

FlysystemXliffLoader::load() A

↳ Parent: FlysystemXliffLoader

Complexity

Conditions	3
Paths	3

Size

Total Lines	15
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	15
rs	9.4285
cc	3
eloc	8
nc	3
nop	3

<?php

/*
 * This file is part of the PHP Translation package.
 *
 * (c) PHP Translation team <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Translation\PlatformAdapter\Flysystem\Loader;

use League\Flysystem\Filesystem;
use Symfony\Component\Translation\MessageCatalogue;
use Symfony\Component\Translation\Exception\NotFoundResourceException;
use Symfony\Component\Config\Resource\FileResource;
use Translation\SymfonyStorage\Loader\XliffLoader;

/**
 * XliffFileLoader loads translations from XLIFF files.
 *
 * @author Tobias Nyholm <[email protected]>
 */
final class FlysystemXliffLoader extends XliffLoader
{
    /**
     * @var Filesystem
     */
    private $filesystem;

    /**
     * @param Filesystem filesystem
     */
    public function __construct(Filesystem $filesystem)
    {
        $this->filesystem = $filesystem;
    }

    /**
     * {@inheritdoc}
     */
    public function load($resource, $locale, $domain = 'messages')
    {
        if (!$this->filesystem->has($resource)) {
            throw new NotFoundResourceException(sprintf('File "%s" not found.', $resource));
        }

        $catalogue = new MessageCatalogue($locale);
        $this->extractFromContent($this->filesystem->read($resource), $catalogue, $domain);


        if (class_exists('Symfony\Component\Config\Resource\FileResource')) {
            $catalogue->addResource(new FileResource($resource));
        }

        return $catalogue;
    }
}


1			<?php
2
3			/*
4			* This file is part of the PHP Translation package.
5			*
6			* (c) PHP Translation team <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Translation\PlatformAdapter\Flysystem\Loader;
13
14			use League\Flysystem\Filesystem;
15			use Symfony\Component\Translation\MessageCatalogue;
16			use Symfony\Component\Translation\Exception\NotFoundResourceException;
17			use Symfony\Component\Config\Resource\FileResource;
18			use Translation\SymfonyStorage\Loader\XliffLoader;
19
20			/**
21			* XliffFileLoader loads translations from XLIFF files.
22			*
23			* @author Tobias Nyholm <[email protected]>
24			*/
25			final class FlysystemXliffLoader extends XliffLoader
26			{
27			/**
28			* @var Filesystem
29			*/
30			private $filesystem;
31
32			/**
33			* @param Filesystem filesystem
34			*/
35			public function __construct(Filesystem $filesystem)
36			{
37			$this->filesystem = $filesystem;
38			}
39
40			/**
41			* {@inheritdoc}
42			*/
43			public function load($resource, $locale, $domain = 'messages')
44			{
45			if (!$this->filesystem->has($resource)) {
46			throw new NotFoundResourceException(sprintf('File "%s" not found.', $resource));
47			}
48
49			$catalogue = new MessageCatalogue($locale);
50			$this->extractFromContent($this->filesystem->read($resource), $catalogue, $domain);
			0 ignored issues – show Security Bug introduced 2017-01-03 09:02 UTC by Report Bug Copy Issue Report It seems like `$this->filesystem->read($resource)` targeting `League\Flysystem\Filesystem::read()` can also be of type `false`; however, `Translation\SymfonyStora...r::extractFromContent()` does only seem to accept `string`, did you maybe forget to handle an error condition? Loading history...
51
52			if (class_exists('Symfony\Component\Config\Resource\FileResource')) {
53			$catalogue->addResource(new FileResource($resource));
54			}
55
56			return $catalogue;
57			}
58			}
59

php-translation / flysystem-adapter

Push — master ( 1e4ad0...0fbc71 )

FlysystemXliffLoader::load() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like