Translation\PlatformAdapter\Flysystem\Loader\FlysystemXliffLoader

Complexity

Total Complexity

4

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

25%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	load()	0	15	3

<?php

/*
 * This file is part of the PHP Translation package.
 *
 * (c) PHP Translation team <tobias.nyholm@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Translation\PlatformAdapter\Flysystem\Loader;

use League\Flysystem\Filesystem;
use Symfony\Component\Translation\MessageCatalogue;
use Symfony\Component\Translation\Exception\NotFoundResourceException;
use Symfony\Component\Config\Resource\FileResource;
use Translation\SymfonyStorage\Loader\XliffLoader;

/**
 * XliffFileLoader loads translations from XLIFF files.
 *
 * @author Tobias Nyholm <tobias.nyholm@gmail.com>
 */
final class FlysystemXliffLoader extends XliffLoader
{
    /**
     * @var Filesystem
     */
    private $filesystem;

    /**
     * @param Filesystem filesystem
     */
    public function __construct(Filesystem $filesystem)
    {
        $this->filesystem = $filesystem;
    }

    /**
     * {@inheritdoc}
     */
    public function load($resource, $locale, $domain = 'messages')
    {
        if (!$this->filesystem->has($resource)) {
            throw new NotFoundResourceException(sprintf('File "%s" not found.', $resource));
        }

        $catalogue = new MessageCatalogue($locale);
        $this->extractFromContent($this->filesystem->read($resource), $catalogue, $domain);

It seems like $this->filesystem->read($resource) targeting League\Flysystem\Filesystem::read() can also be of type false; however, Translation\SymfonyStorage\Loader\XliffLoader::extractFromContent() does only seem to accept string, did you maybe forget to handle an error condition?

        if (class_exists('Symfony\Component\Config\Resource\FileResource')) {
            $catalogue->addResource(new FileResource($resource));
        }

        return $catalogue;
    }
}