ContainerAwareTrans::newAction() - Code Metrics - Inspection of "Added more test, test resources and bugfixes (#24)" - php-translation/extractor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f79648...4cc3e5 )

by Tobias

created 2017-01-04 14:19 UTC

ContainerAwareTrans::newAction() A

↳ Parent: ContainerAwareTrans

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	19
ccs	0
cts	15
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	10
nc	1
nop	0
crap	2

<?php

namespace Translation\Extractor\Tests\Resources\Php\Symfony;

class ContainerAwareTrans
{
    /**
     * @return array
     */
    public function newAction()
    {
        // Using container
        $translated = $this->get('translator')->trans('trans0');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        // As a parameter
        $model->setMessage(

            $this->get('translator')->trans(

                'trans1',
                array(
                    'a' => 'x',
                    'b' => 'y',
                    'c' => 'z',
                )
            )
        );

        return array();
    }

    public function getLine()
    {
        return $this->translator->trans('trans_line');
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
    public function getTranslatorVariable()
    {
        $translator = $this->get('translator');

        $translator->trans('variable');
    }
}


1			<?php
2
3			namespace Translation\Extractor\Tests\Resources\Php\Symfony;
4
5			class ContainerAwareTrans
6			{
7			/**
8			* @return array
9			*/
10			public function newAction()
11			{
12			// Using container
13			$translated = $this->get('translator')->trans('trans0');
			0 ignored issues – show Bug introduced 2016-12-05 09:59 UTC by Report Bug Copy Issue Report The method `get()` does not seem to exist on `object<Translation\Extra...ny\ContainerAwareTrans>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history... Unused Code introduced 2016-12-05 09:59 UTC by Report Bug Copy Issue Report `$translated` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
14
15			// As a parameter
16			$model->setMessage(
			0 ignored issues – show Bug introduced 2017-01-04 14:22 UTC by Report Bug Copy Issue Report The variable `$model` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
17			$this->get('translator')->trans(
			0 ignored issues – show Bug introduced 2017-01-04 14:22 UTC by Report Bug Copy Issue Report The method `get()` does not seem to exist on `object<Translation\Extra...ny\ContainerAwareTrans>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
18			'trans1',
19			array(
20			'a' => 'x',
21			'b' => 'y',
22			'c' => 'z',
23			)
24			)
25			);
26
27			return array();
28			}
29
30			public function getLine()
31			{
32			return $this->translator->trans('trans_line');
			0 ignored issues – show Bug introduced 2017-01-04 14:22 UTC by Report Bug Copy Issue Report The property `translator` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
33			}
34			public function getTranslatorVariable()
35			{
36			$translator = $this->get('translator');
			0 ignored issues – show Bug introduced 2017-01-04 14:22 UTC by Report Bug Copy Issue Report The method `get()` does not seem to exist on `object<Translation\Extra...ny\ContainerAwareTrans>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
37			$translator->trans('variable');
38			}
39			}
40

php-translation / extractor

Push — master ( f79648...4cc3e5 )

ContainerAwareTrans::newAction() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like