Translation\Extractor\Visitor\Php\Symfony\FormTypePlaceholder::enterNode()

Complexity

Conditions	19
Paths	62

Size

Total Lines	60
Code Lines	35

Duplication

Lines	5
Ratio	8.33 %

Code Coverage

Tests	35
CRAP Score	19

Importance

Changes

0

<?php
    public function enterNode(Node $node)
    {
        if (!$this->isFormType($node)) {
            return;
        }
        parent::enterNode($node);

        if (!$node instanceof Node\Expr\Array_) {
            return;
        }

        $placeholderNode = null;
        $domain = null;
        foreach ($node->items as $item) {
            if (!$item->key instanceof Node\Scalar\String_) {
                continue;
            }
            if ('translation_domain' === $item->key->value) {
                // Try to find translation domain
                if ($item->value instanceof Node\Scalar\String_) {

This code seems to be duplicated across your project.

                    $domain = $item->value->value;
                } elseif ($item->value instanceof Node\Expr\ConstFetch && 'false' === $item->value->name->toString()) {
                    $domain = false;
                }
            } elseif ('placeholder' === $item->key->value) {
                $placeholderNode = $item;
            } elseif ('attr' === $item->key->value) {
                foreach ($item->value->items as $attrValue) {

The property items does not seem to exist in PhpParser\Node\Expr.

                    if ('placeholder' === $attrValue->key->value) {
                        $placeholderNode = $attrValue;

                        break;
                    }
                }
            }
        }

        if (null !== $placeholderNode) {
            /**
             * Make sure we do not visit the same placeholder node twice.
             */
            $hash = spl_object_hash($placeholderNode);
            if (isset($this->arrayNodeVisited[$hash])) {
                return;
            }
            $this->arrayNodeVisited[$hash] = true;

            if ($placeholderNode->value instanceof Node\Scalar\String_) {
                $line = $placeholderNode->value->getAttribute('startLine');
                if (null !== $location = $this->getLocation($placeholderNode->value->value, $line, $placeholderNode, ['domain' => $domain])) {
                    $this->lateCollect($location);
                }
            } elseif ($placeholderNode->value instanceof Node\Expr\ConstFetch && 'false' === $placeholderNode->value->name->toString()) {

This elseif statement is empty, and could be removed.

                // 'placeholder' => false,

43% of this comment could be valid code. Did you maybe forget this after debugging?

                // Do noting
            } else {
                $this->addError($placeholderNode, 'Form placeholder is not a scalar string');
            }
        }
    }
}