SourceLocation - Code Metrics - Inspection of "Fixed broken build (#98)" - php-translation/extractor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1de6a4...fe9fab )

by Tobias

created 2018-04-10 16:43 UTC

SourceLocation A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	90
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	8
lcom	0
cbo	0
dl	0
loc	90
ccs	19
cts	19
cp	1
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Size	Complexity
A	__construct()	7	1
A	createHere()	11	3
A	getMessage()	4	1
A	getPath()	4	1
A	getLine()	4	1
A	getContext()	4	1

<?php

/*
 * This file is part of the PHP Translation package.
 *
 * (c) PHP Translation team <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Translation\Extractor\Model;

/**
 * @author Tobias Nyholm <[email protected]>
 */
final class SourceLocation
{
    /**
     * Translation key.
     *
     * @var string
     */
    private $message;

    /**
     * @var string
     */
    private $path;

    /**
     * @var int
     */
    private $line;

    /**
     * @var array
     */
    private $context;

    /**
     * @param string $message
     * @param string $path
     * @param int    $line
     * @param array  $context
     */
    public function __construct($message, $path, $line, array $context = [])
    {
        $this->message = $message;
        $this->path = (string) $path;
        $this->line = $line;
        $this->context = $context;
    }

    /**
     * Create a source location from your current location.
     *
     * @param string $message
     * @param array  $context
     *
     * @return SourceLocation
     */
    public static function createHere($message, array $context = [])
    {
        foreach (debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT, 2) as $trace) {
            // File is not set if we call from an anonymous context like an array_map function.
            if (isset($trace['file'])) {
                break;
            }
        }

        return new self($message, $trace['file'], $trace['line'], $context);
foreach ($a as $b) {
}

// $b is defined here only if $a has elements, for example if $a is array()
// then $b would not be defined here. To avoid that, we recommend to set a
// default value for $b.


// Better
$b = 0; // or whatever default makes sense in your context
foreach ($a as $b) {
}

// $b is now guaranteed to be defined here.
    }

    /**
     * @return string
     */
    public function getMessage()
    {
        return $this->message;
    }

    /**
     * @return string
     */
    public function getPath()
    {
        return $this->path;
    }

    /**
     * @return int
     */
    public function getLine()
    {
        return $this->line;
    }

    /**
     * @return array
     */
    public function getContext()
    {
        return $this->context;
    }
}


1		<?php
2
3		/*
4		* This file is part of the PHP Translation package.
5		*
6		* (c) PHP Translation team <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Translation\Extractor\Model;
13
14		/**
15		* @author Tobias Nyholm <[email protected]>
16		*/
17		final class SourceLocation
18		{
19		/**
20		* Translation key.
21		*
22		* @var string
23		*/
24		private $message;
25
26		/**
27		* @var string
28		*/
29		private $path;
30
31		/**
32		* @var int
33		*/
34		private $line;
35
36		/**
37		* @var array
38		*/
39		private $context;
40
41		/**
42		* @param string $message
43		* @param string $path
44		* @param int $line
45		* @param array $context
46		*/
47	29	public function __construct($message, $path, $line, array $context = [])
48		{
49	29	$this->message = $message;
50	29	$this->path = (string) $path;
51	29	$this->line = $line;
52	29	$this->context = $context;
53	29	}
54
55		/**
56		* Create a source location from your current location.
57		*
58		* @param string $message
59		* @param array $context
60		*
61		* @return SourceLocation
62		*/
63	4	public static function createHere($message, array $context = [])
64		{
65	4	foreach (debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT, 2) as $trace) {
66		// File is not set if we call from an anonymous context like an array_map function.
67	4	if (isset($trace['file'])) {
68	4	break;
69		}
70		}
71
72	4	return new self($message, $trace['file'], $trace['line'], $context);
		0 ignored issues – show Bug introduced 2018-04-10 16:53 UTC by Report Bug Copy Issue Report The variable `$trace` seems to be defined by a `foreach` iteration on line `65`. Are you sure the iterator is never empty, otherwise this variable is not defined? It seems like you are relying on a variable being defined by an iteration: foreach ($a as $b) { } // $b is defined here only if $a has elements, for example if $a is array() // then $b would not be defined here. To avoid that, we recommend to set a // default value for $b. // Better $b = 0; // or whatever default makes sense in your context foreach ($a as $b) { } // $b is now guaranteed to be defined here. Loading history...
73		}
74
75		/**
76		* @return string
77		*/
78	28	public function getMessage()
79		{
80	28	return $this->message;
81		}
82
83		/**
84		* @return string
85		*/
86	3	public function getPath()
87		{
88	3	return $this->path;
89		}
90
91		/**
92		* @return int
93		*/
94	6	public function getLine()
95		{
96	6	return $this->line;
97		}
98
99		/**
100		* @return array
101		*/
102	9	public function getContext()
103		{
104	9	return $this->context;
105		}
106		}
107

php-translation / extractor

Push — master ( 1de6a4...fe9fab )

SourceLocation A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

Duplication Side-by-Side

Filter issues like