This class seems to be duplicated in your project.
Duplicated code is one of the most pungent code smells. If you need to duplicate
the same code in three or more different places, we strongly encourage you to
look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.
Loading history...
22
{
23
/**
24
* @var WorkerTranslationBlock
25
*/
26
private $worker;
27
28
3
public function __construct()
29
{
30
3
$this->worker = new WorkerTranslationBlock();
31
3
}
32
33
public function enterNode(Twig_NodeInterface $node, Twig_Environment $env)
34
{
35
3
return $this->worker->work($node, $this->collection, function () {
The expression $this->worker->work($nod...AbsoluteFilePath(); }); of type Twig_Node|Twig_NodeInterface adds the type Twig_NodeInterface to the return on line 35 which is incompatible with the return type declared by the interface Twig_NodeVisitorInterface::enterNode of type Twig_Node.
Loading history...
36
3
return $this->getAbsoluteFilePath();
37
3
});
38
}
39
40
3
public function leaveNode(Twig_NodeInterface $node, Twig_Environment $env)
The return type of return $node; (Twig_NodeInterface) is incompatible with the return type declared by the interface Twig_NodeVisitorInterface::leaveNode of type Twig_Node|false.
If you return a value from a function or method, it should be a sub-type of the
type that is given by the parent type f.e. an interface, or abstract method.
This is more formally defined by the
Lizkov substitution principle,
and guarantees that classes that depend on the parent type can use any instance
of a child type interchangably. This principle also belongs to the
SOLID principles
for object oriented design.
Our function my_function expects a Post object, and outputs the author
of the post. The base class Post returns a simple string and outputting a
simple string will work just fine. However, the child class BlogPost which
is a sub-type of Post instead decided to return an object, and is
therefore violating the SOLID principles. If a BlogPost were passed to
my_function, PHP would not complain, but ultimately fail when executing the
strtoupper call in its body.
php-translation /
extractor
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.