Translation\Extractor\Tests\Functional\Visitor\Php\BasePHPVisitorTest::getSourceLocations()

Complexity

Conditions	8
Paths	18

Size

Total Lines	42
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	27
CRAP Score	8.0029

Importance

Changes

0

<?php
    protected function getSourceLocations($visitor, $namespaceForTestFile)
    {
        $extractor = new PHPFileExtractor();

        if (is_array($visitor)) {
            foreach ($visitor as $nodeVisitor) {
                $extractor->addVisitor($nodeVisitor);
            }
        } else {
            $extractor->addVisitor($visitor);
        }

        $currentNamespace = explode('\\', __NAMESPACE__);
        $fileNamespace = explode('\\', $namespaceForTestFile);
        $filename = array_pop($fileNamespace).'*';

        $path = __DIR__.'/../../..';
        foreach ($fileNamespace as $i => $part) {
            if ($currentNamespace[$i] !== $part) {
                // Assert: The namespaces is different now
                for ($j = $i; $j < count($fileNamespace); ++$j) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                    $path .= '/'.$fileNamespace[$j];
                }

                break;
            }
        }

        $finder = new Finder();
        $finder->files()->name($filename)->in($path);

        if ($finder->count() === 0) {
            throw new \Exception("Cannot find file for: $namespaceForTestFile. Tried path: $path - Maybe filename doesn't match the class?");
        }

        $collection = new SourceCollection();
        foreach ($finder as $file) {
            $extractor->getSourceLocations($file, $collection);
        }

        return $collection;
    }
}