Twig1Visitor - Code Metrics - Inspection of "Prepare 1.1 (#37)" - php-translation/extractor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a423a5...0fdb96 )

by Tobias

created 2017-03-11 16:00 UTC

Twig1Visitor A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	17
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	3
c	0
b	0
f	0
lcom	0
cbo	1
dl	0
loc	17
rs	10
ccs	6
cts	6
cp	1

3 Methods

Rating	Name	Size	Complexity
A	enterNode()	4	1
A	leaveNode()	4	1
A	getPriority()	4	1

<?php

/*
 * This file is part of the PHP Translation package.
 *
 * (c) PHP Translation team <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Translation\Extractor\Visitor\Twig;

use Twig_Environment;
use Twig_NodeInterface;

/**
 * @author Tobias Nyholm <[email protected]>
 */
final class Twig1Visitor extends TwigVisitor implements \Twig_NodeVisitorInterface
{
    public function enterNode(Twig_NodeInterface $node, Twig_Environment $env)
    {
        return $this->doEnterNode($node);

    }

    public function leaveNode(Twig_NodeInterface $node, Twig_Environment $env)
    {
        return $node;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    public function getPriority()
    {
        return 0;
    }
}


1		<?php
2
3		/*
4		* This file is part of the PHP Translation package.
5		*
6		* (c) PHP Translation team <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Translation\Extractor\Visitor\Twig;
13
14		use Twig_Environment;
15		use Twig_NodeInterface;
16
17		/**
18		* @author Tobias Nyholm <[email protected]>
19		*/
20		final class Twig1Visitor extends TwigVisitor implements \Twig_NodeVisitorInterface
21		{
22	4	public function enterNode(Twig_NodeInterface $node, Twig_Environment $env)
23		{
24	4	return $this->doEnterNode($node);
		0 ignored issues – show Bug Compatibility introduced 2017-03-11 16:03 UTC by Report Bug Copy Issue Report The expression `$this->doEnterNode($node);` of type `Twig_Node\|Twig_NodeInterface` adds the type `Twig_NodeInterface` to the return on line 24 which is incompatible with the return type declared by the interface `Twig_NodeVisitorInterface::enterNode` of type `Twig_Node`. Loading history...
25		}
26
27	4	public function leaveNode(Twig_NodeInterface $node, Twig_Environment $env)
28		{
29	4	return $node;
		0 ignored issues – show Bug Best Practice introduced 2017-03-11 14:06 UTC by Report Bug Copy Issue Report The return type of `return $node;` (`Twig_NodeInterface`) is incompatible with the return type declared by the interface `Twig_NodeVisitorInterface::leaveNode` of type `Twig_Node\|false`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
30		}
31
32	4	public function getPriority()
33		{
34	4	return 0;
35		}
36		}
37

php-translation / extractor

Push — master ( a423a5...0fdb96 )

Twig1Visitor A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like