Translation\Extractor\Visitor\Php\Symfony\FormTypeLabelImplicit::enterNode()

Complexity

Conditions	28
Paths	65

Size

Total Lines

67

Duplication

Lines	12
Ratio	17.91 %

Code Coverage

Tests	33
CRAP Score	28

Importance

Changes

0

<?php
    public function enterNode(Node $node)
    {
        if (!$this->isFormType($node)) {
            return;
        }

        parent::enterNode($node);

        $domain = null;
        // use add() function and look at first argument and if that's a string
        if ($node instanceof Node\Expr\MethodCall
            && (!is_object($node->name) || method_exists($node->name, '__toString'))
            && ('add' === (string) $node->name || 'create' === (string) $node->name)
            && $node->args[0]->value instanceof Node\Scalar\String_) {
            $skipLabel = false;
            // Check if the form type is "hidden"
            if (count($node->args) >= 2) {
                $type = $node->args[1]->value;
                if ($type instanceof Node\Scalar\String_ && 'Symfony\Component\Form\Extension\Core\Type\HiddenType' === $type->value
                    || $type instanceof Node\Expr\ClassConstFetch && 'HiddenType' === $type->class->parts[0]) {
                    $skipLabel = true;
                }
            }

            // now make sure we don't have 'label' in the array of options
            if (count($node->args) >= 3) {
                if ($node->args[2]->value instanceof Node\Expr\Array_) {
                    foreach ($node->args[2]->value->items as $item) {

The property items does not seem to exist in PhpParser\Node\Expr.

                        if (isset($item->key) && 'label' === $item->key->value) {
                            $skipLabel = true;
                        }

                        if (isset($item->key) && 'translation_domain' === $item->key->value) {

This code seems to be duplicated across your project.

                            if ($item->value instanceof Node\Scalar\String_) {
                                $domain = $item->value->value;
                            } elseif ($item->value instanceof Node\Expr\ConstFetch && 'false' === $item->value->name->toString()) {
                                $domain = false;
                            }
                        }
                    }
                }
                /*
                 * Actually there's another case here.. if the 3rd argument is anything else, it could well be
                 * that label is set through a static array. This will not be a common use-case so yeah in this case
                 * it may be the translation is double.
                 */
            }

            // only if no custom label was found, proceed
            if (false === $skipLabel && false !== $domain) {
                /*
                 * Pass DocComment (if available) from first argument (name of Form field) allowing usage of Ignore
                 * annotation to disable implicit add; use case: when form options are generated by external method.
                 */
                if ($node->args[0]->getDocComment()) {
                    $node->setDocComment($node->args[0]->getDocComment());

It seems like $node->args[0]->getDocComment() can be null; however, setDocComment() does not accept null, maybe add an additional type check?

                }

                $label = $node->args[0]->value->value;

The property value does not seem to exist in PhpParser\Node\Expr.

                if (!empty($label)) {

This code seems to be duplicated across your project.

                    if (null !== $location = $this->getLocation($label, $node->getAttribute('startLine'), $node, ['domain' => $domain])) {
                        $this->lateCollect($location);
                    }
                }
            }
        }
    }
}