Issues (32)

Security Analysis    no request data  

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Storage/FileStorage.php (4 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
3
/*
4
 * This file is part of the PHP Translation package.
5
 *
6
 * (c) PHP Translation team <[email protected]>
7
 *
8
 * For the full copyright and license information, please view the LICENSE
9
 * file that was distributed with this source code.
10
 */
11
12
namespace Translation\Common\Storage;
13
14
use Symfony\Component\Translation\MessageCatalogue;
15
use Symfony\Component\Translation\MessageCatalogueInterface;
16
use Symfony\Component\Translation\Reader\TranslationReaderInterface;
17
use Symfony\Component\Translation\Writer\TranslationWriterInterface;
18
use Translation\Common\Model\Message;
19
use Translation\Common\Model\MessageInterface;
20
21
/**
22
 * This storage uses Symfony's writer and loader.
23
 *
24
 * @author Tobias Nyholm <[email protected]>
25
 */
26
final class FileStorage implements StorageInterface
27
{
28
    /**
29
     * @var TranslationWriterInterface
30
     */
31
    private $writer;
32
33
    /**
34
     * @var TranslationReaderInterface
35
     */
36
    private $reader;
37
38
    /**
39
     * @var array directory path
40
     */
41
    private $dir;
42
43
    /**
44
     * @var array with option to the dumper
45
     */
46
    private $options;
47
48
    /**
49
     * @var MessageCatalogue[] Fetched catalogues
50
     */
51
    private $catalogues;
52
53 9
    public function __construct(TranslationWriterInterface $writer, TranslationReaderInterface $reader, array $dir, array $options = [])
54
    {
55 9
        if (empty($dir)) {
56 1
            throw new \LogicException('Third parameter of FileStorage cannot be empty');
57
        }
58
59 8
        if (!\array_key_exists('xliff_version', $options)) {
60
            // Set default value for xliff version.
61 8
            $options['xliff_version'] = '2.0';
62
        }
63
64 8
        $this->writer = $writer;
65 8
        $this->reader = $reader;
66 8
        $this->dir = $dir;
67 8
        $this->options = $options;
68 8
    }
69
70
    /**
71
     * {@inheritdoc}
72
     */
73 1
    public function get(string $locale, string $domain, string $key): ?MessageInterface
74
    {
75 1
        $catalogue = $this->getCatalogue($locale);
76 1
        $translation = $catalogue->get($key, $domain);
77
78 1
        return new Message($key, $domain, $locale, $translation);
79
    }
80
81
    /**
82
     * {@inheritdoc}
83
     */
84 2
    public function create(MessageInterface $message): void
85
    {
86 2
        $catalogue = $this->getCatalogue($message->getLocale());
87 2
        if (!$catalogue->defines($message->getKey(), $message->getDomain())) {
88 2
            $catalogue->set($message->getKey(), $message->getTranslation(), $message->getDomain());
89 2
            $this->writeCatalogue($catalogue, $message->getLocale(), $message->getDomain());
90
        }
91 2
    }
92
93
    /**
94
     * {@inheritdoc}
95
     */
96 1
    public function update(MessageInterface $message): void
97
    {
98 1
        $catalogue = $this->getCatalogue($message->getLocale());
99 1
        $catalogue->set($message->getKey(), $message->getTranslation(), $message->getDomain());
100 1
        $this->writeCatalogue($catalogue, $message->getLocale(), $message->getDomain());
101 1
    }
102
103
    /**
104
     * {@inheritdoc}
105
     */
106 1
    public function delete(string $locale, string $domain, string $key): void
107
    {
108 1
        $catalogue = $this->getCatalogue($locale);
109 1
        $messages = $catalogue->all($domain);
110 1
        unset($messages[$key]);
111
112 1
        $catalogue->replace($messages, $domain);
113 1
        $this->writeCatalogue($catalogue, $locale, $domain);
114 1
    }
115
116
    /**
117
     * {@inheritdoc}
118
     */
119 1
    public function export(MessageCatalogueInterface $catalogue, array $options = []): void
120
    {
121 1
        $locale = $catalogue->getLocale();
122 1
        $catalogue->addCatalogue($this->getCatalogue($locale));
0 ignored issues
show
$this->getCatalogue($locale) is of type object<Symfony\Component...ation\MessageCatalogue>, but the function expects a object<self>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
123 1
    }
124
125
    /**
126
     * {@inheritdoc}
127
     */
128 1
    public function import(MessageCatalogueInterface $catalogue, array $options = []): void
129
    {
130 1
        $domains = $catalogue->getDomains();
131 1
        foreach ($domains as $domain) {
132 1
            $this->writeCatalogue($catalogue, $catalogue->getLocale(), $domain);
133
        }
134 1
    }
135
136 5
    private function writeCatalogue(MessageCatalogueInterface $catalogue, string $locale, string $domain): void
137
    {
138 5
        $resources = $catalogue->getResources();
139 5
        $options = $this->options;
140 5
        $written = false;
141
        // $intlDomainSuffix = '(\\' . MessageCatalogueInterface::INTL_DOMAIN_SUFFIX . ')'; # not available in older Symfony versions
142 5
        $intlDomainSuffix = '(\\'.'+intl-icu'.')';
143 5
        $searchPatternWithIntl = '|/'.$domain.$intlDomainSuffix.'\.'.$locale.'\.([a-z]+)$|';
144 5
        $searchPatternWithoutIntl = str_replace($intlDomainSuffix, '', $searchPatternWithIntl);
145 5
        foreach ($resources as $resource) {
146 3
            $path = (string) $resource;
147 3
            if (preg_match($searchPatternWithIntl, $path, $matches)) {
148
                $options['path'] = str_replace($matches[0], '', $path);
149
                $this->writer->write($catalogue, $matches[2], $options);
0 ignored issues
show
$catalogue of type object<Symfony\Component...sageCatalogueInterface> is not a sub-type of object<Symfony\Component...ation\MessageCatalogue>. It seems like you assume a concrete implementation of the interface Symfony\Component\Transl...ssageCatalogueInterface to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
150
                $written = true;
151 3
            } elseif (preg_match($searchPatternWithoutIntl, $path, $matches)) {
152 3
                $options['path'] = str_replace($matches[0], '', $path);
153 3
                $this->writer->write($catalogue, $matches[1], $options);
0 ignored issues
show
$catalogue of type object<Symfony\Component...sageCatalogueInterface> is not a sub-type of object<Symfony\Component...ation\MessageCatalogue>. It seems like you assume a concrete implementation of the interface Symfony\Component\Transl...ssageCatalogueInterface to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
154 3
                $written = true;
155
            }
156
        }
157
158 5
        if ($written) {
159
            // We have written the translation to a file.
160 3
            return;
161
        }
162
163 2
        $options['path'] = reset($this->dir);
164 2
        $format = isset($options['default_output_format']) ? $options['default_output_format'] : 'xlf';
165 2
        $this->writer->write($catalogue, $format, $options);
0 ignored issues
show
$catalogue of type object<Symfony\Component...sageCatalogueInterface> is not a sub-type of object<Symfony\Component...ation\MessageCatalogue>. It seems like you assume a concrete implementation of the interface Symfony\Component\Transl...ssageCatalogueInterface to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
166 2
    }
167
168 6
    private function getCatalogue(string $locale): MessageCatalogue
169
    {
170 6
        if (empty($this->catalogues[$locale])) {
171 6
            $this->loadCatalogue($locale, $this->dir);
172
        }
173
174 6
        return $this->catalogues[$locale];
175
    }
176
177 6
    private function loadCatalogue(string $locale, array $dirs): void
178
    {
179 6
        $currentCatalogue = new MessageCatalogue($locale);
180 6
        foreach ($dirs as $path) {
181 6
            if (is_dir($path)) {
182 5
                $this->reader->read($path, $currentCatalogue);
183
            }
184
        }
185
186 6
        $this->catalogues[$locale] = $currentCatalogue;
187 6
    }
188
}
189