BaseTask::setTaskArguments() - Code Metrics - Inspection of "Issue #1: Robo tasks as plugins" - php-taskman/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#2)

by Pol

created 2019-04-24 19:45 UTC

BaseTask::setTaskArguments() A

↳ Parent: BaseTask

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	5
ccs	0
cts	4
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

declare(strict_types = 1);

namespace PhpTaskman\Core\Plugin;

use PhpTaskman\Core\Contract\TaskInterface;
use Robo\Contract\BuilderAwareInterface;
use Robo\TaskAccessor;

abstract class BaseTask extends \Robo\Task\BaseTask implements TaskInterface, BuilderAwareInterface
{
    use TaskAccessor;

    public const ARGUMENTS = [];
    public const NAME = 'NULL';

    /**
     * @var array
     */
    private $arguments;

    /**
     * {@inheritdoc}
     */
    public function getTaskArguments()
    {
        $arguments = $this->arguments;

        unset($arguments['task']);

        $argumentsAllowed = \array_combine(
            static::ARGUMENTS,
            static::ARGUMENTS
        );

        if (empty($argumentsAllowed)) {
            return $arguments;
        }

        foreach ($arguments as $key => $value) {
            if (isset($argumentsAllowed[$key])) {
                continue;
            }

            unset($arguments[$key]);
        }

        return $arguments;
    }

    /**
     * {@inheritdoc}
     */
    public function setTaskArguments(array $arguments = [])
    {
        $this->arguments = $arguments;

        return $this;
    }
}


1			<?php
2
3			declare(strict_types = 1);
4
5			namespace PhpTaskman\Core\Plugin;
6
7			use PhpTaskman\Core\Contract\TaskInterface;
8			use Robo\Contract\BuilderAwareInterface;
9			use Robo\TaskAccessor;
10
11			abstract class BaseTask extends \Robo\Task\BaseTask implements TaskInterface, BuilderAwareInterface
12			{
13			use TaskAccessor;
14
15			public const ARGUMENTS = [];
16			public const NAME = 'NULL';
17
18			/**
19			* @var array
20			*/
21			private $arguments;
22
23			/**
24			* {@inheritdoc}
25			*/
26			public function getTaskArguments()
27			{
28			$arguments = $this->arguments;
29
30			unset($arguments['task']);
31
32			$argumentsAllowed = \array_combine(
33			static::ARGUMENTS,
34			static::ARGUMENTS
35			);
36
37			if (empty($argumentsAllowed)) {
38			return $arguments;
39			}
40
41			foreach ($arguments as $key => $value) {
42			if (isset($argumentsAllowed[$key])) {
43			continue;
44			}
45
46			unset($arguments[$key]);
47			}
48
49			return $arguments;
50			}
51
52			/**
53			* {@inheritdoc}
54			*/
55			public function setTaskArguments(array $arguments = [])
56			{
57			$this->arguments = $arguments;
58
59			return $this;
60			}
61			}
62

php-taskman / core

Pull Request — master (#2)

BaseTask::setTaskArguments() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like